From e3ff3e610cccc6e199b27a805c6ad8f75e6db1d5 Mon Sep 17 00:00:00 2001
From: carla <carla@local-it.org>
Date: Tue, 23 Dec 2025 17:01:50 +0100
Subject: [PATCH] feat: optimize required custom fields query

---
 lib/membership/membership.ex | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/lib/membership/membership.ex b/lib/membership/membership.ex
index f5a708b..4917c7c 100644
--- a/lib/membership/membership.ex
+++ b/lib/membership/membership.ex
@@ -21,6 +21,9 @@ defmodule Mv.Membership do
   use Ash.Domain,
     extensions: [AshAdmin.Domain, AshPhoenix]
 
+  require Ash.Query
+  import Ash.Expr
+
   admin do
     show? true
   end
@@ -125,6 +128,29 @@ defmodule Mv.Membership do
     |> Ash.update(domain: __MODULE__)
   end
 
+  @doc """
+  Lists only required custom fields.
+
+  This is an optimized version that filters at the database level instead of
+  loading all custom fields and filtering in memory.
+
+  ## Returns
+
+    - `{:ok, required_custom_fields}` - List of required custom fields
+    - `{:error, error}` - Error reading custom fields
+
+  ## Examples
+
+      iex> {:ok, required_fields} = Mv.Membership.list_required_custom_fields()
+      iex> Enum.all?(required_fields, & &1.required)
+      true
+  """
+  def list_required_custom_fields do
+    Mv.Membership.CustomField
+    |> Ash.Query.filter(expr(required == true))
+    |> Ash.read(domain: __MODULE__)
+  end
+
   @doc """
   Updates the member field visibility configuration.