diff --git a/lib/membership/member.ex b/lib/membership/member.ex index 7b70e89..76ed471 100644 --- a/lib/membership/member.ex +++ b/lib/membership/member.ex @@ -1300,24 +1300,20 @@ defmodule Mv.Membership.Member do end end - # Extracts custom field values from existing member data (update scenario). - # Actor must come from context; no system-actor fallback (per guidelines). - # When no actor is present we skip the load and return empty map. + # Extracts custom field values from existing member data (update scenario) defp extract_existing_values(member_data, changeset) do - case Map.get(changeset.context, :actor) do - nil -> + actor = + Map.get(changeset.context, :actor) || + Mv.Helpers.SystemActor.get_system_actor() + + opts = Helpers.ash_actor_opts(actor) + + case Ash.load(member_data, :custom_field_values, opts) do + {:ok, %{custom_field_values: existing_values}} -> + Enum.reduce(existing_values, %{}, &extract_value_from_cfv/2) + + _ -> %{} - - actor -> - opts = Helpers.ash_actor_opts(actor) - - case Ash.load(member_data, :custom_field_values, opts) do - {:ok, %{custom_field_values: existing_values}} -> - Enum.reduce(existing_values, %{}, &extract_value_from_cfv/2) - - _ -> - %{} - end end end diff --git a/lib/membership/setting.ex b/lib/membership/setting.ex index f56daa0..33445d3 100644 --- a/lib/membership/setting.ex +++ b/lib/membership/setting.ex @@ -242,7 +242,7 @@ defmodule Mv.Membership.Setting do attribute :vereinfacht_api_key, :string do allow_nil? true - public? false + public? true description "Vereinfacht API key (Bearer token)" sensitive? true end diff --git a/lib/mv/vereinfacht/client.ex b/lib/mv/vereinfacht/client.ex index 58e06a9..2aafc7f 100644 --- a/lib/mv/vereinfacht/client.ex +++ b/lib/mv/vereinfacht/client.ex @@ -134,25 +134,15 @@ defmodule Mv.Vereinfacht.Client do end end - @find_contact_page_size 100 - @find_contact_max_pages 100 - defp do_find_contact_by_email(email) do - normalized = String.trim(email) |> String.downcase() - do_find_contact_by_email_page(1, normalized) - end - - defp do_find_contact_by_email_page(page, _normalized) when page > @find_contact_max_pages do - {:error, :not_found} - end - - defp do_find_contact_by_email_page(page, normalized) do - base = base_url() |> String.trim_trailing("/") |> then(&"#{&1}/finance-contacts") - url = base <> "?page[size]=#{@find_contact_page_size}&page[number]=#{page}" + url = + base_url() + |> String.trim_trailing("/") + |> then(&"#{&1}/finance-contacts") case Req.get(url, [headers: headers(api_key())] ++ req_http_options()) do {:ok, %{status: 200, body: body}} when is_map(body) -> - handle_find_contact_page_response(body, page, normalized) + parse_find_by_email_response(body, email) {:ok, %{status: status, body: body}} -> {:error, {:http, status, extract_error_message(body)}} @@ -162,21 +152,15 @@ defmodule Mv.Vereinfacht.Client do end end - defp handle_find_contact_page_response(body, page, normalized) do + defp parse_find_by_email_response(body, email) do + normalized = String.trim(email) |> String.downcase() + case find_contact_id_by_email_in_list(body, normalized) do - id when is_binary(id) -> {:ok, id} - nil -> maybe_find_contact_next_page(body, page, normalized) + nil -> {:error, :not_found} + id -> {:ok, id} end end - defp maybe_find_contact_next_page(body, page, normalized) do - data = Map.get(body, "data") || [] - - if length(data) < @find_contact_page_size, - do: {:error, :not_found}, - else: do_find_contact_by_email_page(page + 1, normalized) - end - defp find_contact_id_by_email_in_list(%{"data" => list}, normalized) when is_list(list) do Enum.find_value(list, fn %{"id" => id, "attributes" => %{"email" => att_email, "isExternal" => true}} @@ -265,28 +249,31 @@ defmodule Mv.Vereinfacht.Client do base <> sep <> "include=" <> URI.encode(value, &URI.char_unreserved?/1) end - # Allowlist of receipt attribute keys we expose (avoids String.to_atom on arbitrary API input / DoS). - @receipt_attr_allowlist ~w[amount bookingDate createdAt receiptType referenceNumber status updatedAt]a - defp extract_receipts_from_response(%{"included" => included}) when is_list(included) do included |> Enum.filter(&match?(%{"type" => "receipts"}, &1)) |> Enum.map(fn %{"id" => id, "attributes" => attrs} = r -> - Map.merge(%{id: id, type: r["type"]}, receipt_attrs_allowlist(attrs || %{})) + Map.merge(%{id: id, type: r["type"]}, string_keys_to_atoms(attrs || %{})) end) end defp extract_receipts_from_response(_), do: [] - defp receipt_attrs_allowlist(attrs) when is_map(attrs) do - Map.new(@receipt_attr_allowlist, fn key -> - str_key = to_string(key) - {key, Map.get(attrs, str_key)} - end) - |> Enum.reject(fn {_k, v} -> is_nil(v) end) - |> Map.new() + defp string_keys_to_atoms(map) when is_map(map) do + Map.new(map, fn {k, v} -> {to_atom_key(k), v} end) end + defp to_atom_key(k) when is_binary(k) do + try do + String.to_existing_atom(k) + rescue + ArgumentError -> String.to_atom(k) + end + end + + defp to_atom_key(k) when is_atom(k), do: k + defp to_atom_key(k), do: to_atom_key(to_string(k)) + defp base_url, do: Mv.Config.vereinfacht_api_url() defp api_key, do: Mv.Config.vereinfacht_api_key() defp club_id, do: Mv.Config.vereinfacht_club_id() diff --git a/lib/mv/vereinfacht/vereinfacht.ex b/lib/mv/vereinfacht/vereinfacht.ex index ce8005d..b4b9282 100644 --- a/lib/mv/vereinfacht/vereinfacht.ex +++ b/lib/mv/vereinfacht/vereinfacht.ex @@ -8,7 +8,6 @@ defmodule Mv.Vereinfacht do - `sync_members_without_contact/0` – Bulk sync of members without a contact ID. """ require Ash.Query - import Ash.Expr alias Mv.Vereinfacht.Client alias Mv.Membership.Member alias Mv.Helpers.SystemActor @@ -129,9 +128,7 @@ defmodule Mv.Vereinfacht do query = Member - |> Ash.Query.filter( - expr(is_nil(^ref(:vereinfacht_contact_id)) or ^ref(:vereinfacht_contact_id) == "") - ) + |> Ash.Query.filter(is_nil(vereinfacht_contact_id)) case Ash.read(query, opts) do {:ok, members} -> diff --git a/lib/mv_web/live/member_live/show/membership_fees_component.ex b/lib/mv_web/live/member_live/show/membership_fees_component.ex index 1ce6f77..946f249 100644 --- a/lib/mv_web/live/member_live/show/membership_fees_component.ex +++ b/lib/mv_web/live/member_live/show/membership_fees_component.ex @@ -52,7 +52,7 @@ defmodule MvWeb.MemberLive.Show.MembershipFeesComponent do <%!-- Vereinfacht: contact info when synced, or warning when API is configured but no contact --%> <%= if Mv.Config.vereinfacht_configured?() do %> - <%= if @vereinfacht_contact_present do %> + <%= if @member.vereinfacht_contact_id do %>