From def399122c354e4b6d7534ba3c290ec4b10511cd Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 16:14:58 +0100 Subject: [PATCH 1/7] fix tests with async true --- test/mv_web/member_live/index_field_visibility_test.exs | 3 ++- test/mv_web/user_live/form_test.exs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/mv_web/member_live/index_field_visibility_test.exs b/test/mv_web/member_live/index_field_visibility_test.exs index 6e1642a..05fa768 100644 --- a/test/mv_web/member_live/index_field_visibility_test.exs +++ b/test/mv_web/member_live/index_field_visibility_test.exs @@ -10,7 +10,8 @@ defmodule MvWeb.MemberLive.IndexFieldVisibilityTest do - Integration with member list display - Custom fields visibility """ - use MvWeb.ConnCase, async: true + # async: false to prevent PostgreSQL deadlocks when creating members and custom fields + use MvWeb.ConnCase, async: false import Phoenix.LiveViewTest require Ash.Query diff --git a/test/mv_web/user_live/form_test.exs b/test/mv_web/user_live/form_test.exs index b8f7313..334dedd 100644 --- a/test/mv_web/user_live/form_test.exs +++ b/test/mv_web/user_live/form_test.exs @@ -1,5 +1,6 @@ defmodule MvWeb.UserLive.FormTest do - use MvWeb.ConnCase, async: true + # async: false to prevent PostgreSQL deadlocks when creating members and users + use MvWeb.ConnCase, async: false import Phoenix.LiveViewTest # Helper to setup authenticated connection and live view From 5718a37aca64d5988674a4c9fc465dbf22ed1d68 Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 16:15:22 +0100 Subject: [PATCH 2/7] fix: show custom field input fields also when empty --- lib/mv_web/live/member_live/show.ex | 63 +++++++++++++++++++---------- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/lib/mv_web/live/member_live/show.ex b/lib/mv_web/live/member_live/show.ex index d84fca4..52c009a 100644 --- a/lib/mv_web/live/member_live/show.ex +++ b/lib/mv_web/live/member_live/show.ex @@ -131,15 +131,26 @@ defmodule MvWeb.MemberLive.Show do <%!-- Custom Fields Section --%> - <%= if Enum.any?(@member.custom_field_values) do %> + <%= if Enum.any?(@custom_fields_with_values) do %>
<.section_box title={gettext("Custom Fields")}>
- <%= for cfv <- sort_custom_field_values(@member.custom_field_values) do %> - <% custom_field = cfv.custom_field %> - <% value_type = custom_field && custom_field.value_type %> - <.data_field label={custom_field && custom_field.name}> - {format_custom_field_value(cfv.value, value_type)} + <%= for {custom_field, cfv} <- @custom_fields_with_values do %> + <.data_field label={custom_field.name}> + <%= if cfv && cfv.value do %> + <%= if custom_field.value_type == :email && cfv.value.value && String.trim(cfv.value.value) != "" do %> + + {cfv.value.value} + + <% else %> + {format_custom_field_value(cfv.value, custom_field.value_type)} + <% end %> + <% else %> + {format_custom_field_value(nil, custom_field.value_type)} + <% end %> <% end %>
@@ -175,7 +186,7 @@ defmodule MvWeb.MemberLive.Show do @impl true def mount(_params, _session, socket) do - {:ok, socket} + {:ok, assign(socket, :custom_fields_with_values, [])} end @impl true @@ -187,10 +198,28 @@ defmodule MvWeb.MemberLive.Show do member = Ash.read_one!(query) + # Load all custom fields to display all of them, even if they have no values + {:ok, custom_fields} = Mv.Membership.list_custom_fields() + + # Create a map of custom_field_id -> custom_field_value for quick lookup + custom_field_values_map = + member.custom_field_values + |> Enum.map(fn cfv -> {cfv.custom_field_id, cfv} end) + |> Map.new() + + # Match all custom fields with their values (if they exist) + custom_fields_with_values = + Enum.map(custom_fields, fn cf -> + cfv = Map.get(custom_field_values_map, cf.id) + {cf, cfv} + end) + |> Enum.sort_by(fn {cf, _cfv} -> cf.name end) + {:noreply, socket |> assign(:page_title, page_title(socket.assigns.live_action)) - |> assign(:member, member)} + |> assign(:member, member) + |> assign(:custom_fields_with_values, custom_fields_with_values)} end defp page_title(:show), do: gettext("Show Member") @@ -272,19 +301,13 @@ defmodule MvWeb.MemberLive.Show do defp format_date(date), do: to_string(date) - # Sorts custom field values by custom field name - defp sort_custom_field_values(custom_field_values) do - Enum.sort_by(custom_field_values, fn cfv -> - (cfv.custom_field && cfv.custom_field.name) || "" - end) - end - # Formats custom field value based on type + # Returns empty string for nil/empty values (consistent with member fields behavior) defp format_custom_field_value(%Ash.Union{value: value, type: type}, _expected_type) do format_custom_field_value(value, type) end - defp format_custom_field_value(nil, _type), do: "—" + defp format_custom_field_value(nil, _type), do: "" defp format_custom_field_value(value, :boolean) when is_boolean(value) do if value, do: gettext("Yes"), else: gettext("No") @@ -295,11 +318,7 @@ defmodule MvWeb.MemberLive.Show do end defp format_custom_field_value(value, :email) when is_binary(value) do - assigns = %{email: value} - - ~H""" - {@email} - """ + if String.trim(value) == "", do: "", else: value end defp format_custom_field_value(value, :integer) when is_integer(value) do @@ -307,7 +326,7 @@ defmodule MvWeb.MemberLive.Show do end defp format_custom_field_value(value, _type) when is_binary(value) do - if String.trim(value) == "", do: "—", else: value + if String.trim(value) == "", do: "", else: value end defp format_custom_field_value(value, _type), do: to_string(value) From 8e58829e952624023498d34ab262ada14808e8ae Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 17:07:38 +0100 Subject: [PATCH 3/7] fix: improve performance loading custom fields --- lib/mv_web/live/member_live/show.ex | 119 +++++++++++++++++----------- 1 file changed, 72 insertions(+), 47 deletions(-) diff --git a/lib/mv_web/live/member_live/show.ex b/lib/mv_web/live/member_live/show.ex index 52c009a..479f170 100644 --- a/lib/mv_web/live/member_live/show.ex +++ b/lib/mv_web/live/member_live/show.ex @@ -73,12 +73,7 @@ defmodule MvWeb.MemberLive.Show do <%!-- Email --%>
<.data_field label={gettext("Email")}> - - {@member.email} - + <.mailto_link email={@member.email} display={@member.email} />
@@ -131,26 +126,14 @@ defmodule MvWeb.MemberLive.Show do
<%!-- Custom Fields Section --%> - <%= if Enum.any?(@custom_fields_with_values) do %> + <%= if Enum.any?(@custom_fields) do %>
<.section_box title={gettext("Custom Fields")}>
- <%= for {custom_field, cfv} <- @custom_fields_with_values do %> + <%= for custom_field <- @custom_fields do %> + <% cfv = find_custom_field_value(@member.custom_field_values, custom_field.id) %> <.data_field label={custom_field.name}> - <%= if cfv && cfv.value do %> - <%= if custom_field.value_type == :email && cfv.value.value && String.trim(cfv.value.value) != "" do %> - - {cfv.value.value} - - <% else %> - {format_custom_field_value(cfv.value, custom_field.value_type)} - <% end %> - <% else %> - {format_custom_field_value(nil, custom_field.value_type)} - <% end %> + {format_custom_field_value(cfv, custom_field.value_type)} <% end %>
@@ -186,11 +169,18 @@ defmodule MvWeb.MemberLive.Show do @impl true def mount(_params, _session, socket) do - {:ok, assign(socket, :custom_fields_with_values, [])} + {:ok, socket} end @impl true def handle_params(%{"id" => id}, _, socket) do + # Load custom fields once using assign_new to avoid repeated queries + socket = assign_new(socket, :custom_fields, fn -> + Mv.Membership.CustomField + |> Ash.Query.sort(name: :asc) + |> Ash.read!() + end) + query = Mv.Membership.Member |> filter(id == ^id) @@ -198,28 +188,10 @@ defmodule MvWeb.MemberLive.Show do member = Ash.read_one!(query) - # Load all custom fields to display all of them, even if they have no values - {:ok, custom_fields} = Mv.Membership.list_custom_fields() - - # Create a map of custom_field_id -> custom_field_value for quick lookup - custom_field_values_map = - member.custom_field_values - |> Enum.map(fn cfv -> {cfv.custom_field_id, cfv} end) - |> Map.new() - - # Match all custom fields with their values (if they exist) - custom_fields_with_values = - Enum.map(custom_fields, fn cf -> - cfv = Map.get(custom_field_values_map, cf.id) - {cf, cfv} - end) - |> Enum.sort_by(fn {cf, _cfv} -> cf.name end) - {:noreply, socket |> assign(:page_title, page_title(socket.assigns.live_action)) - |> assign(:member, member) - |> assign(:custom_fields_with_values, custom_fields_with_values)} + |> assign(:member, member)} end defp page_title(:show), do: gettext("Show Member") @@ -265,6 +237,30 @@ defmodule MvWeb.MemberLive.Show do """ end + # Renders a mailto link if email is present, otherwise renders nothing + attr :email, :string, required: true + attr :display, :string, default: nil + + defp mailto_link(assigns) do + display_text = assigns.display || assigns.email + + if assigns.email && String.trim(assigns.email) != "" do + assigns = %{email: assigns.email, display: display_text} + ~H""" + + {@display} + + """ + else + ~H""" + — + """ + end + end + # ----------------------------------------------------------------- # Helper Functions # ----------------------------------------------------------------- @@ -301,14 +297,28 @@ defmodule MvWeb.MemberLive.Show do defp format_date(date), do: to_string(date) + # Finds custom field value for a given custom field id + defp find_custom_field_value(nil, _custom_field_id), do: nil + defp find_custom_field_value(custom_field_values, custom_field_id) when is_list(custom_field_values) do + Enum.find(custom_field_values, fn cfv -> + cfv.custom_field_id == custom_field_id or + (cfv.custom_field && cfv.custom_field.id == custom_field_id) + end) + end + defp find_custom_field_value(_custom_field_values, _custom_field_id), do: nil + # Formats custom field value based on type - # Returns empty string for nil/empty values (consistent with member fields behavior) + # Handles both CustomFieldValue structs and direct values + defp format_custom_field_value(nil, _type), do: render_empty_value() + + defp format_custom_field_value(%Mv.Membership.CustomFieldValue{} = cfv, value_type) do + format_custom_field_value(cfv.value, value_type) + end + defp format_custom_field_value(%Ash.Union{value: value, type: type}, _expected_type) do format_custom_field_value(value, type) end - defp format_custom_field_value(nil, _type), do: "" - defp format_custom_field_value(value, :boolean) when is_boolean(value) do if value, do: gettext("Yes"), else: gettext("No") end @@ -318,7 +328,14 @@ defmodule MvWeb.MemberLive.Show do end defp format_custom_field_value(value, :email) when is_binary(value) do - if String.trim(value) == "", do: "", else: value + if String.trim(value) == "" do + render_empty_value() + else + assigns = %{email: value} + ~H""" + <.mailto_link email={@email} display={@email} /> + """ + end end defp format_custom_field_value(value, :integer) when is_integer(value) do @@ -326,8 +343,16 @@ defmodule MvWeb.MemberLive.Show do end defp format_custom_field_value(value, _type) when is_binary(value) do - if String.trim(value) == "", do: "", else: value + if String.trim(value) == "", do: render_empty_value(), else: value end defp format_custom_field_value(value, _type), do: to_string(value) + + # Renders placeholder for empty custom field values + defp render_empty_value do + assigns = %{} + ~H""" + — + """ + end end From 398a63a98f3b8ace8105bb39d382b3ee43278486 Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 17:07:52 +0100 Subject: [PATCH 4/7] add tests for empty custom field section --- test/mv_web/member_live/show_test.exs | 174 ++++++++++++++++++++++++++ 1 file changed, 174 insertions(+) create mode 100644 test/mv_web/member_live/show_test.exs diff --git a/test/mv_web/member_live/show_test.exs b/test/mv_web/member_live/show_test.exs new file mode 100644 index 0000000..6ee9b50 --- /dev/null +++ b/test/mv_web/member_live/show_test.exs @@ -0,0 +1,174 @@ +defmodule MvWeb.MemberLive.ShowTest do + @moduledoc """ + Tests for the member show page. + + Tests cover: + - Displaying member information + - Custom Fields section visibility (Issue #282 regression test) + - Custom field values formatting + + ## Note on async: false + Tests use `async: false` (not `async: true`) to prevent PostgreSQL deadlocks + when creating members and custom fields concurrently. This is intentional and + documented here to avoid confusion in commit messages. + """ + # async: false to prevent PostgreSQL deadlocks when creating members and custom fields + use MvWeb.ConnCase, async: false + import Phoenix.LiveViewTest + require Ash.Query + + alias Mv.Membership.{CustomField, CustomFieldValue, Member} + + setup do + # Create test member + {:ok, member} = + Member + |> Ash.Changeset.for_create(:create_member, %{ + first_name: "Alice", + last_name: "Anderson", + email: "alice@example.com" + }) + |> Ash.create() + + %{member: member} + end + + describe "custom fields section visibility (Issue #282)" do + test "displays Custom Fields section even when member has no custom field values", %{ + conn: conn, + member: member + } do + # Create a custom field but no value for the member + {:ok, custom_field} = + CustomField + |> Ash.Changeset.for_create(:create, %{ + name: "phone_mobile", + value_type: :string + }) + |> Ash.create() + + conn = conn_with_oidc_user(conn) + {:ok, view, html} = live(conn, ~p"/members/#{member}") + + # Custom Fields section should be visible + assert html =~ gettext("Custom Fields") + + # Custom field label should be visible + assert html =~ custom_field.name + + # Value should show placeholder for empty value + assert html =~ "—" or html =~ gettext("Not set") + end + + test "displays Custom Fields section with multiple custom fields, some without values", %{ + conn: conn, + member: member + } do + # Create multiple custom fields + {:ok, field1} = + CustomField + |> Ash.Changeset.for_create(:create, %{ + name: "phone_mobile", + value_type: :string + }) + |> Ash.create() + + {:ok, field2} = + CustomField + |> Ash.Changeset.for_create(:create, %{ + name: "membership_number", + value_type: :integer + }) + |> Ash.create() + + # Create value only for first field + {:ok, _cfv} = + CustomFieldValue + |> Ash.Changeset.for_create(:create, %{ + member_id: member.id, + custom_field_id: field1.id, + value: %{"_union_type" => "string", "_union_value" => "+49123456789"} + }) + |> Ash.create() + + conn = conn_with_oidc_user(conn) + {:ok, view, html} = live(conn, ~p"/members/#{member}") + + # Custom Fields section should be visible + assert html =~ gettext("Custom Fields") + + # Both field labels should be visible + assert html =~ field1.name + assert html =~ field2.name + + # First field should show value + assert html =~ "+49123456789" + + # Second field should show placeholder + assert html =~ "—" or html =~ gettext("Not set") + end + + test "does not display Custom Fields section when no custom fields exist", %{ + conn: conn, + member: member + } do + conn = conn_with_oidc_user(conn) + {:ok, view, html} = live(conn, ~p"/members/#{member}") + + # Custom Fields section should NOT be visible + refute html =~ gettext("Custom Fields") + end + end + + describe "custom field value formatting" do + test "formats string custom field values", %{conn: conn, member: member} do + {:ok, custom_field} = + CustomField + |> Ash.Changeset.for_create(:create, %{ + name: "phone_mobile", + value_type: :string + }) + |> Ash.create() + + {:ok, _cfv} = + CustomFieldValue + |> Ash.Changeset.for_create(:create, %{ + member_id: member.id, + custom_field_id: custom_field.id, + value: %{"_union_type" => "string", "_union_value" => "+49123456789"} + }) + |> Ash.create() + + conn = conn_with_oidc_user(conn) + {:ok, view, html} = live(conn, ~p"/members/#{member}") + + assert html =~ "+49123456789" + end + + test "formats email custom field values as mailto links", %{conn: conn, member: member} do + {:ok, custom_field} = + CustomField + |> Ash.Changeset.for_create(:create, %{ + name: "private_email", + value_type: :email + }) + |> Ash.create() + + {:ok, _cfv} = + CustomFieldValue + |> Ash.Changeset.for_create(:create, %{ + member_id: member.id, + custom_field_id: custom_field.id, + value: %{"_union_type" => "email", "_union_value" => "private@example.com"} + }) + |> Ash.create() + + conn = conn_with_oidc_user(conn) + {:ok, view, html} = live(conn, ~p"/members/#{member}") + + # Should contain mailto link + assert html =~ ~s(href="mailto:private@example.com") + assert html =~ "private@example.com" + end + end +end From 33652265b82dec2a330bef7727b8bf1c567082e4 Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 17:10:52 +0100 Subject: [PATCH 5/7] feat: add accessible empty value also to member fields --- lib/mv_web/live/member_live/show.ex | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/mv_web/live/member_live/show.ex b/lib/mv_web/live/member_live/show.ex index 479f170..c9c92f0 100644 --- a/lib/mv_web/live/member_live/show.ex +++ b/lib/mv_web/live/member_live/show.ex @@ -237,7 +237,7 @@ defmodule MvWeb.MemberLive.Show do """ end - # Renders a mailto link if email is present, otherwise renders nothing + # Renders a mailto link if email is present, otherwise renders empty value placeholder attr :email, :string, required: true attr :display, :string, default: nil @@ -255,9 +255,7 @@ defmodule MvWeb.MemberLive.Show do """ else - ~H""" - — - """ + render_empty_value() end end @@ -265,8 +263,8 @@ defmodule MvWeb.MemberLive.Show do # Helper Functions # ----------------------------------------------------------------- - defp display_value(nil), do: "" - defp display_value(""), do: "" + defp display_value(nil), do: render_empty_value() + defp display_value(""), do: render_empty_value() defp display_value(value), do: value defp format_address(member) do @@ -348,11 +346,16 @@ defmodule MvWeb.MemberLive.Show do defp format_custom_field_value(value, _type), do: to_string(value) - # Renders placeholder for empty custom field values + # Renders accessible placeholder for empty values + # Uses translated text for screen readers while maintaining visual consistency + # The visual "—" is hidden from screen readers, while the translated text is only visible to screen readers defp render_empty_value do - assigns = %{} + assigns = %{text: gettext("Not set")} ~H""" - — + + + {@text} + """ end end From 3cf8244cd676f7ce37a4eccc88c2443f16d30757 Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 18:14:59 +0100 Subject: [PATCH 6/7] fix linting errors --- lib/mv_web/live/member_live/show.ex | 19 +++++++++++++------ priv/gettext/de/LC_MESSAGES/default.po | 11 +++++------ priv/gettext/default.pot | 5 +++++ priv/gettext/en/LC_MESSAGES/default.po | 10 +++++----- 4 files changed, 28 insertions(+), 17 deletions(-) diff --git a/lib/mv_web/live/member_live/show.ex b/lib/mv_web/live/member_live/show.ex index c9c92f0..7cdc875 100644 --- a/lib/mv_web/live/member_live/show.ex +++ b/lib/mv_web/live/member_live/show.ex @@ -175,11 +175,12 @@ defmodule MvWeb.MemberLive.Show do @impl true def handle_params(%{"id" => id}, _, socket) do # Load custom fields once using assign_new to avoid repeated queries - socket = assign_new(socket, :custom_fields, fn -> - Mv.Membership.CustomField - |> Ash.Query.sort(name: :asc) - |> Ash.read!() - end) + socket = + assign_new(socket, :custom_fields, fn -> + Mv.Membership.CustomField + |> Ash.Query.sort(name: :asc) + |> Ash.read!() + end) query = Mv.Membership.Member @@ -246,6 +247,7 @@ defmodule MvWeb.MemberLive.Show do if assigns.email && String.trim(assigns.email) != "" do assigns = %{email: assigns.email, display: display_text} + ~H""" cfv.custom_field_id == custom_field_id or (cfv.custom_field && cfv.custom_field.id == custom_field_id) end) end + defp find_custom_field_value(_custom_field_values, _custom_field_id), do: nil # Formats custom field value based on type @@ -330,6 +335,7 @@ defmodule MvWeb.MemberLive.Show do render_empty_value() else assigns = %{email: value} + ~H""" <.mailto_link email={@email} display={@email} /> """ @@ -351,6 +357,7 @@ defmodule MvWeb.MemberLive.Show do # The visual "—" is hidden from screen readers, while the translated text is only visible to screen readers defp render_empty_value do assigns = %{text: gettext("Not set")} + ~H""" diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po index ec6812a..1c298e9 100644 --- a/priv/gettext/de/LC_MESSAGES/default.po +++ b/priv/gettext/de/LC_MESSAGES/default.po @@ -1422,6 +1422,11 @@ msgstr "Jährliches Intervall – Beitrittszeitraum nicht einbezogen" msgid "Yearly Interval - Joining Cycle Included" msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen" +#: lib/mv_web/live/member_live/show.ex +#, elixir-autogen, elixir-format +msgid "Not set" +msgstr "Nicht gesetzt" + #~ #: lib/mv_web/live/custom_field_live/show.ex #~ #, elixir-autogen, elixir-format #~ msgid "Auto-generated identifier (immutable)" @@ -1494,12 +1499,6 @@ msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen" #~ msgid "New Custom field" #~ msgstr "Benutzerdefiniertes Feld speichern" -#~ #: lib/mv_web/live/user_live/form.ex -#~ #: lib/mv_web/live/user_live/show.ex -#~ #, elixir-autogen, elixir-format -#~ msgid "Not set" -#~ msgstr "Nicht gesetzt" - #~ #: lib/mv_web/live/contribution_settings_live.ex #~ #, elixir-autogen, elixir-format #~ msgid "Quarterly Interval - Joining Period Excluded" diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot index e2bbf32..5450ee0 100644 --- a/priv/gettext/default.pot +++ b/priv/gettext/default.pot @@ -1422,3 +1422,8 @@ msgstr "" #, elixir-autogen, elixir-format msgid "Yearly Interval - Joining Cycle Included" msgstr "" + +#: lib/mv_web/live/member_live/show.ex +#, elixir-autogen, elixir-format +msgid "Not set" +msgstr "" diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po index d3ee646..095ec30 100644 --- a/priv/gettext/en/LC_MESSAGES/default.po +++ b/priv/gettext/en/LC_MESSAGES/default.po @@ -1423,6 +1423,11 @@ msgstr "" msgid "Yearly Interval - Joining Cycle Included" msgstr "" +#: lib/mv_web/live/member_live/show.ex +#, elixir-autogen, elixir-format, fuzzy +msgid "Not set" +msgstr "" + #~ #: lib/mv_web/live/custom_field_live/show.ex #~ #, elixir-autogen, elixir-format #~ msgid "Auto-generated identifier (immutable)" @@ -1495,11 +1500,6 @@ msgstr "" #~ msgid "New Custom field" #~ msgstr "" -#~ #: lib/mv_web/live/user_live/show.ex -#~ #, elixir-autogen, elixir-format, fuzzy -#~ msgid "Not set" -#~ msgstr "" - #~ #: lib/mv_web/live/contribution_settings_live.ex #~ #, elixir-autogen, elixir-format #~ msgid "Quarterly Interval - Joining Period Excluded" From f87e6d3e1d13e019e2dc1734cdcbff8e6021124e Mon Sep 17 00:00:00 2001 From: carla Date: Tue, 23 Dec 2025 18:21:15 +0100 Subject: [PATCH 7/7] fix tests --- test/mv_web/member_live/show_test.exs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/mv_web/member_live/show_test.exs b/test/mv_web/member_live/show_test.exs index 6ee9b50..1e04559 100644 --- a/test/mv_web/member_live/show_test.exs +++ b/test/mv_web/member_live/show_test.exs @@ -16,6 +16,7 @@ defmodule MvWeb.MemberLive.ShowTest do use MvWeb.ConnCase, async: false import Phoenix.LiveViewTest require Ash.Query + use Gettext, backend: MvWeb.Gettext alias Mv.Membership.{CustomField, CustomFieldValue, Member} @@ -48,7 +49,7 @@ defmodule MvWeb.MemberLive.ShowTest do |> Ash.create() conn = conn_with_oidc_user(conn) - {:ok, view, html} = live(conn, ~p"/members/#{member}") + {:ok, _view, html} = live(conn, ~p"/members/#{member}") # Custom Fields section should be visible assert html =~ gettext("Custom Fields") @@ -92,7 +93,7 @@ defmodule MvWeb.MemberLive.ShowTest do |> Ash.create() conn = conn_with_oidc_user(conn) - {:ok, view, html} = live(conn, ~p"/members/#{member}") + {:ok, _view, html} = live(conn, ~p"/members/#{member}") # Custom Fields section should be visible assert html =~ gettext("Custom Fields") @@ -113,7 +114,7 @@ defmodule MvWeb.MemberLive.ShowTest do member: member } do conn = conn_with_oidc_user(conn) - {:ok, view, html} = live(conn, ~p"/members/#{member}") + {:ok, _view, html} = live(conn, ~p"/members/#{member}") # Custom Fields section should NOT be visible refute html =~ gettext("Custom Fields") @@ -140,7 +141,7 @@ defmodule MvWeb.MemberLive.ShowTest do |> Ash.create() conn = conn_with_oidc_user(conn) - {:ok, view, html} = live(conn, ~p"/members/#{member}") + {:ok, _view, html} = live(conn, ~p"/members/#{member}") assert html =~ "+49123456789" end @@ -164,7 +165,7 @@ defmodule MvWeb.MemberLive.ShowTest do |> Ash.create() conn = conn_with_oidc_user(conn) - {:ok, view, html} = live(conn, ~p"/members/#{member}") + {:ok, _view, html} = live(conn, ~p"/members/#{member}") # Should contain mailto link assert html =~ ~s(href="mailto:private@example.com")