<%!-- Status and review (submitted_at, status; if decided: approved/rejected at, reviewed by) --%>
{gettext("Status and review")}
-
- <.field_row
- label={gettext("Submitted at")}
- value={DateFormatter.format_datetime(@join_request.submitted_at, @browser_timezone)}
- />
-
-
{gettext("Status")}:
-
+
+
+ <.field_row
+ label={gettext("Submitted at")}
+ value={DateFormatter.format_datetime(@join_request.submitted_at, @browser_timezone)}
+ />
+ <.field_row label={gettext("Status")}>
<.badge variant={JoinRequestHelpers.status_badge_variant(@join_request.status)}>
{JoinRequestHelpers.format_status(@join_request.status)}
-
-
- <%= if @join_request.status in [:approved, :rejected] do %>
- <%= if @join_request.approved_at do %>
+
+ <%= if @join_request.status in [:approved, :rejected] do %>
+ <%= if @join_request.approved_at do %>
+ <.field_row
+ label={gettext("Approved at")}
+ value={
+ DateFormatter.format_datetime(@join_request.approved_at, @browser_timezone)
+ }
+ />
+ <% end %>
+ <%= if @join_request.rejected_at do %>
+ <.field_row
+ label={gettext("Rejected at")}
+ value={
+ DateFormatter.format_datetime(@join_request.rejected_at, @browser_timezone)
+ }
+ />
+ <% end %>
<.field_row
- label={gettext("Approved at")}
- value={
- DateFormatter.format_datetime(@join_request.approved_at, @browser_timezone)
- }
+ label={gettext("Review by")}
+ value={JoinRequestHelpers.reviewer_display(@join_request)}
+ empty_text="-"
/>
<% end %>
- <%= if @join_request.rejected_at do %>
- <.field_row
- label={gettext("Rejected at")}
- value={
- DateFormatter.format_datetime(@join_request.rejected_at, @browser_timezone)
- }
- />
- <% end %>
- <.field_row
- label={gettext("Review by")}
- value={JoinRequestHelpers.reviewer_display(@join_request)}
- empty_text="-"
- />
- <% end %>
+
@@ -209,28 +224,30 @@ defmodule MvWeb.JoinRequestLive.Show do
attr :label, :string, required: true
attr :value, :any, default: nil
attr :empty_text, :string, default: nil
+ slot :inner_block
defp field_row(assigns) do
~H"""
-
- {@label}:
-
- <%= if @value && @value != "" do %>
+ {@label}:
+
+ <%= cond do %>
+ <% @inner_block != [] -> %>
+ {render_slot(@inner_block)}
+ <% @value && @value != "" -> %>
{@value}
- <% else %>
+ <% true -> %>
{@empty_text || gettext("Not specified")}
- <% end %>
-
-
+ <% end %>
+
"""
end
# Builds a single list of {label, display_value} for all applicant-provided data in join form
# order. Typed fields (email, first_name, last_name) and form_data are merged; legacy
# form_data keys (not in current join form config) are appended at the end.
- defp applicant_data_rows(join_request, ordered_field_ids) do
+ defp applicant_data_rows(join_request, ordered_field_ids, custom_field_by_id) do
member_field_strings = Constants.member_fields() |> Enum.map(&Atom.to_string/1)
form_data = join_request.form_data || %{}
@@ -244,8 +261,9 @@ defmodule MvWeb.JoinRequestLive.Show do
ordered_field_ids
|> Enum.map(fn key ->
value = Map.get(typed, key) || Map.get(form_data, key)
- label = field_key_to_label(key, member_field_strings)
- {label, format_applicant_value(value)}
+ label = field_key_to_label(key, member_field_strings, custom_field_by_id)
+ value_type = field_key_to_value_type(key, member_field_strings, custom_field_by_id)
+ {label, format_applicant_value(value, value_type)}
end)
legacy_keys =
@@ -258,34 +276,66 @@ defmodule MvWeb.JoinRequestLive.Show do
legacy_entries =
Enum.map(legacy_keys, fn key ->
- label = field_key_to_label(key, member_field_strings)
- {label, format_applicant_value(form_data[key])}
+ label = field_key_to_label(key, member_field_strings, custom_field_by_id)
+ value_type = field_key_to_value_type(key, member_field_strings, custom_field_by_id)
+ {label, format_applicant_value(form_data[key], value_type)}
end)
in_order ++ legacy_entries
end
- defp format_applicant_value(nil), do: nil
- defp format_applicant_value(""), do: nil
- defp format_applicant_value(%Date{} = date), do: DateFormatter.format_date(date)
+ defp format_applicant_value(nil, _type), do: nil
+ defp format_applicant_value("", _type), do: nil
+ defp format_applicant_value(%Date{} = date, _type), do: DateFormatter.format_date(date)
- defp format_applicant_value(value) when is_map(value),
- do: format_applicant_value_from_map(value)
+ defp format_applicant_value(value, type) when is_map(value),
+ do: format_applicant_value_from_map(value, type)
- defp format_applicant_value(value) when is_boolean(value),
+ defp format_applicant_value(value, _type) when is_boolean(value),
do: if(value, do: gettext("Yes"), else: gettext("No"))
- defp format_applicant_value(value) when is_binary(value) or is_number(value),
- do: to_string(value)
+ defp format_applicant_value(value, type) when is_binary(value),
+ do: format_binary_applicant_value(value, type)
- defp format_applicant_value(value), do: to_string(value)
+ defp format_applicant_value(value, _type) when is_number(value), do: to_string(value)
- defp format_applicant_value_from_map(value) do
+ defp format_applicant_value(value, _type), do: to_string(value)
+
+ defp format_binary_applicant_value(value, type) do
+ trimmed_value = String.trim(value)
+
+ cond do
+ trimmed_value == "" ->
+ nil
+
+ String.downcase(trimmed_value) in ["on", "true", "1"] ->
+ gettext("Yes")
+
+ String.downcase(trimmed_value) in ["off", "false", "0"] ->
+ gettext("No")
+
+ type in [:date, Ash.Type.Date] ->
+ format_iso_date_string(trimmed_value)
+
+ true ->
+ trimmed_value
+ end
+ end
+
+ defp format_iso_date_string(value) do
+ case Date.from_iso8601(value) do
+ {:ok, date} -> DateFormatter.format_date(date)
+ _ -> value
+ end
+ end
+
+ defp format_applicant_value_from_map(value, fallback_type) do
raw = Map.get(value, "_union_value") || Map.get(value, "value")
type = Map.get(value, "_union_type") || Map.get(value, "type")
+ effective_type = type || fallback_type
- if raw && type in ["date", :date] do
- format_applicant_value(raw)
+ if raw && effective_type in ["date", :date, Ash.Type.Date] do
+ format_applicant_value(raw, :date)
else
format_applicant_value_simple(raw, value)
end
@@ -299,11 +349,39 @@ defmodule MvWeb.JoinRequestLive.Show do
defp format_applicant_value_simple(raw, _value) when is_integer(raw), do: to_string(raw)
defp format_applicant_value_simple(_raw, value), do: to_string(value)
- defp field_key_to_label(key, member_field_strings) when is_binary(key) do
- if key in member_field_strings,
- do: MemberFieldsTranslations.label(String.to_existing_atom(key)),
- else: key
+ defp field_key_to_label(key, member_field_strings, custom_field_by_id)
+ when is_binary(key) do
+ if key in member_field_strings do
+ MemberFieldsTranslations.label(String.to_existing_atom(key))
+ else
+ case Map.get(custom_field_by_id, key) do
+ %{name: name} -> name
+ _ -> key
+ end
+ end
end
- defp field_key_to_label(key, _), do: to_string(key)
+ defp field_key_to_label(key, _, _), do: to_string(key)
+
+ defp field_key_to_value_type("email", _member_field_strings, _custom_field_by_id), do: :string
+
+ defp field_key_to_value_type("first_name", _member_field_strings, _custom_field_by_id),
+ do: :string
+
+ defp field_key_to_value_type("last_name", _member_field_strings, _custom_field_by_id),
+ do: :string
+
+ defp field_key_to_value_type(key, member_field_strings, custom_field_by_id)
+ when is_binary(key) do
+ if key in member_field_strings do
+ :string
+ else
+ case Map.get(custom_field_by_id, key) do
+ %{value_type: value_type} -> value_type
+ _ -> nil
+ end
+ end
+ end
+
+ defp field_key_to_value_type(_key, _member_field_strings, _custom_field_by_id), do: nil
end
diff --git a/lib/mv_web/live/member_live/show/membership_fees_component.ex b/lib/mv_web/live/member_live/show/membership_fees_component.ex
index 370d4aa..e8ddff4 100644
--- a/lib/mv_web/live/member_live/show/membership_fees_component.ex
+++ b/lib/mv_web/live/member_live/show/membership_fees_component.ex
@@ -1291,7 +1291,7 @@ defmodule MvWeb.MemberLive.Show.MembershipFeesComponent do
defp translate_receipt_status("paid"), do: gettext("Paid")
defp translate_receipt_status("unpaid"), do: gettext("Unpaid")
defp translate_receipt_status("suspended"), do: gettext("Suspended")
- defp translate_receipt_status("open"), do: gettext("Open")
+ defp translate_receipt_status("open"), do: pgettext("status", "Open")
defp translate_receipt_status("cancelled"), do: gettext("Cancelled")
defp translate_receipt_status("draft"), do: gettext("Draft")
defp translate_receipt_status("incompleted"), do: gettext("Incomplete")
diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po
index 383fb1c..52270cc 100644
--- a/priv/gettext/de/LC_MESSAGES/default.po
+++ b/priv/gettext/de/LC_MESSAGES/default.po
@@ -2396,11 +2396,6 @@ msgstr "Nur Administrator*innen oder die verknüpfte*n Benutzer*in(nen) können
msgid "Only possible if no members are assigned to this type."
msgstr "Nur möglich, wenn diesem Typ keine Mitglieder zugewiesen sind."
-#: lib/mv_web/live/member_live/show/membership_fees_component.ex
-#, elixir-autogen, elixir-format
-msgid "Open"
-msgstr "Offen"
-
#: lib/mv_web/live/member_live/index.html.heex
#, elixir-autogen, elixir-format
msgid "Open email program with BCC recipients"
@@ -3905,3 +3900,20 @@ msgstr "Nur OIDC-Anmeldung ist aktiv. Diese Option ist deaktiviert."
#, elixir-autogen, elixir-format
msgid "Only sign-in via Single Sign-On (SSO) is allowed."
msgstr "Nur Anmeldung per Single Sign-On (SSO) ist erlaubt."
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgctxt "action"
+msgid "Open"
+msgstr "Öffnen"
+
+#: lib/mv_web/live/member_live/show/membership_fees_component.ex
+#, elixir-autogen, elixir-format
+msgctxt "status"
+msgid "Open"
+msgstr "Offen"
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgid "join page URL in a new tab"
+msgstr "Beitrittslink in einem neuen Tab"
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
index 3e2eb5d..5d48691 100644
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@@ -2397,11 +2397,6 @@ msgstr ""
msgid "Only possible if no members are assigned to this type."
msgstr ""
-#: lib/mv_web/live/member_live/show/membership_fees_component.ex
-#, elixir-autogen, elixir-format
-msgid "Open"
-msgstr ""
-
#: lib/mv_web/live/member_live/index.html.heex
#, elixir-autogen, elixir-format
msgid "Open email program with BCC recipients"
@@ -3905,3 +3900,20 @@ msgstr ""
#, elixir-autogen, elixir-format
msgid "Only sign-in via Single Sign-On (SSO) is allowed."
msgstr ""
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgctxt "action"
+msgid "Open"
+msgstr ""
+
+#: lib/mv_web/live/member_live/show/membership_fees_component.ex
+#, elixir-autogen, elixir-format
+msgctxt "status"
+msgid "Open"
+msgstr ""
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgid "join page URL in a new tab"
+msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
index 21314a5..ec6f305 100644
--- a/priv/gettext/en/LC_MESSAGES/default.po
+++ b/priv/gettext/en/LC_MESSAGES/default.po
@@ -2397,11 +2397,6 @@ msgstr ""
msgid "Only possible if no members are assigned to this type."
msgstr ""
-#: lib/mv_web/live/member_live/show/membership_fees_component.ex
-#, elixir-autogen, elixir-format
-msgid "Open"
-msgstr ""
-
#: lib/mv_web/live/member_live/index.html.heex
#, elixir-autogen, elixir-format
msgid "Open email program with BCC recipients"
@@ -3905,3 +3900,20 @@ msgstr ""
#, elixir-autogen, elixir-format
msgid "Only sign-in via Single Sign-On (SSO) is allowed."
msgstr ""
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgctxt "action"
+msgid "Open"
+msgstr "Open"
+
+#: lib/mv_web/live/member_live/show/membership_fees_component.ex
+#, elixir-autogen, elixir-format
+msgctxt "status"
+msgid "Open"
+msgstr "Open"
+
+#: lib/mv_web/live/global_settings_live.ex
+#, elixir-autogen, elixir-format
+msgid "join page URL in a new tab"
+msgstr "join page URL in a new tab"
diff --git a/test/membership/member_groups_relationship_test.exs b/test/membership/member_groups_relationship_test.exs
index a72c8bc..5ecddbd 100644
--- a/test/membership/member_groups_relationship_test.exs
+++ b/test/membership/member_groups_relationship_test.exs
@@ -16,9 +16,13 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
describe "Relationships" do
test "member has many_to_many groups relationship (load with preloading)", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group1} = Membership.create_group(%{name: "Group One"}, actor: actor)
- {:ok, group2} = Membership.create_group(%{name: "Group Two"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group1} =
+ Membership.create_group(%{name: unique_group_name("Group One")}, actor: actor)
+
+ {:ok, group2} =
+ Membership.create_group(%{name: unique_group_name("Group Two")}, actor: actor)
{:ok, _mg1} =
Membership.create_member_group(%{member_id: member.id, group_id: group1.id},
@@ -40,9 +44,11 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
end
test "load multiple members with groups preloaded (N+1 prevention)", %{actor: actor} do
- {:ok, member1} = Membership.create_member(%{email: "member1@test.com"}, actor: actor)
- {:ok, member2} = Membership.create_member(%{email: "member2@test.com"}, actor: actor)
- {:ok, group} = Membership.create_group(%{name: "Test Group"}, actor: actor)
+ {:ok, member1} = Membership.create_member(%{email: unique_email("member1")}, actor: actor)
+ {:ok, member2} = Membership.create_member(%{email: unique_email("member2")}, actor: actor)
+
+ {:ok, group} =
+ Membership.create_group(%{name: unique_group_name("Test Group")}, actor: actor)
{:ok, _mg1} =
Membership.create_member_group(%{member_id: member1.id, group_id: group.id},
@@ -70,8 +76,10 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
describe "Member-Group Association Operations" do
test "add member to group via Ash API", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group} = Membership.create_group(%{name: "Test Group"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group} =
+ Membership.create_group(%{name: unique_group_name("Test Group")}, actor: actor)
assert {:ok, member_group} =
Membership.create_member_group(%{member_id: member.id, group_id: group.id},
@@ -83,8 +91,10 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
end
test "remove member from group via Ash API", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group} = Membership.create_group(%{name: "Test Group"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group} =
+ Membership.create_group(%{name: unique_group_name("Test Group")}, actor: actor)
{:ok, member_group} =
Membership.create_member_group(%{member_id: member.id, group_id: group.id},
@@ -107,10 +117,16 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
end
test "add member to multiple groups in single operation", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group1} = Membership.create_group(%{name: "Group One"}, actor: actor)
- {:ok, group2} = Membership.create_group(%{name: "Group Two"}, actor: actor)
- {:ok, group3} = Membership.create_group(%{name: "Group Three"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group1} =
+ Membership.create_group(%{name: unique_group_name("Group One")}, actor: actor)
+
+ {:ok, group2} =
+ Membership.create_group(%{name: unique_group_name("Group Two")}, actor: actor)
+
+ {:ok, group3} =
+ Membership.create_group(%{name: unique_group_name("Group Three")}, actor: actor)
# Add to all groups
{:ok, _mg1} =
@@ -138,8 +154,10 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
describe "Edge Cases" do
test "adding member to same group twice fails (duplicate prevention)", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group} = Membership.create_group(%{name: "Test Group"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group} =
+ Membership.create_group(%{name: unique_group_name("Test Group")}, actor: actor)
{:ok, _mg1} =
Membership.create_member_group(%{member_id: member.id, group_id: group.id},
@@ -154,8 +172,10 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
end
test "removing member from group they're not in (idempotent, no error)", %{actor: actor} do
- {:ok, member} = Membership.create_member(%{email: "test@test.com"}, actor: actor)
- {:ok, group} = Membership.create_group(%{name: "Test Group"}, actor: actor)
+ {:ok, member} = Membership.create_member(%{email: unique_email("member")}, actor: actor)
+
+ {:ok, group} =
+ Membership.create_group(%{name: unique_group_name("Test Group")}, actor: actor)
# Verify no association exists
{:ok, nil} =
@@ -194,4 +214,12 @@ defmodule Mv.Membership.MemberGroupsRelationshipTest do
assert result == :ok || match?({:error, _}, result)
end
end
+
+ defp unique_email(prefix) do
+ "#{prefix}-#{System.unique_integer([:positive])}@test.com"
+ end
+
+ defp unique_group_name(prefix) do
+ "#{prefix} #{System.unique_integer([:positive])}"
+ end
end
diff --git a/test/mv_web/live/global_settings_live_test.exs b/test/mv_web/live/global_settings_live_test.exs
index 92da11b..2edaf74 100644
--- a/test/mv_web/live/global_settings_live_test.exs
+++ b/test/mv_web/live/global_settings_live_test.exs
@@ -64,6 +64,21 @@ defmodule MvWeb.GlobalSettingsLiveTest do
assert html =~ "must be present"
end
+
+ test "shows open button for join page URL in same row as copy", %{conn: conn} do
+ {:ok, settings} = Membership.get_settings()
+ {:ok, _} = Membership.update_settings(settings, %{join_form_enabled: true})
+
+ {:ok, view, _html} = live(conn, ~p"/settings")
+
+ assert has_element?(view, "#copy-join-url-btn")
+
+ assert has_element?(
+ view,
+ "a[href][target=\"_blank\"][rel=\"noopener noreferrer\"]",
+ "Open"
+ )
+ end
end
describe "SMTP / E-Mail section" do
diff --git a/test/mv_web/live/join_live_test.exs b/test/mv_web/live/join_live_test.exs
index 4772e48..d0efee9 100644
--- a/test/mv_web/live/join_live_test.exs
+++ b/test/mv_web/live/join_live_test.exs
@@ -12,10 +12,9 @@ defmodule MvWeb.JoinLiveTest do
# async: false → shared sandbox; all processes (including LiveView) share the DB connection.
use MvWeb.ConnCase, async: false
import Phoenix.LiveViewTest
- import Ecto.Query
alias Mv.Membership
- alias Mv.Repo
+ alias Mv.Membership.JoinRequest
describe "GET /join" do
@tag role: :unauthenticated
@@ -55,11 +54,12 @@ defmodule MvWeb.JoinLiveTest do
})
|> render_submit()
- # Anti-enumeration delay is applied in LiveView via send_after (100–300 ms); wait for success UI.
- Process.sleep(400)
+ assert_eventually(fn -> count_join_requests() == count_before + 1 end)
+
+ assert_eventually(fn ->
+ view |> element("[data-testid='join-success-message']") |> has_element?()
+ end)
- assert count_join_requests() == count_before + 1
- assert view |> element("[data-testid='join-success-message']") |> has_element?()
assert render(view) =~ "saved your details"
assert render(view) =~ "click the link"
end
@@ -135,6 +135,181 @@ defmodule MvWeb.JoinLiveTest do
end
end
+ describe "join field labels" do
+ @tag role: :unauthenticated
+ test "renders custom field name as label for custom field IDs", %{conn: conn} do
+ {:ok, settings} = Membership.get_settings()
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
+ {:ok, custom_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Preferred Pronouns",
+ value_type: :string
+ },
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", custom_field.id],
+ join_form_field_required: %{"email" => true, custom_field.id => false}
+ })
+
+ {:ok, view, _html} = live(conn, "/join")
+
+ assert has_element?(
+ view,
+ "label[for='join-field-#{custom_field.id}'] .label-text",
+ custom_field.name
+ )
+ end
+ end
+
+ describe "join field input types" do
+ @tag role: :unauthenticated
+ test "renders boolean custom field as checkbox input", %{conn: conn} do
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, boolean_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Subscribe to newsletter",
+ value_type: :boolean
+ },
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", boolean_field.id],
+ join_form_field_required: %{"email" => true, boolean_field.id => false}
+ })
+
+ {:ok, view, _html} = live(conn, "/join")
+
+ assert has_element?(view, "#join-form")
+
+ assert has_element?(
+ view,
+ "input#join-field-#{boolean_field.id}[name='#{boolean_field.id}']"
+ )
+
+ assert has_element?(view, "input#join-field-#{boolean_field.id}[type='checkbox']")
+ refute has_element?(view, "input#join-field-#{boolean_field.id}[type='text']")
+ end
+
+ @tag role: :unauthenticated
+ test "renders typed custom fields with matching HTML input types", %{conn: conn} do
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, integer_field} =
+ Membership.create_custom_field(%{name: "Lucky number", value_type: :integer},
+ actor: system_actor
+ )
+
+ {:ok, date_field} =
+ Membership.create_custom_field(%{name: "Birth date", value_type: :date},
+ actor: system_actor
+ )
+
+ {:ok, email_field} =
+ Membership.create_custom_field(%{name: "Secondary email", value_type: :email},
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", integer_field.id, date_field.id, email_field.id],
+ join_form_field_required: %{
+ "email" => true,
+ integer_field.id => false,
+ date_field.id => false,
+ email_field.id => false
+ }
+ })
+
+ {:ok, view, _html} = live(conn, "/join")
+
+ assert has_element?(view, "input#join-field-#{integer_field.id}[type='number']")
+ assert has_element?(view, "input#join-field-#{date_field.id}[type='date']")
+ assert has_element?(view, "input#join-field-#{email_field.id}[type='email']")
+ end
+
+ @tag role: :unauthenticated
+ test "renders standard date member fields with date input type", %{conn: conn} do
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", "join_date"],
+ join_form_field_required: %{"email" => true, "join_date" => false}
+ })
+
+ {:ok, view, _html} = live(conn, "/join")
+
+ assert has_element?(view, "input#join-field-join_date[type='date']")
+ refute has_element?(view, "input#join-field-join_date[type='text']")
+ end
+ end
+
+ describe "submit join form with typed custom fields" do
+ setup do
+ reset_rate_limiter()
+ :ok
+ end
+
+ @tag role: :unauthenticated
+ test "persists checked boolean custom field and ignores non-allowlisted field", %{conn: conn} do
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, boolean_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Receive announcements",
+ value_type: :boolean
+ },
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", boolean_field.id],
+ join_form_field_required: %{"email" => true, boolean_field.id => false}
+ })
+
+ count_before = count_join_requests()
+ {:ok, view, _html} = live(conn, "/join")
+
+ view
+ |> element("#join-form")
+ |> render_submit(%{
+ "email" => "typed#{System.unique_integer([:positive])}@example.com",
+ "website" => "",
+ boolean_field.id => "on",
+ "not_allowlisted" => "should-not-be-persisted"
+ })
+
+ assert_eventually(fn -> count_join_requests() == count_before + 1 end)
+
+ assert_eventually(fn ->
+ view |> element("[data-testid='join-success-message']") |> has_element?()
+ end)
+
+ form_data = latest_join_request_form_data()
+ assert Map.get(form_data, boolean_field.id) == "on"
+ refute Map.has_key?(form_data, "not_allowlisted")
+ end
+ end
+
defp enable_join_form(enabled) do
{:ok, settings} = Membership.get_settings()
{:ok, _} = Membership.update_settings(settings, %{join_form_enabled: enabled})
@@ -154,7 +329,40 @@ defmodule MvWeb.JoinLiveTest do
end
defp count_join_requests do
- Repo.one(from j in "join_requests", select: count(j.id)) || 0
+ case Ash.count(JoinRequest, domain: Membership, authorize?: false) do
+ {:ok, count} -> count
+ _ -> 0
+ end
+ end
+
+ defp latest_join_request_form_data do
+ query =
+ JoinRequest
+ |> Ash.Query.sort(inserted_at: :desc)
+ |> Ash.Query.limit(1)
+
+ case Ash.read(query, domain: Membership, authorize?: false) do
+ {:ok, [request]} -> request.form_data || %{}
+ _ -> %{}
+ end
+ end
+
+ defp assert_eventually(fun, timeout_ms \\ 1500) when is_function(fun, 0) do
+ deadline = System.monotonic_time(:millisecond) + timeout_ms
+ do_assert_eventually(fun, deadline)
+ end
+
+ defp do_assert_eventually(fun, deadline) do
+ if fun.() do
+ true
+ else
+ if System.monotonic_time(:millisecond) < deadline do
+ Process.sleep(25)
+ do_assert_eventually(fun, deadline)
+ else
+ assert fun.()
+ end
+ end
end
defp reset_rate_limiter do
diff --git a/test/mv_web/live/join_request_live/show_test.exs b/test/mv_web/live/join_request_live/show_test.exs
new file mode 100644
index 0000000..40d5d5d
--- /dev/null
+++ b/test/mv_web/live/join_request_live/show_test.exs
@@ -0,0 +1,124 @@
+defmodule MvWeb.JoinRequestLive.ShowTest do
+ @moduledoc """
+ Tests for join request detail view label rendering.
+
+ Focus: applicant data labels for custom fields should use custom field names,
+ not raw UUIDs.
+ """
+ use MvWeb.ConnCase, async: false
+
+ import Phoenix.LiveViewTest
+
+ alias Mv.Fixtures
+ alias Mv.Membership
+ alias MvWeb.Helpers.DateFormatter
+
+ setup do
+ {:ok, settings} = Membership.get_settings()
+
+ saved = %{
+ join_form_enabled: settings.join_form_enabled,
+ join_form_field_ids: settings.join_form_field_ids,
+ join_form_field_required: settings.join_form_field_required
+ }
+
+ on_exit(fn ->
+ {:ok, current_settings} = Membership.get_settings()
+
+ Membership.update_settings(current_settings, %{
+ join_form_enabled: saved.join_form_enabled,
+ join_form_field_ids: saved.join_form_field_ids || [],
+ join_form_field_required: saved.join_form_field_required || %{}
+ })
+ end)
+
+ :ok
+ end
+
+ describe "custom field labels in applicant data" do
+ @tag role: :normal_user
+ test "renders custom field name instead of custom field UUID", %{conn: conn} do
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, custom_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Emergency contact",
+ value_type: :string
+ },
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", custom_field.id],
+ join_form_field_required: %{"email" => true, custom_field.id => false}
+ })
+
+ join_request =
+ Fixtures.submitted_join_request_fixture(%{
+ form_data: %{custom_field.id => "Alice Example"}
+ })
+
+ {:ok, view, _html} = live(conn, "/join_requests/#{join_request.id}")
+
+ assert has_element?(view, "dt", "#{custom_field.name}:")
+ assert has_element?(view, "dd", "Alice Example")
+ refute has_element?(view, "dt", "#{custom_field.id}:")
+ end
+
+ @tag role: :normal_user
+ test "formats boolean/date values and renders status in aligned row", %{conn: conn} do
+ system_actor = Mv.Helpers.SystemActor.get_system_actor()
+ {:ok, settings} = Membership.get_settings()
+
+ {:ok, boolean_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Privacy accepted",
+ value_type: :boolean
+ },
+ actor: system_actor
+ )
+
+ {:ok, date_field} =
+ Membership.create_custom_field(
+ %{
+ name: "Birth date",
+ value_type: :date
+ },
+ actor: system_actor
+ )
+
+ {:ok, _} =
+ Membership.update_settings(settings, %{
+ join_form_enabled: true,
+ join_form_field_ids: ["email", boolean_field.id, date_field.id],
+ join_form_field_required: %{
+ "email" => true,
+ boolean_field.id => false,
+ date_field.id => false
+ }
+ })
+
+ join_request =
+ Fixtures.submitted_join_request_fixture(%{
+ form_data: %{
+ boolean_field.id => "on",
+ date_field.id => "2000-01-12"
+ }
+ })
+
+ {:ok, view, _html} = live(conn, "/join_requests/#{join_request.id}")
+
+ assert has_element?(view, "dt", "Privacy accepted:")
+ assert has_element?(view, "dd", "Yes")
+ assert has_element?(view, "dt", "Birth date:")
+ assert has_element?(view, "dd", DateFormatter.format_date(~D[2000-01-12]))
+ assert has_element?(view, "dt", "Status:")
+ assert has_element?(view, "dd", "Submitted")
+ end
+ end
+end