From 044f2b927dba715024d2946bba2a1a7e6433a68d Mon Sep 17 00:00:00 2001 From: dmorlitz Date: Sat, 8 Jan 2022 21:18:06 +0000 Subject: [PATCH] feat: changed green "Done" button to read "Mark task done" (#1340) The green button can be confusing because the wording "Done" can be interpreted as "done editing the task" or "the task should be marked as done". Changing the text in the button makes the description more precise. Co-authored-by: David Morlitz Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1340 Reviewed-by: konrad Co-authored-by: dmorlitz Co-committed-by: dmorlitz --- cypress/integration/task/task.spec.js | 2 +- src/i18n/lang/en.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cypress/integration/task/task.spec.js b/cypress/integration/task/task.spec.js index 63df5651..1b85e992 100644 --- a/cypress/integration/task/task.spec.js +++ b/cypress/integration/task/task.spec.js @@ -128,7 +128,7 @@ describe('Task', () => { cy.visit(`/tasks/${tasks[0].id}`) cy.get('.task-view .action-buttons .button') - .contains('Done!') + .contains('Mark task done!') .click() cy.get('.task-view .heading .is-done') diff --git a/src/i18n/lang/en.json b/src/i18n/lang/en.json index 7e145529..29537fe3 100644 --- a/src/i18n/lang/en.json +++ b/src/i18n/lang/en.json @@ -545,7 +545,7 @@ "chooseStartDate": "Click here to set a start date", "chooseEndDate": "Click here to set an end date", "move": "Move task to a different list", - "done": "Done!", + "done": "Mark task done!", "undone": "Mark as undone", "created": "Created {0} by {1}", "updated": "Updated {0}", @@ -781,7 +781,7 @@ "then": "then", "task": { "title": "Task Page", - "done": "Mark a task as done", + "done": "Done", "assign": "Assign to a user", "labels": "Add labels to this task", "dueDate": "Change the due date of this task",