From 2af53b16b69e8bd4225167a50f49d94dd4773674 Mon Sep 17 00:00:00 2001
From: konrad <konrad@kola-entertainments.de>
Date: Mon, 2 Nov 2020 20:47:31 +0000
Subject: [PATCH] Performance improvements (#288)

Only include needed parts from lodash

Don't prefetch

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/288
Co-Authored-By: konrad <konrad@kola-entertainments.de>
Co-Committed-By: konrad <konrad@kola-entertainments.de>
---
 src/components/namespace/namespace-search.vue  |  2 +-
 src/components/sharing/userTeam.vue            |  2 +-
 src/components/tasks/edit-task.vue             |  2 +-
 src/components/tasks/partials/comments.vue     |  2 +-
 .../tasks/partials/editAssignees.vue           |  4 ++--
 src/components/tasks/partials/editLabels.vue   |  4 ++--
 src/components/tasks/partials/listSearch.vue   |  2 +-
 src/components/tasks/partials/relatedTasks.vue |  2 +-
 src/models/abstractModel.js                    |  4 +++-
 src/models/teamList.js                         |  2 +-
 src/models/teamMember.js                       |  2 +-
 src/models/teamNamespace.js                    |  2 +-
 src/models/userList.js                         |  2 +-
 src/models/userNamespace.js                    |  2 +-
 src/router/index.js                            | 18 +++++++++---------
 src/services/abstractService.js                |  3 ++-
 src/views/filters/CreateSavedFilter.vue        |  2 +-
 src/views/filters/EditSavedFilter.vue          |  2 +-
 src/views/labels/ListLabels.vue                |  2 +-
 src/views/list/EditList.vue                    |  2 +-
 src/views/namespaces/EditNamespace.vue         |  2 +-
 src/views/tasks/TaskDetailView.vue             |  2 +-
 src/views/teams/EditTeam.vue                   |  4 ++--
 23 files changed, 37 insertions(+), 34 deletions(-)

diff --git a/src/components/namespace/namespace-search.vue b/src/components/namespace/namespace-search.vue
index 59474f19..3740fef3 100644
--- a/src/components/namespace/namespace-search.vue
+++ b/src/components/namespace/namespace-search.vue
@@ -38,7 +38,7 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/sharing/userTeam.vue b/src/components/sharing/userTeam.vue
index 77fd2557..b94f0f28 100644
--- a/src/components/sharing/userTeam.vue
+++ b/src/components/sharing/userTeam.vue
@@ -173,7 +173,7 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/edit-task.vue b/src/components/tasks/edit-task.vue
index fadbebea..479f6a6b 100644
--- a/src/components/tasks/edit-task.vue
+++ b/src/components/tasks/edit-task.vue
@@ -199,7 +199,7 @@ export default {
 		PrioritySelect,
 		flatPickr,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/partials/comments.vue b/src/components/tasks/partials/comments.vue
index 1126900c..f25e3060 100644
--- a/src/components/tasks/partials/comments.vue
+++ b/src/components/tasks/partials/comments.vue
@@ -83,7 +83,7 @@ export default {
 	name: 'comments',
 	components: {
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/partials/editAssignees.vue b/src/components/tasks/partials/editAssignees.vue
index 57473fc8..12017254 100644
--- a/src/components/tasks/partials/editAssignees.vue
+++ b/src/components/tasks/partials/editAssignees.vue
@@ -36,7 +36,7 @@
 </template>
 
 <script>
-import {differenceWith} from 'lodash'
+import differenceWith from 'lodash/differenceWith'
 
 import UserModel from '../../../models/user'
 import ListUserService from '../../../services/listUsers'
@@ -50,7 +50,7 @@ export default {
 	components: {
 		User,
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/partials/editLabels.vue b/src/components/tasks/partials/editLabels.vue
index ae640e22..abb11a43 100644
--- a/src/components/tasks/partials/editLabels.vue
+++ b/src/components/tasks/partials/editLabels.vue
@@ -41,7 +41,7 @@
 </template>
 
 <script>
-import {differenceWith} from 'lodash'
+import differenceWith from 'lodash/differenceWith'
 
 import LabelService from '../../../services/label'
 import LabelModel from '../../../models/label'
@@ -76,7 +76,7 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/partials/listSearch.vue b/src/components/tasks/partials/listSearch.vue
index aca5be28..b99aefc1 100644
--- a/src/components/tasks/partials/listSearch.vue
+++ b/src/components/tasks/partials/listSearch.vue
@@ -46,7 +46,7 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/components/tasks/partials/relatedTasks.vue b/src/components/tasks/partials/relatedTasks.vue
index b4985bb7..73772d50 100644
--- a/src/components/tasks/partials/relatedTasks.vue
+++ b/src/components/tasks/partials/relatedTasks.vue
@@ -116,7 +116,7 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/models/abstractModel.js b/src/models/abstractModel.js
index 232d9a4f..2db6c37c 100644
--- a/src/models/abstractModel.js
+++ b/src/models/abstractModel.js
@@ -1,4 +1,6 @@
-import {defaults, isNil, omitBy} from 'lodash'
+import defaults from 'lodash/defaults'
+import isNil from 'lodash/isNil'
+import omitBy from 'lodash/omitBy'
 import {objectToCamelCase} from '@/helpers/case'
 
 export default class AbstractModel {
diff --git a/src/models/teamList.js b/src/models/teamList.js
index 0a191d33..14136667 100644
--- a/src/models/teamList.js
+++ b/src/models/teamList.js
@@ -1,5 +1,5 @@
 import TeamShareBaseModel from './teamShareBase'
-import {merge} from 'lodash'
+import merge from 'lodash/merge'
 
 export default class TeamListModel extends TeamShareBaseModel {
 	defaults() {
diff --git a/src/models/teamMember.js b/src/models/teamMember.js
index ea1e6a75..1f499e56 100644
--- a/src/models/teamMember.js
+++ b/src/models/teamMember.js
@@ -1,5 +1,5 @@
 import UserModel from './user'
-import {merge} from 'lodash'
+import merge from 'lodash/merge'
 
 export default class TeamMemberModel extends UserModel {
 	defaults() {
diff --git a/src/models/teamNamespace.js b/src/models/teamNamespace.js
index 69629af5..0e93fa97 100644
--- a/src/models/teamNamespace.js
+++ b/src/models/teamNamespace.js
@@ -1,5 +1,5 @@
 import TeamShareBaseModel from './teamShareBase'
-import {merge} from 'lodash'
+import merge from 'lodash/merge'
 
 export default class TeamNamespaceModel extends TeamShareBaseModel {
 	defaults() {
diff --git a/src/models/userList.js b/src/models/userList.js
index 9211cfcd..717fe746 100644
--- a/src/models/userList.js
+++ b/src/models/userList.js
@@ -1,5 +1,5 @@
 import UserShareBaseModel from './userShareBase'
-import {merge} from 'lodash'
+import merge from 'lodash/merge'
 
 // This class extends the user share model with a 'rights' parameter which is used in sharing
 export default class UserListModel extends UserShareBaseModel {
diff --git a/src/models/userNamespace.js b/src/models/userNamespace.js
index 0ef7f9df..a8243efc 100644
--- a/src/models/userNamespace.js
+++ b/src/models/userNamespace.js
@@ -1,5 +1,5 @@
 import UserShareBaseModel from './userShareBase'
-import {merge} from 'lodash'
+import merge from 'lodash/merge'
 
 // This class extends the user share model with a 'rights' parameter which is used in sharing
 export default class UserNamespaceModel extends UserShareBaseModel {
diff --git a/src/router/index.js b/src/router/index.js
index 96904222..163e2936 100644
--- a/src/router/index.js
+++ b/src/router/index.js
@@ -31,58 +31,58 @@ import Table from '../views/list/views/Table'
 import CreateSavedFilter from '@/views/filters/CreateSavedFilter'
 
 const PasswordResetComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "user-settings" */'../views/user/PasswordReset'),
+	component: import(/* webpackChunkName: "user-settings" */'../views/user/PasswordReset'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 const GetPasswordResetComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "user-settings" */'../views/user/RequestPasswordReset'),
+	component: import(/* webpackChunkName: "user-settings" */'../views/user/RequestPasswordReset'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 const UserSettingsComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "user-settings" */'../views/user/Settings'),
+	component: import(/* webpackChunkName: "user-settings" */'../views/user/Settings'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 // List Handling
 const NewListComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/list/NewList'),
+	component: import(/* webpackChunkName: "settings" */'../views/list/NewList'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 const EditListComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/list/EditListView'),
+	component: import(/* webpackChunkName: "settings" */'../views/list/EditListView'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 // Namespace Handling
 const NewNamespaceComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/namespaces/NewNamespace'),
+	component: import(/* webpackChunkName: "settings" */'../views/namespaces/NewNamespace'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 const EditNamespaceComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/namespaces/EditNamespace'),
+	component: import(/* webpackChunkName: "settings" */'../views/namespaces/EditNamespace'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 
 const EditTeamComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/teams/EditTeam'),
+	component: import(/* webpackChunkName: "settings" */'../views/teams/EditTeam'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
 })
 const NewTeamComponent = () => ({
-	component: import(/* webpackPrefetch: true *//* webpackChunkName: "settings" */'../views/teams/NewTeam'),
+	component: import(/* webpackChunkName: "settings" */'../views/teams/NewTeam'),
 	loading: LoadingComponent,
 	error: ErrorComponent,
 	timeout: 60000,
diff --git a/src/services/abstractService.js b/src/services/abstractService.js
index 159672e0..f08df1aa 100644
--- a/src/services/abstractService.js
+++ b/src/services/abstractService.js
@@ -1,5 +1,6 @@
 import axios from 'axios'
-import {reduce, replace} from 'lodash'
+import reduce from 'lodash/reduce'
+import replace from 'lodash/replace'
 import {objectToSnakeCase} from '@/helpers/case'
 
 export default class AbstractService {
diff --git a/src/views/filters/CreateSavedFilter.vue b/src/views/filters/CreateSavedFilter.vue
index 9aad96b8..71b3a323 100644
--- a/src/views/filters/CreateSavedFilter.vue
+++ b/src/views/filters/CreateSavedFilter.vue
@@ -93,7 +93,7 @@ export default {
 	components: {
 		Filters,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/filters/EditSavedFilter.vue b/src/views/filters/EditSavedFilter.vue
index 5a709709..967134a2 100644
--- a/src/views/filters/EditSavedFilter.vue
+++ b/src/views/filters/EditSavedFilter.vue
@@ -114,7 +114,7 @@ export default {
 	components: {
 		Filters,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/labels/ListLabels.vue b/src/views/labels/ListLabels.vue
index eb79464d..ecd927a7 100644
--- a/src/views/labels/ListLabels.vue
+++ b/src/views/labels/ListLabels.vue
@@ -108,7 +108,7 @@ export default {
 	components: {
 		ColorPicker,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/list/EditList.vue b/src/views/list/EditList.vue
index fff00d0f..4185da98 100644
--- a/src/views/list/EditList.vue
+++ b/src/views/list/EditList.vue
@@ -198,7 +198,7 @@ export default {
 		LinkSharing,
 		manageSharing,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/namespaces/EditNamespace.vue b/src/views/namespaces/EditNamespace.vue
index 912dc82b..2bb7a0fb 100644
--- a/src/views/namespaces/EditNamespace.vue
+++ b/src/views/namespaces/EditNamespace.vue
@@ -132,7 +132,7 @@ export default {
 		Fancycheckbox,
 		manageSharing,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index 38f952f1..eac343a7 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -414,7 +414,7 @@ export default {
 		Comments,
 		flatPickr,
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
diff --git a/src/views/teams/EditTeam.vue b/src/views/teams/EditTeam.vue
index 870370a0..65300c01 100644
--- a/src/views/teams/EditTeam.vue
+++ b/src/views/teams/EditTeam.vue
@@ -211,13 +211,13 @@ export default {
 	},
 	components: {
 		multiselect: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "multiselect" */ 'vue-multiselect'),
+			component: import(/* webpackChunkName: "multiselect" */ 'vue-multiselect'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,
 		}),
 		editor: () => ({
-			component: import(/* webpackPrefetch: true *//* webpackChunkName: "editor" */ '../../components/input/editor'),
+			component: import(/* webpackChunkName: "editor" */ '../../components/input/editor'),
 			loading: LoadingComponent,
 			error: ErrorComponent,
 			timeout: 60000,