From 579cff647d0cc7dfd830784559c41a21b143614f Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Tue, 12 Jul 2022 11:59:39 +0200
Subject: [PATCH] feat: allow marking a task done from a filter

Resolves https://kolaente.dev/vikunja/frontend/issues/2113
---
 src/components/tasks/partials/singleTaskInList.vue | 6 +++++-
 src/views/list/ListList.vue                        | 8 ++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/components/tasks/partials/singleTaskInList.vue b/src/components/tasks/partials/singleTaskInList.vue
index 0380c480..e153cb3a 100644
--- a/src/components/tasks/partials/singleTaskInList.vue
+++ b/src/components/tasks/partials/singleTaskInList.vue
@@ -1,6 +1,6 @@
 <template>
 	<div :class="{'is-loading': taskService.loading}" class="task loader-container">
-		<fancycheckbox :disabled="isArchived || disabled" @change="markAsDone" v-model="task.done"/>
+		<fancycheckbox :disabled="(isArchived || disabled) && !canMarkAsDone" @change="markAsDone" v-model="task.done"/>
 		<span
 			v-if="showListColor && listColor !== ''"
 			:style="{backgroundColor: listColor }"
@@ -149,6 +149,10 @@ export default defineComponent({
 			type: Boolean,
 			default: true,
 		},
+		canMarkAsDone: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	emits: ['task-updated'],
 	watch: {
diff --git a/src/views/list/ListList.vue b/src/views/list/ListList.vue
index 807a153e..1d60db0f 100644
--- a/src/views/list/ListList.vue
+++ b/src/views/list/ListList.vue
@@ -54,7 +54,7 @@
 		>
 		<card :padding="false" :has-content="false" class="has-overflow">
 			<template
-				v-if="!list.isArchived && canWrite && list.id > 0"
+				v-if="!list.isArchived && canWrite"
 			>
 				<add-task
 					@taskAdded="updateTaskList"
@@ -137,9 +137,9 @@ import { ref, toRef, defineComponent } from 'vue'
 import BaseButton from '@/components/base/BaseButton.vue'
 import ButtonLink from '@/components/misc/ButtonLink.vue'
 import ListWrapper from './ListWrapper.vue'
-import EditTask from '@/components/tasks/edit-task'
-import AddTask from '@/components/tasks/add-task'
-import SingleTaskInList from '@/components/tasks/partials/singleTaskInList'
+import EditTask from '@/components/tasks/edit-task.vue'
+import AddTask from '@/components/tasks/add-task.vue'
+import SingleTaskInList from '@/components/tasks/partials/singleTaskInList.vue'
 import { useTaskList } from '@/composables/taskList'
 import Rights from '../../models/constants/rights.json'
 import FilterPopup from '@/components/list/partials/filter-popup.vue'