From 60f58af41aa6ed8afb8f821d1bf5fc25d99c2d0c Mon Sep 17 00:00:00 2001 From: Dominik Pschenitschni Date: Sun, 20 Feb 2022 11:19:26 +0100 Subject: [PATCH] chore: align wording in task detail view Changes only in task detail view. Probably this should be done everywhere: - some buttons were using the uppercase words consistently, some were not - some were using articles, some were not => I removed them everywhere to shorten the label length - some buttons were refering to the task, some were not. Since we are already in the context of the task (we are not the task detail page) I removed the reference everywhere. --- .../integration/list/list-view-kanban.spec.js | 2 +- cypress/integration/task/task.spec.js | 8 +++---- src/i18n/lang/en.json | 24 +++++++++---------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/cypress/integration/list/list-view-kanban.spec.js b/cypress/integration/list/list-view-kanban.spec.js index 8edd2862..68268304 100644 --- a/cypress/integration/list/list-view-kanban.spec.js +++ b/cypress/integration/list/list-view-kanban.spec.js @@ -176,7 +176,7 @@ describe('List View Kanban', () => { .click() cy.get('.task-view .action-buttons .button', { timeout: 3000 }) - .contains('Move task') + .contains('Move') .click() cy.get('.task-view .content.details .field .multiselect.control .input-wrapper input') .type(`${lists[1].title}{enter}`) diff --git a/cypress/integration/task/task.spec.js b/cypress/integration/task/task.spec.js index 62343c91..29ade1d2 100644 --- a/cypress/integration/task/task.spec.js +++ b/cypress/integration/task/task.spec.js @@ -210,7 +210,7 @@ describe('Task', () => { cy.visit(`/tasks/${tasks[0].id}`) cy.get('.task-view .action-buttons .button') - .contains('Move task') + .contains('Move') .click() cy.get('.task-view .content.details .field .multiselect.control .input-wrapper input') .type(`${lists[1].title}{enter}`) @@ -237,7 +237,7 @@ describe('Task', () => { cy.get('.task-view .action-buttons .button') .should('be.visible') - .contains('Delete task') + .contains('Delete') .click() cy.get('.modal-mask .modal-container .modal-content .header') .should('contain', 'Delete this task') @@ -317,7 +317,7 @@ describe('Task', () => { cy.visit(`/tasks/${tasks[0].id}`) cy.get('.task-view .action-buttons .button') - .contains('Add labels') + .contains('Add Labels') .should('be.visible') .click() cy.get('.task-view .details.labels-list .multiselect input') @@ -344,7 +344,7 @@ describe('Task', () => { cy.visit(`/tasks/${tasks[0].id}`) cy.get('.task-view .action-buttons .button') - .contains('Add labels') + .contains('Add Labels') .click() cy.get('.task-view .details.labels-list .multiselect input') .type(labels[0].title) diff --git a/src/i18n/lang/en.json b/src/i18n/lang/en.json index bd694d51..2ec53cc6 100644 --- a/src/i18n/lang/en.json +++ b/src/i18n/lang/en.json @@ -570,22 +570,22 @@ "text2": "This will also remove all attachments, reminders and relations associated with this task and cannot be undone!" }, "actions": { - "assign": "Assign to a user", - "label": "Add labels", + "assign": "Assign to User", + "label": "Add Labels", "priority": "Set Priority", "dueDate": "Set Due Date", - "startDate": "Set a Start Date", - "endDate": "Set an End Date", + "startDate": "Set Start Date", + "endDate": "Set End Date", "reminders": "Set Reminders", - "repeatAfter": "Set a repeating interval", + "repeatAfter": "Set Repeating Interval", "percentDone": "Set Progress", - "attachments": "Add attachments", - "relatedTasks": "Add task relations", - "moveList": "Move task", - "color": "Set task color", - "delete": "Delete task", - "favorite": "Save as favorite", - "unfavorite": "Remove from favorites" + "attachments": "Add Attachments", + "relatedTasks": "Add Relation", + "moveList": "Move", + "color": "Set Color", + "delete": "Delete", + "favorite": "Add to Favorites", + "unfavorite": "Remove from Favorites" } }, "attributes": {