From 71c8540c74f8448a2fddb0791e28b22c76a6d4b6 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 21 Jul 2022 15:06:17 +0200
Subject: [PATCH] fix: don't allow negative repeat amounts

Partial fix for https://kolaente.dev/vikunja/frontend/issues/2179
---
 src/components/tasks/partials/repeatAfter.vue | 33 +++++++++++++++----
 src/i18n/lang/en.json                         |  3 +-
 2 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/src/components/tasks/partials/repeatAfter.vue b/src/components/tasks/partials/repeatAfter.vue
index fe030017..fc34c077 100644
--- a/src/components/tasks/partials/repeatAfter.vue
+++ b/src/components/tasks/partials/repeatAfter.vue
@@ -1,9 +1,15 @@
 <template>
 	<div class="control repeat-after-input">
 		<div class="buttons has-addons is-centered mt-2">
-			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'days')">{{ $t('task.repeat.everyDay') }}</x-button>
-			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'weeks')">{{ $t('task.repeat.everyWeek') }}</x-button>
-			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'months')">{{ $t('task.repeat.everyMonth') }}</x-button>
+			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'days')">
+				{{ $t('task.repeat.everyDay') }}
+			</x-button>
+			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'weeks')">
+				{{ $t('task.repeat.everyWeek') }}
+			</x-button>
+			<x-button variant="secondary" class="is-small" @click="() => setRepeatAfter(1, 'months')">
+				{{ $t('task.repeat.everyMonth') }}
+			</x-button>
 		</div>
 		<div class="is-flex is-align-items-center mb-2">
 			<label for="repeatMode" class="is-fullwidth">
@@ -14,7 +20,10 @@
 					<select @change="updateData" v-model="task.repeatMode" id="repeatMode">
 						<option :value="repeatModes.REPEAT_MODE_DEFAULT">{{ $t('misc.default') }}</option>
 						<option :value="repeatModes.REPEAT_MODE_MONTH">{{ $t('task.repeat.monthly') }}</option>
-						<option :value="repeatModes.REPEAT_MODE_FROM_CURRENT_DATE">{{ $t('task.repeat.fromCurrentDate') }}</option>
+						<option :value="repeatModes.REPEAT_MODE_FROM_CURRENT_DATE">{{
+								$t('task.repeat.fromCurrentDate')
+							}}
+						</option>
 					</select>
 				</div>
 			</div>
@@ -32,6 +41,7 @@
 						:placeholder="$t('task.repeat.specifyAmount')"
 						v-model="repeatAfter.amount"
 						type="number"
+						min="0"
 					/>
 				</div>
 				<div class="control">
@@ -56,8 +66,10 @@
 
 <script setup lang="ts">
 import {ref, reactive, watch} from 'vue'
-import repeatModes from '@/models/constants/taskRepeatModes'
+import repeatModes from '@/models/constants/taskRepeatModes.json'
 import TaskModel from '@/models/task'
+import {error} from '@/message'
+import {useI18n} from 'vue-i18n'
 
 const props = defineProps({
 	modelValue: {
@@ -70,6 +82,8 @@ const props = defineProps({
 	},
 })
 
+const {t} = useI18n()
+
 const emit = defineEmits(['update:modelValue', 'change'])
 
 const task = ref<TaskModel>()
@@ -93,14 +107,19 @@ function updateData() {
 	if (task.value.repeatMode !== repeatModes.REPEAT_MODE_DEFAULT && repeatAfter.amount === 0) {
 		return
 	}
-	
+
+	if (repeatAfter.amount < 0) {
+		error({message: t('task.repeat.invalidAmount')})
+		return
+	}
+
 	Object.assign(task.value.repeatAfter, repeatAfter)
 	emit('update:modelValue', task.value)
 	emit('change')
 }
 
 function setRepeatAfter(amount: number, type) {
-	Object.assign(repeatAfter, { amount, type})
+	Object.assign(repeatAfter, {amount, type})
 	updateData()
 }
 </script>
diff --git a/src/i18n/lang/en.json b/src/i18n/lang/en.json
index db7258ab..7158efcd 100644
--- a/src/i18n/lang/en.json
+++ b/src/i18n/lang/en.json
@@ -783,7 +783,8 @@
       "days": "Days",
       "weeks": "Weeks",
       "months": "Months",
-      "years": "Years"
+      "years": "Years",
+      "invalidAmount": "Please enter more than 0."
     },
     "quickAddMagic": {
       "hint": "You can use Quick Add Magic",