From c2d5370e4a88fc646dccd3c598c2953b6b40ca82 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Tue, 19 Jul 2022 16:56:09 +0200
Subject: [PATCH] fix: don't use transitions for elements where it is not
 possible

Resolves https://kolaente.dev/vikunja/frontend/issues/2153
---
 src/App.vue                         |  4 +---
 src/components/home/contentAuth.vue | 18 ++++++++----------
 src/components/misc/modal.vue       |  2 +-
 3 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 79d68683..9c48735c 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -10,9 +10,7 @@
 		</no-auth-wrapper>
 		<Notification/>
 
-		<transition name="fade">
-			<keyboard-shortcuts v-if="keyboardShortcutsActive"/>
-		</transition>
+		<keyboard-shortcuts v-if="keyboardShortcutsActive"/>
 	</ready>
 </template>
 
diff --git a/src/components/home/contentAuth.vue b/src/components/home/contentAuth.vue
index e92bc89c..17d22869 100644
--- a/src/components/home/contentAuth.vue
+++ b/src/components/home/contentAuth.vue
@@ -38,16 +38,14 @@
 					</keep-alive>
 				</router-view>
 
-				<transition name="modal">
-					<modal
-						v-if="currentModal"
-						@close="closeModal()"
-						variant="scrolling"
-						class="task-detail-view-modal"
-					>
-						<component :is="currentModal"/>
-					</modal>
-				</transition>
+				<modal
+					v-if="currentModal"
+					@close="closeModal()"
+					variant="scrolling"
+					class="task-detail-view-modal"
+				>
+					<component :is="currentModal"/>
+				</modal>
 
 				<BaseButton
 					class="keyboard-shortcuts-button d-print-none"
diff --git a/src/components/misc/modal.vue b/src/components/misc/modal.vue
index 188c58bf..5095b0a7 100644
--- a/src/components/misc/modal.vue
+++ b/src/components/misc/modal.vue
@@ -1,7 +1,7 @@
 <template>
 	<Teleport to="body">
 		<!-- FIXME: transition should not be included in the modal -->
-		<transition name="modal">
+		<transition :name="transitionName">
 			<section
 				v-if="enabled"
 				class="modal-mask"