From f4b47ec374049ac1b64d1639328caf9d70a7afd4 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Sat, 16 Jan 2021 21:55:43 +0100
Subject: [PATCH] Fix task detail view spacings

---
 src/components/tasks/partials/comments.vue | 6 +++---
 src/styles/components/task.scss            | 5 -----
 src/styles/components/taskRelations.scss   | 4 ----
 src/views/tasks/TaskDetailView.vue         | 8 ++++----
 4 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/src/components/tasks/partials/comments.vue b/src/components/tasks/partials/comments.vue
index d35fd87e..34366e0b 100644
--- a/src/components/tasks/partials/comments.vue
+++ b/src/components/tasks/partials/comments.vue
@@ -1,11 +1,11 @@
 <template>
-	<div :class="{'has-top-border': canWrite || comments.length > 0}" class="content details">
-		<h1 v-if="canWrite || comments.length > 0">
+	<div class="content details">
+		<h3 v-if="canWrite || comments.length > 0">
 			<span class="icon is-grey">
 				<icon :icon="['far', 'comments']"/>
 			</span>
 			Comments
-		</h1>
+		</h3>
 		<div class="comments">
 			<span class="is-inline-flex is-align-items-center" v-if="taskCommentService.loading && saving === null && !creating">
 				<span class="loader is-inline-block mr-2"></span>
diff --git a/src/styles/components/task.scss b/src/styles/components/task.scss
index f9d7add0..ab960007 100644
--- a/src/styles/components/task.scss
+++ b/src/styles/components/task.scss
@@ -12,11 +12,6 @@
     }
   }
 
-  .has-top-border {
-    border-top: 1px solid lighten($grey, 35%);
-    padding-top: .5em;
-  }
-
   h3 .button {
     vertical-align: middle;
   }
diff --git a/src/styles/components/taskRelations.scss b/src/styles/components/taskRelations.scss
index 1bb0804a..60f50587 100644
--- a/src/styles/components/taskRelations.scss
+++ b/src/styles/components/taskRelations.scss
@@ -1,8 +1,6 @@
 $remove-icon-width: 24px;
 
 .task-relations {
-  padding-bottom: 1em;
-
   &.is-narrow .columns {
     display: block;
 
@@ -12,8 +10,6 @@ $remove-icon-width: 24px;
   }
 
   .related-tasks {
-    margin-bottom: .75em;
-
     .title {
       font-size: 1em;
       margin: 0;
diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index d41fed61..9cf7be17 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -181,7 +181,7 @@
 					</div>
 
 					<!-- Description -->
-					<div :class="{ 'has-top-border': activeFields.labels }" class="details content description">
+					<div class="details content description">
 						<description
 							v-model="task"
 							:can-write="canWrite"
@@ -190,7 +190,7 @@
 					</div>
 
 					<!-- Attachments -->
-					<div class="content attachments has-top-border" v-if="activeFields.attachments">
+					<div class="content attachments" v-if="activeFields.attachments">
 						<attachments
 							:edit-enabled="canWrite"
 							:task-id="taskId"
@@ -199,7 +199,7 @@
 					</div>
 
 					<!-- Related Tasks -->
-					<div class="content details has-top-border" v-if="activeFields.relatedTasks">
+					<div class="content details mb-0" v-if="activeFields.relatedTasks">
 						<h3>
 							<span class="icon is-grey">
 								<icon icon="tasks"/>
@@ -217,7 +217,7 @@
 					</div>
 
 					<!-- Move Task -->
-					<div class="content details has-top-border" v-if="activeFields.moveList">
+					<div class="content details" v-if="activeFields.moveList">
 						<h3>
 							<span class="icon is-grey">
 								<icon icon="list"/>