QS: Fixx rubocop for specs #25

New issue

Open

opened 2022-09-13 15:39:33 +02:00 by tk · 0 comments

tk commented

2022-09-13 15:39:33 +02:00

Owner

--- workspace/foodsoft ‹master› » rubocop                       

Offenses:

spec/api/v1/user/financial_transactions_spec.rb:24:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200.
      expect(response.status).to eq 200
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/api/v1/user/group_order_articles_spec.rb:26:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200.
      expect(response.status).to eq 200
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/bank_account_information_importer_spec.rb:7:15: C: [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of heredoc.
    content = <<-JSON
              ^^^^^^^

Originally posted by @tk in #7 (comment)

``` --- workspace/foodsoft ‹master› » rubocop Offenses: spec/api/v1/user/financial_transactions_spec.rb:24:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200. expect(response.status).to eq 200 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/api/v1/user/group_order_articles_spec.rb:26:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200. expect(response.status).to eq 200 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/bank_account_information_importer_spec.rb:7:15: C: [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of heredoc. content = <<-JSON ^^^^^^^ ``` _Originally posted by @tk in https://git.local-it.org/Foodsoft/foodsoft/issues/7#issuecomment-116_