QS / Rubocop, brakeman, rails_best_practices prüfen u ggf. verbessern #7

New issue

Open

opened 2022-09-08 12:14:29 +02:00 by tk · 3 comments

tk commented

2022-09-08 12:14:29 +02:00

Owner

No description provided.

tk added this to the Tests milestone 2022-09-08 12:14:29 +02:00

philipp was assigned by tk

2022-09-08 12:14:29 +02:00

fgu was assigned by tk

2022-09-08 12:14:29 +02:00

fgu changed title from ~~QS / Rubocop, barakeman, rails_best_practices prüfen u ggf. verbessern~~ to QS / Rubocop, brakeman, rails_best_practices prüfen u ggf. verbessern

2022-09-08 15:24:12 +02:00

tk commented

2022-09-13 15:27:39 +02:00

Author

Owner

--- workspace/foodsoft ‹7_qs* M› » rails_best_practices
Source Code: |===================================================================================================================================|
/home/i/workspace/foodsoft/db/schema.rb:85 - always add db index (bank_accounts => [bank_gateway_id])
/home/i/workspace/foodsoft/db/schema.rb:95 - always add db index (bank_gateways => [unattended_user_id])
/home/i/workspace/foodsoft/db/schema.rb:102 - always add db index (bank_transactions => [bank_account_id])
/home/i/workspace/foodsoft/db/schema.rb:136 - always add db index (financial_transaction_types => [financial_transaction_class_id])
/home/i/workspace/foodsoft/db/schema.rb:136 - always add db index (financial_transaction_types => [bank_account_id])
/home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [user_id])
/home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [financial_transaction_type_id])
/home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [financial_link_id])
/home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [group_order_id])
/home/i/workspace/foodsoft/db/schema.rb:217 - always add db index (invites => [group_id])
/home/i/workspace/foodsoft/db/schema.rb:217 - always add db index (invites => [user_id])
/home/i/workspace/foodsoft/db/schema.rb:226 - always add db index (invoices => [financial_link_id])
/home/i/workspace/foodsoft/db/schema.rb:276 - always add db index (messages => [sender_id])
/home/i/workspace/foodsoft/db/schema.rb:276 - always add db index (messages => [group_id])
/home/i/workspace/foodsoft/db/schema.rb:326 - always add db index (order_articles => [article_price_id])
/home/i/workspace/foodsoft/db/schema.rb:340 - always add db index (order_comments => [user_id])
/home/i/workspace/foodsoft/db/schema.rb:348 - always add db index (orders => [supplier_id])
/home/i/workspace/foodsoft/db/schema.rb:348 - always add db index (orders => [invoice_id])
/home/i/workspace/foodsoft/db/schema.rb:443 - always add db index (printer_jobs => [order_id])
/home/i/workspace/foodsoft/db/schema.rb:462 - always add db index (stock_changes => [order_id])
/home/i/workspace/foodsoft/db/schema.rb:472 - always add db index (stock_events => [invoice_id])
/home/i/workspace/foodsoft/db/schema.rb:482 - always add db index (supplier_categories => [financial_transaction_class_id])
/home/i/workspace/foodsoft/db/schema.rb:482 - always add db index (supplier_categories => [bank_account_id])
/home/i/workspace/foodsoft/db/schema.rb:489 - always add db index (suppliers => [supplier_category_id])
/home/i/workspace/foodsoft/db/schema.rb:511 - always add db index (tasks => [periodic_task_group_id])
/home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:26 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:31 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:38 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:46 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/006_create_articles.rb:23 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:49 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/001_create_users.rb:24 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/001_create_users.rb:30 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/20130718183101_migrate_user_settings.rb:40 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:24 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/20130622095040_move_weekly_tasks.rb:4 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:30 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:16 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:38 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:58 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:78 - isolate seed data
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:101 - isolate seed data
/home/i/workspace/foodsoft/app/models/group_order.rb:48 - law of demeter
/home/i/workspace/foodsoft/app/models/group_order_article.rb:125 - law of demeter
/home/i/workspace/foodsoft/app/models/group_order_article.rb:127 - law of demeter
/home/i/workspace/foodsoft/app/models/group_order_article.rb:128 - law of demeter
/home/i/workspace/foodsoft/app/models/group_order_article.rb:131 - law of demeter
/home/i/workspace/foodsoft/app/mailers/mailer.rb:84 - law of demeter
/home/i/workspace/foodsoft/app/mailers/mailer.rb:87 - law of demeter
/home/i/workspace/foodsoft/app/helpers/orders_helper.rb:87 - law of demeter
/home/i/workspace/foodsoft/app/helpers/orders_helper.rb:87 - law of demeter
/home/i/workspace/foodsoft/app/helpers/orders_helper.rb:90 - law of demeter
/home/i/workspace/foodsoft/app/helpers/orders_helper.rb:126 - law of demeter
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:100 - law of demeter
/home/i/workspace/foodsoft/plugins/messages/app/mail_receivers/messages_mail_receiver.rb:50 - law of demeter
/home/i/workspace/foodsoft/plugins/messages/app/views/messages_mailer/foodsoft_message.text.haml:5 - law of demeter
/home/i/workspace/foodsoft/plugins/messages/app/views/messages/show.haml:14 - law of demeter
/home/i/workspace/foodsoft/plugins/messages/app/views/messages/show.haml:18 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:3 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:4 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:7 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:9 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:12 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:13 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:14 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:22 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/show.html.haml:1 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/documents/multiple_orders_by_articles.rb:43 - law of demeter
/home/i/workspace/foodsoft/plugins/current_orders/app/documents/multiple_orders_by_articles.rb:44 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:41 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:98 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:101 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:103 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:136 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:148 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - law of demeter
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:152 - law of demeter
/home/i/workspace/foodsoft/app/views/admin/users/show.html.haml:40 - law of demeter
/home/i/workspace/foodsoft/app/views/login/accept_invitation.html.haml:6 - law of demeter
/home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:5 - law of demeter
/home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:8 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:13 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:18 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:18 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/add_article.js.erb:2 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:7 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:7 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:8 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:8 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:9 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:10 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:11 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_articles.html.haml:28 - law of demeter
/home/i/workspace/foodsoft/app/views/orders/_articles.html.haml:29 - law of demeter
/home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:28 - law of demeter
/home/i/workspace/foodsoft/app/views/articles/_article.html.haml:5 - law of demeter
/home/i/workspace/foodsoft/app/views/shared/articles_by/_article_single.html.haml:6 - law of demeter
/home/i/workspace/foodsoft/app/views/shared/articles_by/_article_single.html.haml:8 - law of demeter
/home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:1 - law of demeter
/home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:1 - law of demeter
/home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:6 - law of demeter
/home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:6 - law of demeter
/home/i/workspace/foodsoft/app/views/deliveries/show.html.haml:5 - law of demeter
/home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:9 - law of demeter
/home/i/workspace/foodsoft/app/views/invites/new.html.haml:1 - law of demeter
/home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:6 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/index.html.haml:20 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:16 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/invoices/show.html.haml:15 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:28 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:2 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:3 - law of demeter
/home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:9 - law of demeter
/home/i/workspace/foodsoft/app/documents/order_matrix.rb:79 - law of demeter
/home/i/workspace/foodsoft/app/documents/order_by_articles.rb:30 - law of demeter
/home/i/workspace/foodsoft/app/documents/order_by_articles.rb:30 - law of demeter
/home/i/workspace/foodsoft/app/controllers/home_controller.rb:72 - law of demeter
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:29 - law of demeter
/home/i/workspace/foodsoft/lib/order_pdf.rb:54 - law of demeter
/home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:17 - move code into controller
/home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:17 - move code into controller
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:9 - move code into model (order_article use_count > 2)
/home/i/workspace/foodsoft/app/views/kaminari/_paginator.html.haml:16 - move code into model (page use_count > 2)
/home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:4 - move code into model (order_article use_count > 2)
/home/i/workspace/foodsoft/plugins/messages/app/controllers/admin/messagegroups_controller.rb:4 - move model logic into model (@messagegroups use_count > 4)
/home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (@message use_count > 4)
/home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (original_message use_count > 4)
/home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (I18n use_count > 4)
/home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:60 - move model logic into model (@poll use_count > 4)
/home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:26 - move model logic into model (@document use_count > 4)
/home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:67 - move model logic into model (@document use_count > 4)
/home/i/workspace/foodsoft/plugins/discourse/app/controllers/discourse_login_controller.rb:17 - move model logic into model (user use_count > 4)
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:23 - move model logic into model (@page use_count > 4)
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:23 - move model logic into model (page use_count > 4)
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:77 - move model logic into model (@page use_count > 4)
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:107 - move model logic into model (@pages use_count > 4)
/home/i/workspace/foodsoft/plugins/links/app/controllers/links_controller.rb:4 - move model logic into model (link use_count > 4)
/home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/articles_controller.rb:27 - move model logic into model (@order_articles use_count > 4)
/home/i/workspace/foodsoft/app/controllers/home_controller.rb:35 - move model logic into model (@ordergroup use_count > 4)
/home/i/workspace/foodsoft/app/controllers/admin/ordergroups_controller.rb:4 - move model logic into model (@ordergroups use_count > 4)
/home/i/workspace/foodsoft/app/controllers/admin/mail_delivery_status_controller.rb:4 - move model logic into model (@maildeliverystatus use_count > 4)
/home/i/workspace/foodsoft/app/controllers/admin/workgroups_controller.rb:4 - move model logic into model (@workgroups use_count > 4)
/home/i/workspace/foodsoft/app/controllers/admin/users_controller.rb:4 - move model logic into model (@users use_count > 4)
/home/i/workspace/foodsoft/app/controllers/concerns/auth.rb:48 - move model logic into model (current_user use_count > 4)
/home/i/workspace/foodsoft/app/controllers/concerns/collection_scope.rb:27 - move model logic into model (s use_count > 4)
/home/i/workspace/foodsoft/app/controllers/concerns/auth_api.rb:48 - move model logic into model (current_user use_count > 4)
/home/i/workspace/foodsoft/app/controllers/foodcoop/ordergroups_controller.rb:2 - move model logic into model (@ordergroups use_count > 4)
/home/i/workspace/foodsoft/app/controllers/foodcoop/users_controller.rb:2 - move model logic into model (@users use_count > 4)
/home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:38 - move model logic into model (@order_article use_count > 4)
/home/i/workspace/foodsoft/app/controllers/login_controller.rb:29 - move model logic into model (@user use_count > 4)
/home/i/workspace/foodsoft/app/controllers/login_controller.rb:42 - move model logic into model (@invite use_count > 4)
/home/i/workspace/foodsoft/app/controllers/login_controller.rb:42 - move model logic into model (@user use_count > 4)
/home/i/workspace/foodsoft/app/controllers/orders_controller.rb:33 - move model logic into model (format use_count > 4)
/home/i/workspace/foodsoft/app/controllers/orders_controller.rb:75 - move model logic into model (@order use_count > 4)
/home/i/workspace/foodsoft/app/controllers/orders_controller.rb:163 - move model logic into model (oa use_count > 4)
/home/i/workspace/foodsoft/app/controllers/group_order_articles_controller.rb:12 - move model logic into model (@group_order_article use_count > 4)
/home/i/workspace/foodsoft/app/controllers/articles_controller.rb:4 - move model logic into model (@articles use_count > 4)
/home/i/workspace/foodsoft/app/controllers/articles_controller.rb:117 - move model logic into model (I18n use_count > 4)
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:18 - move model logic into model (@task use_count > 4)
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:43 - move model logic into model (@task use_count > 4)
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:66 - move model logic into model (task use_count > 4)
/home/i/workspace/foodsoft/app/controllers/application_controller.rb:87 - move model logic into model (::I18n use_count > 4)
/home/i/workspace/foodsoft/app/controllers/api/v1/order_articles_controller.rb:24 - move model logic into model (scope use_count > 4)
/home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:34 - move model logic into model (goa use_count > 4)
/home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:46 - move model logic into model (goa use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/ordergroups_controller.rb:2 - move model logic into model (@ordergroups use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/balancing_controller.rb:6 - move model logic into model (@articles use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/bank_accounts_controller.rb:15 - move model logic into model (importer use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:7 - move model logic into model (@financial_transactions_all use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:48 - move model logic into model (@financial_transaction use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:4 - move model logic into model (ft use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:4 - move model logic into model (invoice use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:73 - move model logic into model (financial_transaction use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:26 - move model logic into model (@invoice use_count > 4)
/home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:47 - move model logic into model (@invoice use_count > 4)
/home/i/workspace/foodsoft/app/views/group_orders/_switch_order.html.haml:9 - not use time_ago_in_words
/home/i/workspace/foodsoft/plugins/wiki/config/routes.rb:3 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:39 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:71 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:102 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:114 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:126 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:150 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:175 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/config/routes.rb:225 - overuse route customizations (customize_count > 3)
/home/i/workspace/foodsoft/app/helpers/foodcoop_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/home_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/stock_takings_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/order_comments_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/users_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/sessions_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/finance/ordergroups_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/app/helpers/article_categories_helper.rb:1 - remove empty helpers
/home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/ordergroups_controller.rb:42 - remove unused methods (CurrentOrders::OrdergroupsController#articles_for_adding)
/home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/articles_controller.rb:41 - remove unused methods (CurrentOrders::ArticlesController#ordergroups_for_adding)
/home/i/workspace/foodsoft/app/controllers/home_controller.rb:15 - remove unused methods (HomeController#reference_calculator)
/home/i/workspace/foodsoft/app/controllers/home_controller.rb:25 - remove unused methods (HomeController#update_profile)
/home/i/workspace/foodsoft/app/controllers/admin/mail_delivery_status_controller.rb:16 - remove unused methods (Admin::MailDeliveryStatusController#destroy_all)
/home/i/workspace/foodsoft/app/controllers/stockit_controller.rb:84 - remove unused methods (StockitController#articles_search)
/home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:63 - remove unused methods (Api::V1::BaseController#doorkeeper_unauthorized_render_options)
/home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:67 - remove unused methods (Api::V1::BaseController#doorkeeper_forbidden_render_options)
/home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:77 - remove unused methods (Api::V1::BaseController#show_user)
/home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_types_controller.rb:14 - remove unused methods (Api::V1::FinancialTransactionTypesController#max_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_types_controller.rb:18 - remove unused methods (Api::V1::FinancialTransactionTypesController#default_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/article_categories_controller.rb:14 - remove unused methods (Api::V1::ArticleCategoriesController#max_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/article_categories_controller.rb:18 - remove unused methods (Api::V1::ArticleCategoriesController#default_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_classes_controller.rb:14 - remove unused methods (Api::V1::FinancialTransactionClassesController#max_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_classes_controller.rb:18 - remove unused methods (Api::V1::FinancialTransactionClassesController#default_per_page)
/home/i/workspace/foodsoft/app/controllers/api/v1/financial_transactions_controller.rb:20 - remove unused methods (Api::V1::FinancialTransactionsController#ransack_auth_object)
/home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:60 - remove unused methods (Api::V1::User::GroupOrderArticlesController#max_per_page)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:55 - remove unused methods (Finance::FinancialLinksController#add_bank_transaction)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:61 - remove unused methods (Finance::FinancialLinksController#remove_bank_transaction)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:85 - remove unused methods (Finance::FinancialLinksController#add_financial_transaction)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:91 - remove unused methods (Finance::FinancialLinksController#remove_financial_transaction)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:101 - remove unused methods (Finance::FinancialLinksController#add_invoice)
/home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:107 - remove unused methods (Finance::FinancialLinksController#remove_invoice)
/home/i/workspace/foodsoft/app/helpers/orders_helper.rb:19 - remove unused methods (OrdersHelper#options_for_suppliers_to_select)
/home/i/workspace/foodsoft/app/helpers/application_helper.rb:118 - remove unused methods (ApplicationHelper#weekday)
/home/i/workspace/foodsoft/app/helpers/application_helper.rb:133 - remove unused methods (ApplicationHelper#tab_is_active?)
/home/i/workspace/foodsoft/app/helpers/application_helper.rb:151 - remove unused methods (ApplicationHelper#remote_link_to)
/home/i/workspace/foodsoft/plugins/messages/app/models/message.rb:128 - remove unused methods (Message#can_toggle_private?)
/home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:21 - remove unused methods (Page#no_parent)
/home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:31 - remove unused methods (Page#dashboard)
/home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:35 - remove unused methods (Page#public_front_page)
/home/i/workspace/foodsoft/app/models/bank_gateway.rb:5 - remove unused methods (BankGateway#with_unattended_support)
/home/i/workspace/foodsoft/app/models/financial_transaction.rb:35 - remove unused methods (FinancialTransaction#ransackable_associations)
/home/i/workspace/foodsoft/app/models/group_order.rb:28 - remove unused methods (GroupOrder#ransackable_associations)
/home/i/workspace/foodsoft/app/models/user.rb:200 - remove unused methods (User#member_of?)
/home/i/workspace/foodsoft/app/models/user.rb:205 - remove unused methods (User#member_of_groups)
/home/i/workspace/foodsoft/app/models/order_article.rb:27 - remove unused methods (OrderArticle#ransackable_associations)
/home/i/workspace/foodsoft/app/models/task.rb:112 - remove unused methods (Task#user_list)
/home/i/workspace/foodsoft/app/models/group.rb:23 - remove unused methods (Group#non_members)
/home/i/workspace/foodsoft/app/models/bank_account.rb:29 - remove unused methods (BankAccount#last_transaction_date)
/home/i/workspace/foodsoft/app/models/supplier.rb:29 - remove unused methods (Supplier#ransackable_associations)
/home/i/workspace/foodsoft/app/models/group_order_article.rb:24 - remove unused methods (GroupOrderArticle#ransackable_associations)
/home/i/workspace/foodsoft/app/models/article.rb:85 - remove unused methods (Article#ransackable_associations)
/home/i/workspace/foodsoft/app/models/stock_article.rb:16 - remove unused methods (StockArticle#ransackable_associations)
/home/i/workspace/foodsoft/app/models/ordergroup.rb:29 - remove unused methods (Ordergroup#non_members)
/home/i/workspace/foodsoft/app/models/order.rb:56 - remove unused methods (Order#ransackable_associations)
/home/i/workspace/foodsoft/app/models/order.rb:181 - remove unused methods (Order#articles_sort_by_category)
/home/i/workspace/foodsoft/app/models/article_category.rb:28 - remove unused methods (ArticleCategory#ransackable_associations)
/home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:26 - replace complex creation with factory method (@document attribute_assignment_count > 2)
/home/i/workspace/foodsoft/plugins/discourse/app/controllers/discourse_login_controller.rb:17 - replace complex creation with factory method (user attribute_assignment_count > 2)
/home/i/workspace/foodsoft/app/controllers/login_controller.rb:29 - replace complex creation with factory method (@user attribute_assignment_count > 2)
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:18 - replace complex creation with factory method (@task attribute_assignment_count > 2)
/home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_messagegroups.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_messagegroups.html.haml:11 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_polls.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_polls.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:42 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:48 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:70 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:71 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_move.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_move.html.haml:10 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:10 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_title_list.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:11 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:17 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_links.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:10 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:20 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:51 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:18 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:18 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:36 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:43 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:21 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_articles.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article.html.haml:11 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_orders.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:9 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:28 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:30 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:32 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:34 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:36 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:38 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:41 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:43 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:44 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:47 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:48 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:50 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:53 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:57 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:67 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:76 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:81 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:90 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:97 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:99 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:102 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:105 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:106 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:108 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:112 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:114 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:114 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:121 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:123 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:124 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:126 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:126 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:134 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:142 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:142 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:145 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:145 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:161 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:164 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:166 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:168 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:170 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:175 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:179 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:179 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:180 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/mail_delivery_status/_maildeliverystatus.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/mail_delivery_status/_maildeliverystatus.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/bank_gateways/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/bank_gateways/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/ordergroups/_ordergroups.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/supplier_categories/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/supplier_categories/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/finances/_transaction_types.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/finances/_bank_gateways.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/finances/_supplier_categories.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/finances/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/finances/_bank_accounts.html.haml:9 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/financial_transaction_types/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/financial_transaction_types/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/financial_transaction_classes/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/financial_transaction_classes/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/bank_accounts/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/bank_accounts/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/workgroups/_workgroups.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/workgroups/_workgroups.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/workgroups/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/workgroups/_form.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/users/_users.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/users/_users.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/users/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/users/_form.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tab_messages.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tab_messages.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:10 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:11 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:9 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:17 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:17 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:24 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/home/_start_nav.haml:30 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/_ordergroups.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:20 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:21 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:18 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:21 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:24 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_orders.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_orders.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_show_js.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_show_js.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:71 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:103 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:22 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:29 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:37 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:41 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:47 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:64 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:64 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:70 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:25 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:18 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:20 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:23 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:27 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:22 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:23 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:34 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:36 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:29 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:32 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_edit_all_table.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_article.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_article.html.haml:17 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_article.html.haml:19 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/articles/_form.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/article_categories/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/stock_takings/_stock_takings.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/stock_takings/_stock_takings.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/shared/_group.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/shared/_group.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:24 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:41 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:63 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:72 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:95 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:95 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:112 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:117 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:138 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:10 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:12 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:29 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions_search.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:18 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_new_financial_transaction.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_new_financial_transaction.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_financial_transaction.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_financial_transaction.html.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_bank_transaction.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/financial_links/_index_bank_transaction.html.haml:15 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:6 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:25 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:2 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:8 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:13 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:16 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:17 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_invoice.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_invoice.html.haml:26 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:14 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_transport.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_transport.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_note.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_note.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:39 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:41 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:46 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:47 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:49 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:55 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:58 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:61 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:61 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:62 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:1 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:4 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:5 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:7 - replace instance variable with local variable
/home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:24 - replace instance variable with local variable
/home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:38 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:23 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:43 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:17 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:66 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:72 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:83 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:91 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:8 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:15 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:17 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:30 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:32 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/admin/financial_transaction_types_controller.rb:40 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/admin/supplier_categories_controller.rb:39 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/admin/bank_accounts_controller.rb:39 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/admin/bank_gateways_controller.rb:39 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/admin/financial_transaction_classes_controller.rb:39 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/suppliers_controller.rb:34 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/suppliers_controller.rb:48 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/deliveries_controller.rb:25 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/deliveries_controller.rb:40 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/foodcoop/workgroups_controller.rb:18 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:22 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:34 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/feedback_controller.rb:10 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/orders_controller.rb:84 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/orders_controller.rb:101 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:29 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:62 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/invites_controller.rb:23 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/finance/base_controller.rb:9 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:59 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:122 - simplify render in controllers
/home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:61 - simplify render in controllers
/home/i/workspace/foodsoft/plugins/messages/app/views/messagegroups/index.html.haml:5 - simplify render in views
/home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:72 - simplify render in views
/home/i/workspace/foodsoft/plugins/documents/app/views/documents/index.html.haml:21 - simplify render in views
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:8 - simplify render in views
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:12 - simplify render in views
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/show.html.haml:47 - simplify render in views
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_title_list.html.haml:8 - simplify render in views
/home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_page_list_item.html.haml:8 - simplify render in views
/home/i/workspace/foodsoft/app/views/group_orders/index.html.haml:27 - simplify render in views
/home/i/workspace/foodsoft/app/views/group_orders/index.html.haml:37 - simplify render in views
/home/i/workspace/foodsoft/app/views/group_orders/archive.html.haml:8 - simplify render in views
/home/i/workspace/foodsoft/app/views/group_orders/archive.html.haml:13 - simplify render in views
/home/i/workspace/foodsoft/app/views/home/index.html.haml:4 - simplify render in views
/home/i/workspace/foodsoft/app/views/home/index.html.haml:41 - simplify render in views
/home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/index.html.haml:13 - simplify render in views
/home/i/workspace/foodsoft/app/views/foodcoop/workgroups/index.html.haml:5 - simplify render in views
/home/i/workspace/foodsoft/app/views/foodcoop/users/index.html.haml:18 - simplify render in views
/home/i/workspace/foodsoft/app/views/orders/index.html.haml:70 - simplify render in views
/home/i/workspace/foodsoft/app/views/orders/edit.html.haml:3 - simplify render in views
/home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:104 - simplify render in views
/home/i/workspace/foodsoft/app/views/orders/_form.html.haml:65 - simplify render in views
/home/i/workspace/foodsoft/app/views/stockit/index.html.haml:71 - simplify render in views
/home/i/workspace/foodsoft/app/views/stockit/show.html.haml:19 - simplify render in views
/home/i/workspace/foodsoft/app/views/stock_takings/new.html.haml:28 - simplify render in views
/home/i/workspace/foodsoft/app/views/deliveries/edit.html.haml:3 - simplify render in views
/home/i/workspace/foodsoft/app/views/deliveries/_stock_change.html.haml:3 - simplify render in views
/home/i/workspace/foodsoft/app/views/deliveries/_stock_change.html.haml:6 - simplify render in views
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:118 - simplify render in views
/home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:131 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/financial_transactions/new_collection.html.haml:67 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/ordergroups/index.html.haml:17 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/invoices/edit.html.haml:2 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/invoices/new.html.haml:2 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:34 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:50 - simplify render in views
/home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:56 - simplify render in views
/home/i/workspace/foodsoft/app/controllers/articles_controller.rb:226 - use model association (for @article)
/home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:43 - use model association (for @task)
/home/i/workspace/foodsoft/app/helpers/application_helper.rb:216 - use query attribute (user.nick?)
/home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:54 - use query attribute (article.order_number?)
/home/i/workspace/foodsoft/db/migrate/20130622095040_move_weekly_tasks.rb:39 - use query attribute (task.due_date?)
/home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:30 - use query attribute (@order.note?)
/home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:15 - use query attribute (task.due_date?)
/home/i/workspace/foodsoft/app/views/tasks/show.haml:12 - use query attribute (@task.description?)
/home/i/workspace/foodsoft/app/views/tasks/show.haml:15 - use query attribute (@task.due_date?)
/home/i/workspace/foodsoft/app/views/orders/index.html.haml:34 - use query attribute (order.pickup?)
/home/i/workspace/foodsoft/app/views/orders/index.html.haml:35 - use query attribute (order.ends?)
/home/i/workspace/foodsoft/app/views/orders/index.html.haml:55 - use query attribute (order.pickup?)
/home/i/workspace/foodsoft/app/views/suppliers/show.html.haml:87 - use query attribute (order.ends?)
/home/i/workspace/foodsoft/app/views/shared/_task_list.haml:14 - use query attribute (task.due_date?)
/home/i/workspace/foodsoft/app/views/shared/_open_orders.html.haml:21 - use query attribute (order.pickup?)
/home/i/workspace/foodsoft/app/views/shared/_open_orders.html.haml:22 - use query attribute (order.ends?)
/home/i/workspace/foodsoft/app/views/finance/bank_transactions/show.html.haml:36 - use query attribute (@bank_transaction.receipt?)
/home/i/workspace/foodsoft/app/views/finance/invoices/unpaid.html.haml:29 - use query attribute (supplier.iban?)
/home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:17 - use query attribute (order.ends?)
/home/i/workspace/foodsoft/app/views/finance/balancing/new.html.haml:40 - use query attribute (@order.note?)
/home/i/workspace/foodsoft/lib/order_txt.rb:12 - use query attribute (supplier.customer_number?)
/home/i/workspace/foodsoft/db/migrate/20090317175355_add_profit_to_orders.rb:5 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:27 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:40 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:47 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:118 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:123 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:159 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/022_add_required_user_for_task.rb:6 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/022_add_required_user_for_task.rb:7 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:26 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/005_create_financial_transactions.rb:15 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090325175756_create_pages.foodsoft_wiki_engine.rb:17 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090325175756_create_pages.foodsoft_wiki_engine.rb:22 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/013_add_messaging.rb:18 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/013_add_messaging.rb:23 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/006_create_articles.rb:21 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/007_create_article_prices.rb:17 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:17 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:48 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:9 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:24 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/20090731132547_add_stats_to_groups.rb:5 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:6 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:30 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:8 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:16 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:38 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:53 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:78 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:99 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:108 - use say with time in migrations
/home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:112 - use say with time in migrations
/home/i/workspace/foodsoft/plugins/wiki/db/migrate/20090325175756_create_pages.rb:16 - use say with time in migrations
/home/i/workspace/foodsoft/plugins/wiki/db/migrate/20090325175756_create_pages.rb:21 - use say with time in migrations
/home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:57 - use scope access
/home/i/workspace/foodsoft/app/views/kaminari/_paginator.html.haml:15 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/foodcoop/workgroups/index.html.haml:6 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:6 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/orders/add_article.js.erb:7 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_create.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/stockit/index.html.haml:6 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/stockit/show.html.haml:20 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/stockit/index_on_stock_article_create.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/stockit/index_on_stock_article_update.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/deliveries/add_stock_change.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/deliveries/form_on_stock_article_update.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/deliveries/form_on_stock_article_create.js.erb:4 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/index.html.haml:51 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/balancing/new_on_order_article_update.js.erb:7 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/balancing/new.html.haml:14 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/balancing/new_on_order_article_create.js.erb:5 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/balancing/_order_article_result.html.haml:3 - remove trailing whitespace
/home/i/workspace/foodsoft/app/views/finance/balancing/_summary.haml:26 - remove trailing whitespace

Please go to https://rails-bestpractices.com to see more useful Rails Best Practices.

Found 701 warnings.

``` --- workspace/foodsoft ‹7_qs* M› » rails_best_practices Source Code: |===================================================================================================================================| /home/i/workspace/foodsoft/db/schema.rb:85 - always add db index (bank_accounts => [bank_gateway_id]) /home/i/workspace/foodsoft/db/schema.rb:95 - always add db index (bank_gateways => [unattended_user_id]) /home/i/workspace/foodsoft/db/schema.rb:102 - always add db index (bank_transactions => [bank_account_id]) /home/i/workspace/foodsoft/db/schema.rb:136 - always add db index (financial_transaction_types => [financial_transaction_class_id]) /home/i/workspace/foodsoft/db/schema.rb:136 - always add db index (financial_transaction_types => [bank_account_id]) /home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [user_id]) /home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [financial_transaction_type_id]) /home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [financial_link_id]) /home/i/workspace/foodsoft/db/schema.rb:144 - always add db index (financial_transactions => [group_order_id]) /home/i/workspace/foodsoft/db/schema.rb:217 - always add db index (invites => [group_id]) /home/i/workspace/foodsoft/db/schema.rb:217 - always add db index (invites => [user_id]) /home/i/workspace/foodsoft/db/schema.rb:226 - always add db index (invoices => [financial_link_id]) /home/i/workspace/foodsoft/db/schema.rb:276 - always add db index (messages => [sender_id]) /home/i/workspace/foodsoft/db/schema.rb:276 - always add db index (messages => [group_id]) /home/i/workspace/foodsoft/db/schema.rb:326 - always add db index (order_articles => [article_price_id]) /home/i/workspace/foodsoft/db/schema.rb:340 - always add db index (order_comments => [user_id]) /home/i/workspace/foodsoft/db/schema.rb:348 - always add db index (orders => [supplier_id]) /home/i/workspace/foodsoft/db/schema.rb:348 - always add db index (orders => [invoice_id]) /home/i/workspace/foodsoft/db/schema.rb:443 - always add db index (printer_jobs => [order_id]) /home/i/workspace/foodsoft/db/schema.rb:462 - always add db index (stock_changes => [order_id]) /home/i/workspace/foodsoft/db/schema.rb:472 - always add db index (stock_events => [invoice_id]) /home/i/workspace/foodsoft/db/schema.rb:482 - always add db index (supplier_categories => [financial_transaction_class_id]) /home/i/workspace/foodsoft/db/schema.rb:482 - always add db index (supplier_categories => [bank_account_id]) /home/i/workspace/foodsoft/db/schema.rb:489 - always add db index (suppliers => [supplier_category_id]) /home/i/workspace/foodsoft/db/schema.rb:511 - always add db index (tasks => [periodic_task_group_id]) /home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:26 - isolate seed data /home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:31 - isolate seed data /home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:38 - isolate seed data /home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:46 - isolate seed data /home/i/workspace/foodsoft/db/migrate/006_create_articles.rb:23 - isolate seed data /home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:49 - isolate seed data /home/i/workspace/foodsoft/db/migrate/001_create_users.rb:24 - isolate seed data /home/i/workspace/foodsoft/db/migrate/001_create_users.rb:30 - isolate seed data /home/i/workspace/foodsoft/db/migrate/20130718183101_migrate_user_settings.rb:40 - isolate seed data /home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:24 - isolate seed data /home/i/workspace/foodsoft/db/migrate/20130622095040_move_weekly_tasks.rb:4 - isolate seed data /home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:30 - isolate seed data /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:16 - isolate seed data /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:38 - isolate seed data /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:58 - isolate seed data /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:78 - isolate seed data /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:101 - isolate seed data /home/i/workspace/foodsoft/app/models/group_order.rb:48 - law of demeter /home/i/workspace/foodsoft/app/models/group_order_article.rb:125 - law of demeter /home/i/workspace/foodsoft/app/models/group_order_article.rb:127 - law of demeter /home/i/workspace/foodsoft/app/models/group_order_article.rb:128 - law of demeter /home/i/workspace/foodsoft/app/models/group_order_article.rb:131 - law of demeter /home/i/workspace/foodsoft/app/mailers/mailer.rb:84 - law of demeter /home/i/workspace/foodsoft/app/mailers/mailer.rb:87 - law of demeter /home/i/workspace/foodsoft/app/helpers/orders_helper.rb:87 - law of demeter /home/i/workspace/foodsoft/app/helpers/orders_helper.rb:87 - law of demeter /home/i/workspace/foodsoft/app/helpers/orders_helper.rb:90 - law of demeter /home/i/workspace/foodsoft/app/helpers/orders_helper.rb:126 - law of demeter /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:100 - law of demeter /home/i/workspace/foodsoft/plugins/messages/app/mail_receivers/messages_mail_receiver.rb:50 - law of demeter /home/i/workspace/foodsoft/plugins/messages/app/views/messages_mailer/foodsoft_message.text.haml:5 - law of demeter /home/i/workspace/foodsoft/plugins/messages/app/views/messages/show.haml:14 - law of demeter /home/i/workspace/foodsoft/plugins/messages/app/views/messages/show.haml:18 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:3 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:4 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:7 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:9 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:12 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:13 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:14 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:22 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/show.html.haml:1 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/documents/multiple_orders_by_articles.rb:43 - law of demeter /home/i/workspace/foodsoft/plugins/current_orders/app/documents/multiple_orders_by_articles.rb:44 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:41 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:98 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:101 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:103 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:136 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:148 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - law of demeter /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:152 - law of demeter /home/i/workspace/foodsoft/app/views/admin/users/show.html.haml:40 - law of demeter /home/i/workspace/foodsoft/app/views/login/accept_invitation.html.haml:6 - law of demeter /home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:5 - law of demeter /home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:8 - law of demeter /home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:13 - law of demeter /home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:18 - law of demeter /home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:18 - law of demeter /home/i/workspace/foodsoft/app/views/orders/add_article.js.erb:2 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:7 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:7 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:8 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:8 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:9 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:10 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:11 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_articles.html.haml:28 - law of demeter /home/i/workspace/foodsoft/app/views/orders/_articles.html.haml:29 - law of demeter /home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:28 - law of demeter /home/i/workspace/foodsoft/app/views/articles/_article.html.haml:5 - law of demeter /home/i/workspace/foodsoft/app/views/shared/articles_by/_article_single.html.haml:6 - law of demeter /home/i/workspace/foodsoft/app/views/shared/articles_by/_article_single.html.haml:8 - law of demeter /home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:1 - law of demeter /home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:1 - law of demeter /home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:6 - law of demeter /home/i/workspace/foodsoft/app/views/mailer/invite.text.haml:6 - law of demeter /home/i/workspace/foodsoft/app/views/deliveries/show.html.haml:5 - law of demeter /home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:9 - law of demeter /home/i/workspace/foodsoft/app/views/invites/new.html.haml:1 - law of demeter /home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:6 - law of demeter /home/i/workspace/foodsoft/app/views/finance/index.html.haml:20 - law of demeter /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:16 - law of demeter /home/i/workspace/foodsoft/app/views/finance/invoices/show.html.haml:15 - law of demeter /home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:28 - law of demeter /home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:2 - law of demeter /home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:3 - law of demeter /home/i/workspace/foodsoft/app/views/finance/balancing/_order_article.html.haml:9 - law of demeter /home/i/workspace/foodsoft/app/documents/order_matrix.rb:79 - law of demeter /home/i/workspace/foodsoft/app/documents/order_by_articles.rb:30 - law of demeter /home/i/workspace/foodsoft/app/documents/order_by_articles.rb:30 - law of demeter /home/i/workspace/foodsoft/app/controllers/home_controller.rb:72 - law of demeter /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:29 - law of demeter /home/i/workspace/foodsoft/lib/order_pdf.rb:54 - law of demeter /home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:17 - move code into controller /home/i/workspace/foodsoft/app/views/articles/_sync_table.html.haml:17 - move code into controller /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article_info.html.haml:9 - move code into model (order_article use_count > 2) /home/i/workspace/foodsoft/app/views/kaminari/_paginator.html.haml:16 - move code into model (page use_count > 2) /home/i/workspace/foodsoft/app/views/orders/_edit_amount.html.haml:4 - move code into model (order_article use_count > 2) /home/i/workspace/foodsoft/plugins/messages/app/controllers/admin/messagegroups_controller.rb:4 - move model logic into model (@messagegroups use_count > 4) /home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (@message use_count > 4) /home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (original_message use_count > 4) /home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:10 - move model logic into model (I18n use_count > 4) /home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:60 - move model logic into model (@poll use_count > 4) /home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:26 - move model logic into model (@document use_count > 4) /home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:67 - move model logic into model (@document use_count > 4) /home/i/workspace/foodsoft/plugins/discourse/app/controllers/discourse_login_controller.rb:17 - move model logic into model (user use_count > 4) /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:23 - move model logic into model (@page use_count > 4) /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:23 - move model logic into model (page use_count > 4) /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:77 - move model logic into model (@page use_count > 4) /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:107 - move model logic into model (@pages use_count > 4) /home/i/workspace/foodsoft/plugins/links/app/controllers/links_controller.rb:4 - move model logic into model (link use_count > 4) /home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/articles_controller.rb:27 - move model logic into model (@order_articles use_count > 4) /home/i/workspace/foodsoft/app/controllers/home_controller.rb:35 - move model logic into model (@ordergroup use_count > 4) /home/i/workspace/foodsoft/app/controllers/admin/ordergroups_controller.rb:4 - move model logic into model (@ordergroups use_count > 4) /home/i/workspace/foodsoft/app/controllers/admin/mail_delivery_status_controller.rb:4 - move model logic into model (@maildeliverystatus use_count > 4) /home/i/workspace/foodsoft/app/controllers/admin/workgroups_controller.rb:4 - move model logic into model (@workgroups use_count > 4) /home/i/workspace/foodsoft/app/controllers/admin/users_controller.rb:4 - move model logic into model (@users use_count > 4) /home/i/workspace/foodsoft/app/controllers/concerns/auth.rb:48 - move model logic into model (current_user use_count > 4) /home/i/workspace/foodsoft/app/controllers/concerns/collection_scope.rb:27 - move model logic into model (s use_count > 4) /home/i/workspace/foodsoft/app/controllers/concerns/auth_api.rb:48 - move model logic into model (current_user use_count > 4) /home/i/workspace/foodsoft/app/controllers/foodcoop/ordergroups_controller.rb:2 - move model logic into model (@ordergroups use_count > 4) /home/i/workspace/foodsoft/app/controllers/foodcoop/users_controller.rb:2 - move model logic into model (@users use_count > 4) /home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:38 - move model logic into model (@order_article use_count > 4) /home/i/workspace/foodsoft/app/controllers/login_controller.rb:29 - move model logic into model (@user use_count > 4) /home/i/workspace/foodsoft/app/controllers/login_controller.rb:42 - move model logic into model (@invite use_count > 4) /home/i/workspace/foodsoft/app/controllers/login_controller.rb:42 - move model logic into model (@user use_count > 4) /home/i/workspace/foodsoft/app/controllers/orders_controller.rb:33 - move model logic into model (format use_count > 4) /home/i/workspace/foodsoft/app/controllers/orders_controller.rb:75 - move model logic into model (@order use_count > 4) /home/i/workspace/foodsoft/app/controllers/orders_controller.rb:163 - move model logic into model (oa use_count > 4) /home/i/workspace/foodsoft/app/controllers/group_order_articles_controller.rb:12 - move model logic into model (@group_order_article use_count > 4) /home/i/workspace/foodsoft/app/controllers/articles_controller.rb:4 - move model logic into model (@articles use_count > 4) /home/i/workspace/foodsoft/app/controllers/articles_controller.rb:117 - move model logic into model (I18n use_count > 4) /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:18 - move model logic into model (@task use_count > 4) /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:43 - move model logic into model (@task use_count > 4) /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:66 - move model logic into model (task use_count > 4) /home/i/workspace/foodsoft/app/controllers/application_controller.rb:87 - move model logic into model (::I18n use_count > 4) /home/i/workspace/foodsoft/app/controllers/api/v1/order_articles_controller.rb:24 - move model logic into model (scope use_count > 4) /home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:34 - move model logic into model (goa use_count > 4) /home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:46 - move model logic into model (goa use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/ordergroups_controller.rb:2 - move model logic into model (@ordergroups use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/balancing_controller.rb:6 - move model logic into model (@articles use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/bank_accounts_controller.rb:15 - move model logic into model (importer use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:7 - move model logic into model (@financial_transactions_all use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:48 - move model logic into model (@financial_transaction use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:4 - move model logic into model (ft use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:4 - move model logic into model (invoice use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:73 - move model logic into model (financial_transaction use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:26 - move model logic into model (@invoice use_count > 4) /home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:47 - move model logic into model (@invoice use_count > 4) /home/i/workspace/foodsoft/app/views/group_orders/_switch_order.html.haml:9 - not use time_ago_in_words /home/i/workspace/foodsoft/plugins/wiki/config/routes.rb:3 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:39 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:71 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:102 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:114 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:126 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:150 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:175 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/config/routes.rb:225 - overuse route customizations (customize_count > 3) /home/i/workspace/foodsoft/app/helpers/foodcoop_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/home_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/stock_takings_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/order_comments_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/users_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/sessions_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/finance/ordergroups_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/app/helpers/article_categories_helper.rb:1 - remove empty helpers /home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/ordergroups_controller.rb:42 - remove unused methods (CurrentOrders::OrdergroupsController#articles_for_adding) /home/i/workspace/foodsoft/plugins/current_orders/app/controllers/current_orders/articles_controller.rb:41 - remove unused methods (CurrentOrders::ArticlesController#ordergroups_for_adding) /home/i/workspace/foodsoft/app/controllers/home_controller.rb:15 - remove unused methods (HomeController#reference_calculator) /home/i/workspace/foodsoft/app/controllers/home_controller.rb:25 - remove unused methods (HomeController#update_profile) /home/i/workspace/foodsoft/app/controllers/admin/mail_delivery_status_controller.rb:16 - remove unused methods (Admin::MailDeliveryStatusController#destroy_all) /home/i/workspace/foodsoft/app/controllers/stockit_controller.rb:84 - remove unused methods (StockitController#articles_search) /home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:63 - remove unused methods (Api::V1::BaseController#doorkeeper_unauthorized_render_options) /home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:67 - remove unused methods (Api::V1::BaseController#doorkeeper_forbidden_render_options) /home/i/workspace/foodsoft/app/controllers/api/v1/base_controller.rb:77 - remove unused methods (Api::V1::BaseController#show_user) /home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_types_controller.rb:14 - remove unused methods (Api::V1::FinancialTransactionTypesController#max_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_types_controller.rb:18 - remove unused methods (Api::V1::FinancialTransactionTypesController#default_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/article_categories_controller.rb:14 - remove unused methods (Api::V1::ArticleCategoriesController#max_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/article_categories_controller.rb:18 - remove unused methods (Api::V1::ArticleCategoriesController#default_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_classes_controller.rb:14 - remove unused methods (Api::V1::FinancialTransactionClassesController#max_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/financial_transaction_classes_controller.rb:18 - remove unused methods (Api::V1::FinancialTransactionClassesController#default_per_page) /home/i/workspace/foodsoft/app/controllers/api/v1/financial_transactions_controller.rb:20 - remove unused methods (Api::V1::FinancialTransactionsController#ransack_auth_object) /home/i/workspace/foodsoft/app/controllers/api/v1/user/group_order_articles_controller.rb:60 - remove unused methods (Api::V1::User::GroupOrderArticlesController#max_per_page) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:55 - remove unused methods (Finance::FinancialLinksController#add_bank_transaction) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:61 - remove unused methods (Finance::FinancialLinksController#remove_bank_transaction) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:85 - remove unused methods (Finance::FinancialLinksController#add_financial_transaction) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:91 - remove unused methods (Finance::FinancialLinksController#remove_financial_transaction) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:101 - remove unused methods (Finance::FinancialLinksController#add_invoice) /home/i/workspace/foodsoft/app/controllers/finance/financial_links_controller.rb:107 - remove unused methods (Finance::FinancialLinksController#remove_invoice) /home/i/workspace/foodsoft/app/helpers/orders_helper.rb:19 - remove unused methods (OrdersHelper#options_for_suppliers_to_select) /home/i/workspace/foodsoft/app/helpers/application_helper.rb:118 - remove unused methods (ApplicationHelper#weekday) /home/i/workspace/foodsoft/app/helpers/application_helper.rb:133 - remove unused methods (ApplicationHelper#tab_is_active?) /home/i/workspace/foodsoft/app/helpers/application_helper.rb:151 - remove unused methods (ApplicationHelper#remote_link_to) /home/i/workspace/foodsoft/plugins/messages/app/models/message.rb:128 - remove unused methods (Message#can_toggle_private?) /home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:21 - remove unused methods (Page#no_parent) /home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:31 - remove unused methods (Page#dashboard) /home/i/workspace/foodsoft/plugins/wiki/app/models/page.rb:35 - remove unused methods (Page#public_front_page) /home/i/workspace/foodsoft/app/models/bank_gateway.rb:5 - remove unused methods (BankGateway#with_unattended_support) /home/i/workspace/foodsoft/app/models/financial_transaction.rb:35 - remove unused methods (FinancialTransaction#ransackable_associations) /home/i/workspace/foodsoft/app/models/group_order.rb:28 - remove unused methods (GroupOrder#ransackable_associations) /home/i/workspace/foodsoft/app/models/user.rb:200 - remove unused methods (User#member_of?) /home/i/workspace/foodsoft/app/models/user.rb:205 - remove unused methods (User#member_of_groups) /home/i/workspace/foodsoft/app/models/order_article.rb:27 - remove unused methods (OrderArticle#ransackable_associations) /home/i/workspace/foodsoft/app/models/task.rb:112 - remove unused methods (Task#user_list) /home/i/workspace/foodsoft/app/models/group.rb:23 - remove unused methods (Group#non_members) /home/i/workspace/foodsoft/app/models/bank_account.rb:29 - remove unused methods (BankAccount#last_transaction_date) /home/i/workspace/foodsoft/app/models/supplier.rb:29 - remove unused methods (Supplier#ransackable_associations) /home/i/workspace/foodsoft/app/models/group_order_article.rb:24 - remove unused methods (GroupOrderArticle#ransackable_associations) /home/i/workspace/foodsoft/app/models/article.rb:85 - remove unused methods (Article#ransackable_associations) /home/i/workspace/foodsoft/app/models/stock_article.rb:16 - remove unused methods (StockArticle#ransackable_associations) /home/i/workspace/foodsoft/app/models/ordergroup.rb:29 - remove unused methods (Ordergroup#non_members) /home/i/workspace/foodsoft/app/models/order.rb:56 - remove unused methods (Order#ransackable_associations) /home/i/workspace/foodsoft/app/models/order.rb:181 - remove unused methods (Order#articles_sort_by_category) /home/i/workspace/foodsoft/app/models/article_category.rb:28 - remove unused methods (ArticleCategory#ransackable_associations) /home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:26 - replace complex creation with factory method (@document attribute_assignment_count > 2) /home/i/workspace/foodsoft/plugins/discourse/app/controllers/discourse_login_controller.rb:17 - replace complex creation with factory method (user attribute_assignment_count > 2) /home/i/workspace/foodsoft/app/controllers/login_controller.rb:29 - replace complex creation with factory method (@user attribute_assignment_count > 2) /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:18 - replace complex creation with factory method (@task attribute_assignment_count > 2) /home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_messagegroups.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_messagegroups.html.haml:11 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/messages/app/views/admin/messagegroups/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_polls.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_polls.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:42 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:48 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:70 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:71 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_documents.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_move.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_move.html.haml:10 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/documents/app/views/documents/_form.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/printer/app/views/printer_jobs/_jobs.html.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:10 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_title_list.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_body.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:11 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_form.html.haml:17 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_links.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/links/app/views/admin/links/_form.html.haml:10 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:20 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/group_orders/_result.html.haml:51 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:18 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:18 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:36 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_articles.html.haml:43 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/ordergroups/_form.html.haml:21 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_articles.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_article.html.haml:11 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/current_orders/app/views/current_orders/articles/_form.html.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_orders.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:9 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:28 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:30 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:32 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:34 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:36 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:38 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:39 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:41 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:43 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:44 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:47 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:48 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:50 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:53 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:57 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:67 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:76 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:81 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:90 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:97 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:99 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:102 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:105 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:106 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:108 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:111 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:112 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:114 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:114 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:121 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:122 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:123 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:124 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:126 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:126 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:134 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:142 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:142 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:145 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:145 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:150 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:161 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:164 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:166 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:168 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:170 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:175 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:179 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:179 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:180 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/mail_delivery_status/_maildeliverystatus.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/mail_delivery_status/_maildeliverystatus.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/bank_gateways/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/bank_gateways/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/ordergroups/_ordergroups.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/ordergroups/_form.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/supplier_categories/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/supplier_categories/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/finances/_transaction_types.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/finances/_bank_gateways.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/finances/_supplier_categories.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/finances/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/finances/_bank_accounts.html.haml:9 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/financial_transaction_types/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/financial_transaction_types/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/financial_transaction_classes/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/financial_transaction_classes/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/bank_accounts/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/bank_accounts/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/workgroups/_workgroups.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/workgroups/_workgroups.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/workgroups/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/workgroups/_form.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/users/_users.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/users/_users.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/users/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/users/_form.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tab_messages.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tab_messages.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:10 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/admin/configs/_tabs.html.haml:11 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/group_order_articles/_form.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:9 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:17 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:17 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:24 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/home/_start_nav.haml:30 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/_ordergroups.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:20 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/foodcoop/users/_users.html.haml:21 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_new.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:18 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:21 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/order_articles/_edit.html.haml:24 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_orders.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_orders.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_show_js.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_show_js.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:71 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:103 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:22 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:29 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:37 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:41 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:47 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:64 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:64 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:70 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:25 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/suppliers/_form.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:18 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:20 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:23 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_sync.html.haml:27 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:22 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:23 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:34 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_articles.html.haml:36 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:29 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_import_search_results.haml:32 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_edit_all_table.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_destroy_active_article.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_article.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_article.html.haml:17 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_article.html.haml:19 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/articles/_form.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/article_categories/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/stock_takings/_stock_takings.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/stock_takings/_stock_takings.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/shared/_group.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/shared/_group.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_stock_article_for_adding.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:24 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:41 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:63 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:72 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:95 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:95 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:112 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:117 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:138 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/invites/_modal_form.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:10 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:12 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions.html.haml:29 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_transactions/_transactions_search.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:3 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/ordergroups/_ordergroups.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_transactions/_transactions.html.haml:18 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_new_financial_transaction.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_new_financial_transaction.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_financial_transaction.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_financial_transaction.html.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_invoice.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_bank_transaction.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/financial_links/_index_bank_transaction.html.haml:15 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:6 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_invoices.html.haml:25 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:2 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:8 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:13 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:16 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:17 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_invoice.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_invoice.html.haml:26 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:14 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_transport.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_transport.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_note.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_note.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:39 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:41 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:46 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:47 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:49 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:55 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:58 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:61 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:61 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:62 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:1 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:4 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:5 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:7 - replace instance variable with local variable /home/i/workspace/foodsoft/app/views/finance/bank_accounts/_import.html.haml:24 - replace instance variable with local variable /home/i/workspace/foodsoft/plugins/messages/app/controllers/messages_controller.rb:38 - simplify render in controllers /home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:23 - simplify render in controllers /home/i/workspace/foodsoft/plugins/polls/app/controllers/polls_controller.rb:43 - simplify render in controllers /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:17 - simplify render in controllers /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:66 - simplify render in controllers /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:72 - simplify render in controllers /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:83 - simplify render in controllers /home/i/workspace/foodsoft/plugins/wiki/app/controllers/pages_controller.rb:91 - simplify render in controllers /home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:8 - simplify render in controllers /home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:15 - simplify render in controllers /home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:17 - simplify render in controllers /home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:30 - simplify render in controllers /home/i/workspace/foodsoft/plugins/links/app/controllers/admin/links_controller.rb:32 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/admin/financial_transaction_types_controller.rb:40 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/admin/supplier_categories_controller.rb:39 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/admin/bank_accounts_controller.rb:39 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/admin/bank_gateways_controller.rb:39 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/admin/financial_transaction_classes_controller.rb:39 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/suppliers_controller.rb:34 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/suppliers_controller.rb:48 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/deliveries_controller.rb:25 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/deliveries_controller.rb:40 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/foodcoop/workgroups_controller.rb:18 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:22 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/order_articles_controller.rb:34 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/feedback_controller.rb:10 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/orders_controller.rb:84 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/orders_controller.rb:101 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:29 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:62 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/invites_controller.rb:23 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/finance/base_controller.rb:9 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:59 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/finance/financial_transactions_controller.rb:122 - simplify render in controllers /home/i/workspace/foodsoft/app/controllers/finance/invoices_controller.rb:61 - simplify render in controllers /home/i/workspace/foodsoft/plugins/messages/app/views/messagegroups/index.html.haml:5 - simplify render in views /home/i/workspace/foodsoft/plugins/polls/app/views/polls/_form.html.haml:72 - simplify render in views /home/i/workspace/foodsoft/plugins/documents/app/views/documents/index.html.haml:21 - simplify render in views /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:8 - simplify render in views /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_site_map.html.haml:12 - simplify render in views /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/show.html.haml:47 - simplify render in views /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_title_list.html.haml:8 - simplify render in views /home/i/workspace/foodsoft/plugins/wiki/app/views/pages/_page_list_item.html.haml:8 - simplify render in views /home/i/workspace/foodsoft/app/views/group_orders/index.html.haml:27 - simplify render in views /home/i/workspace/foodsoft/app/views/group_orders/index.html.haml:37 - simplify render in views /home/i/workspace/foodsoft/app/views/group_orders/archive.html.haml:8 - simplify render in views /home/i/workspace/foodsoft/app/views/group_orders/archive.html.haml:13 - simplify render in views /home/i/workspace/foodsoft/app/views/home/index.html.haml:4 - simplify render in views /home/i/workspace/foodsoft/app/views/home/index.html.haml:41 - simplify render in views /home/i/workspace/foodsoft/app/views/foodcoop/ordergroups/index.html.haml:13 - simplify render in views /home/i/workspace/foodsoft/app/views/foodcoop/workgroups/index.html.haml:5 - simplify render in views /home/i/workspace/foodsoft/app/views/foodcoop/users/index.html.haml:18 - simplify render in views /home/i/workspace/foodsoft/app/views/orders/index.html.haml:70 - simplify render in views /home/i/workspace/foodsoft/app/views/orders/edit.html.haml:3 - simplify render in views /home/i/workspace/foodsoft/app/views/orders/_edit_amounts.html.haml:104 - simplify render in views /home/i/workspace/foodsoft/app/views/orders/_form.html.haml:65 - simplify render in views /home/i/workspace/foodsoft/app/views/stockit/index.html.haml:71 - simplify render in views /home/i/workspace/foodsoft/app/views/stockit/show.html.haml:19 - simplify render in views /home/i/workspace/foodsoft/app/views/stock_takings/new.html.haml:28 - simplify render in views /home/i/workspace/foodsoft/app/views/deliveries/edit.html.haml:3 - simplify render in views /home/i/workspace/foodsoft/app/views/deliveries/_stock_change.html.haml:3 - simplify render in views /home/i/workspace/foodsoft/app/views/deliveries/_stock_change.html.haml:6 - simplify render in views /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:118 - simplify render in views /home/i/workspace/foodsoft/app/views/deliveries/_form.html.haml:131 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/financial_transactions/new_collection.html.haml:67 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/ordergroups/index.html.haml:17 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/invoices/edit.html.haml:2 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/invoices/new.html.haml:2 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/invoices/_form.html.haml:34 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:50 - simplify render in views /home/i/workspace/foodsoft/app/views/finance/balancing/_edit_results_by_articles.html.haml:56 - simplify render in views /home/i/workspace/foodsoft/app/controllers/articles_controller.rb:226 - use model association (for @article) /home/i/workspace/foodsoft/app/controllers/tasks_controller.rb:43 - use model association (for @task) /home/i/workspace/foodsoft/app/helpers/application_helper.rb:216 - use query attribute (user.nick?) /home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:54 - use query attribute (article.order_number?) /home/i/workspace/foodsoft/db/migrate/20130622095040_move_weekly_tasks.rb:39 - use query attribute (task.due_date?) /home/i/workspace/foodsoft/app/views/group_orders/_form.html.haml:30 - use query attribute (@order.note?) /home/i/workspace/foodsoft/app/views/tasks/_archive_tasks.html.haml:15 - use query attribute (task.due_date?) /home/i/workspace/foodsoft/app/views/tasks/show.haml:12 - use query attribute (@task.description?) /home/i/workspace/foodsoft/app/views/tasks/show.haml:15 - use query attribute (@task.due_date?) /home/i/workspace/foodsoft/app/views/orders/index.html.haml:34 - use query attribute (order.pickup?) /home/i/workspace/foodsoft/app/views/orders/index.html.haml:35 - use query attribute (order.ends?) /home/i/workspace/foodsoft/app/views/orders/index.html.haml:55 - use query attribute (order.pickup?) /home/i/workspace/foodsoft/app/views/suppliers/show.html.haml:87 - use query attribute (order.ends?) /home/i/workspace/foodsoft/app/views/shared/_task_list.haml:14 - use query attribute (task.due_date?) /home/i/workspace/foodsoft/app/views/shared/_open_orders.html.haml:21 - use query attribute (order.pickup?) /home/i/workspace/foodsoft/app/views/shared/_open_orders.html.haml:22 - use query attribute (order.ends?) /home/i/workspace/foodsoft/app/views/finance/bank_transactions/show.html.haml:36 - use query attribute (@bank_transaction.receipt?) /home/i/workspace/foodsoft/app/views/finance/invoices/unpaid.html.haml:29 - use query attribute (supplier.iban?) /home/i/workspace/foodsoft/app/views/finance/balancing/_orders.html.haml:17 - use query attribute (order.ends?) /home/i/workspace/foodsoft/app/views/finance/balancing/new.html.haml:40 - use query attribute (@order.note?) /home/i/workspace/foodsoft/lib/order_txt.rb:12 - use query attribute (supplier.customer_number?) /home/i/workspace/foodsoft/db/migrate/20090317175355_add_profit_to_orders.rb:5 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:27 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:40 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:47 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:61 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:118 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:123 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090120184410_road_to_version_three.rb:159 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/022_add_required_user_for_task.rb:6 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/022_add_required_user_for_task.rb:7 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/002_create_groups.rb:26 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/005_create_financial_transactions.rb:15 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090325175756_create_pages.foodsoft_wiki_engine.rb:17 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090325175756_create_pages.foodsoft_wiki_engine.rb:22 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/013_add_messaging.rb:18 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/013_add_messaging.rb:23 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/006_create_articles.rb:21 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/007_create_article_prices.rb:17 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:17 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/021_remove_table_article_prices.rb:48 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:9 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/004_create_article_meta.rb:24 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/20090731132547_add_stats_to_groups.rb:5 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:6 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/003_create_suppliers.rb:30 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:8 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:16 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:38 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:53 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:78 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:99 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:108 - use say with time in migrations /home/i/workspace/foodsoft/db/migrate/008_create_orders.rb:112 - use say with time in migrations /home/i/workspace/foodsoft/plugins/wiki/db/migrate/20090325175756_create_pages.rb:16 - use say with time in migrations /home/i/workspace/foodsoft/plugins/wiki/db/migrate/20090325175756_create_pages.rb:21 - use say with time in migrations /home/i/workspace/foodsoft/plugins/documents/app/controllers/documents_controller.rb:57 - use scope access /home/i/workspace/foodsoft/app/views/kaminari/_paginator.html.haml:15 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/foodcoop/workgroups/index.html.haml:6 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_update.js.erb:6 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/orders/add_article.js.erb:7 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/orders/receive_on_order_article_create.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/stockit/index.html.haml:6 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/stockit/show.html.haml:20 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/stockit/index_on_stock_article_create.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/stockit/index_on_stock_article_update.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/deliveries/add_stock_change.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/deliveries/form_on_stock_article_update.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/deliveries/form_on_stock_article_create.js.erb:4 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/index.html.haml:51 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/balancing/new_on_order_article_update.js.erb:7 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/balancing/new.html.haml:14 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/balancing/new_on_order_article_create.js.erb:5 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/balancing/_order_article_result.html.haml:3 - remove trailing whitespace /home/i/workspace/foodsoft/app/views/finance/balancing/_summary.haml:26 - remove trailing whitespace Please go to https://rails-bestpractices.com to see more useful Rails Best Practices. Found 701 warnings. ```

tk added a new dependency 2022-09-13 15:32:46 +02:00

#23 QS: remove empty helpers

tk commented

2022-09-13 15:35:46 +02:00

Author

Owner

== Brakeman Report ==

Application Path: /home/i/workspace/foodsoft
Rails Version: 5.2.8
Brakeman Version: 5.2.3
Scan Date: 2022-09-13 15:34:44 +0200
Duration: 12.590429018 seconds
Checks Run: BasicAuth, BasicAuthTimingAttack, CSRFTokenForgeryCVE, ContentTag, CookieSerialization, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, DynamicFinders, EOLRails, EOLRuby, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONEntityEscape, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, MimeTypeDoS, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NestedAttributesBypass, NumberToCurrency, PageCachingCVE, PermitAttributes, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, RouteDoS, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, SprocketsPathTraversal, StripTags, SymbolDoSCVE, TemplateInjection, TranslateBug, UnsafeReflection, UnsafeReflectionMethods, ValidationRegex, VerbConfusion, WithoutProtection, XMLDoS, YAMLParsing

== Overview ==

Controllers: 77
Models: 48
Templates: 318
Errors: 0
Security Warnings: 17

== Warning Types ==

Cross-Site Scripting: 7
Dynamic Render Path: 1
Redirect: 3
Remote Code Execution: 2
SQL Injection: 2
Unmaintained Dependency: 2

== Warnings ==

Confidence: High
Category: Dynamic Render Path
Check: Render
Message: Render path contains parameter value
Code: render(action => ((params[:view] or "site_map") or "title_list"), {})
File: plugins/wiki/app/views/pages/all.html.haml
Line: 17

Confidence: High
Category: Redirect
Check: Redirect
Message: Possible unprotected redirect
Code: redirect_to((Document.find(params[:id]).parent or documents_path), :notice => t(".notice"))
File: plugins/documents/app/controllers/documents_controller.rb
Line: 50

Confidence: High
Category: Redirect
Check: Redirect
Message: Possible unprotected redirect
Code: redirect_to((Document.find(params[:id]).parent or documents_path), :alert => t("errors.general_msg", :msg => $!.message))
File: plugins/documents/app/controllers/documents_controller.rb
Line: 52

Confidence: High
Category: Redirect
Check: Redirect
Message: Possible unprotected redirect
Code: redirect_to((Link.find(params[:id]).url or Net::HTTP.start(URI.parse(Link.find(params[:id]).url).host, URI.parse(Link.find(params[:id]).url).port, :use_ssl => (URI.parse(Link.find(params[:id]).url).scheme == "https")) do  http.request(Net::HTTP::Get.new(URI.parse(Link.find(params[:id]).url)))  end.header["Location"]), :status => 302)
File: plugins/links/app/controllers/links_controller.rb
Line: 27

Confidence: High
Category: Remote Code Execution
Check: Deserialize
Message: `YAML.load` called with parameter value
Code: YAML.load(params[:state])
File: app/controllers/finance/bank_accounts_controller.rb
Line: 20

Confidence: High
Category: SQL Injection
Check: SQL
Message: Possible SQL injection
Code: Ordergroup.undeleted.order(((/^(?<col>name|sum_of_class_\d+)(?<reverse>_reverse)?$/.match(params["sort"])[:col] + " DESC") or "name"))
File: app/controllers/finance/ordergroups_controller.rb
Line: 11

Confidence: High
Category: Unmaintained Dependency
Check: EOLRuby
Message: Support for Ruby 2.6.9 ended on 2022-03-31
File: Gemfile.lock
Line: 344

Confidence: High
Category: Unmaintained Dependency
Check: EOLRails
Message: Support for Rails 5.2.8 ended on 2022-06-01
File: Gemfile.lock
Line: 344

Confidence: Medium
Category: Cross-Site Scripting
Check: JSONEntityEscape
Message: HTML entities in JSON are not escaped by default
Code: ActiveSupport.escape_html_entities_in_json = false
File: config/environments/production.rb
Line: 17

Confidence: Medium
Category: Remote Code Execution
Check: CookieSerialization
Message: Use of unsafe cookie serialization strategy `:marshal` might lead to remote code execution
Code: Rails.application.config.action_dispatch.cookies_serializer = :marshal
File: config/initializers/cookies_serializer.rb
Line: 5

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: t(".paragraph", :name => Ordergroup.include_transaction_class_sum.find(params[:ordergroup_id]).name)
File: app/views/finance/financial_transactions/new.html.haml
Line: 4

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: t(".body", :group => Invite.new(params[:invite]).group.name)
File: app/views/invites/new.html.haml
Line: 1

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: t(".break", :start => format_date(Workgroup.new.break_start), :end => format_date(Workgroup.new.break_end))
File: app/views/shared/_group.html.haml
Line: 11

Confidence: Weak
Category: Cross-Site Scripting
Check: LinkToHref
Message: Potentially unsafe model attribute in `link_to` href
Code: link_to(Supplier.find(params[:id]).url, Supplier.find(params[:id]).url)
File: app/views/suppliers/show.html.haml
Line: 27

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: Diffy::Diff.new(Page::Version.find_by_page_id_and_lock_version(params[:id], params[:old]).body, Page::Version.find_by_page_id_and_lock_version(params[:id], params[:new]).body).to_s(:html)
File: plugins/wiki/app/views/pages/diff.html.haml
Line: 4

Confidence: Weak
Category: Cross-Site Scripting
Check: CrossSiteScripting
Message: Unescaped model attribute
Code: ("| " + t(".last_updated", :user => show_user(Page.find_by_permalink("Home").user), :when => format_datetime(Page.find_by_permalink("Home").updated_at)))
File: plugins/wiki/app/views/pages/show.html.haml
Line: 55

Confidence: Weak
Category: SQL Injection
Check: SQL
Message: Possible SQL injection
Code: tasks.where("due_date < '#{task.due_date}'")
File: app/models/periodic_task_group.rb
Line: 39

``` == Brakeman Report == Application Path: /home/i/workspace/foodsoft Rails Version: 5.2.8 Brakeman Version: 5.2.3 Scan Date: 2022-09-13 15:34:44 +0200 Duration: 12.590429018 seconds Checks Run: BasicAuth, BasicAuthTimingAttack, CSRFTokenForgeryCVE, ContentTag, CookieSerialization, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, DynamicFinders, EOLRails, EOLRuby, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONEntityEscape, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, MimeTypeDoS, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NestedAttributesBypass, NumberToCurrency, PageCachingCVE, PermitAttributes, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, RouteDoS, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, SprocketsPathTraversal, StripTags, SymbolDoSCVE, TemplateInjection, TranslateBug, UnsafeReflection, UnsafeReflectionMethods, ValidationRegex, VerbConfusion, WithoutProtection, XMLDoS, YAMLParsing == Overview == Controllers: 77 Models: 48 Templates: 318 Errors: 0 Security Warnings: 17 == Warning Types == Cross-Site Scripting: 7 Dynamic Render Path: 1 Redirect: 3 Remote Code Execution: 2 SQL Injection: 2 Unmaintained Dependency: 2 == Warnings == Confidence: High Category: Dynamic Render Path Check: Render Message: Render path contains parameter value Code: render(action => ((params[:view] or "site_map") or "title_list"), {}) File: plugins/wiki/app/views/pages/all.html.haml Line: 17 Confidence: High Category: Redirect Check: Redirect Message: Possible unprotected redirect Code: redirect_to((Document.find(params[:id]).parent or documents_path), :notice => t(".notice")) File: plugins/documents/app/controllers/documents_controller.rb Line: 50 Confidence: High Category: Redirect Check: Redirect Message: Possible unprotected redirect Code: redirect_to((Document.find(params[:id]).parent or documents_path), :alert => t("errors.general_msg", :msg => $!.message)) File: plugins/documents/app/controllers/documents_controller.rb Line: 52 Confidence: High Category: Redirect Check: Redirect Message: Possible unprotected redirect Code: redirect_to((Link.find(params[:id]).url or Net::HTTP.start(URI.parse(Link.find(params[:id]).url).host, URI.parse(Link.find(params[:id]).url).port, :use_ssl => (URI.parse(Link.find(params[:id]).url).scheme == "https")) do http.request(Net::HTTP::Get.new(URI.parse(Link.find(params[:id]).url))) end.header["Location"]), :status => 302) File: plugins/links/app/controllers/links_controller.rb Line: 27 Confidence: High Category: Remote Code Execution Check: Deserialize Message: `YAML.load` called with parameter value Code: YAML.load(params[:state]) File: app/controllers/finance/bank_accounts_controller.rb Line: 20 Confidence: High Category: SQL Injection Check: SQL Message: Possible SQL injection Code: Ordergroup.undeleted.order(((/^(?<col>name|sum_of_class_\d+)(?<reverse>_reverse)?$/.match(params["sort"])[:col] + " DESC") or "name")) File: app/controllers/finance/ordergroups_controller.rb Line: 11 Confidence: High Category: Unmaintained Dependency Check: EOLRuby Message: Support for Ruby 2.6.9 ended on 2022-03-31 File: Gemfile.lock Line: 344 Confidence: High Category: Unmaintained Dependency Check: EOLRails Message: Support for Rails 5.2.8 ended on 2022-06-01 File: Gemfile.lock Line: 344 Confidence: Medium Category: Cross-Site Scripting Check: JSONEntityEscape Message: HTML entities in JSON are not escaped by default Code: ActiveSupport.escape_html_entities_in_json = false File: config/environments/production.rb Line: 17 Confidence: Medium Category: Remote Code Execution Check: CookieSerialization Message: Use of unsafe cookie serialization strategy `:marshal` might lead to remote code execution Code: Rails.application.config.action_dispatch.cookies_serializer = :marshal File: config/initializers/cookies_serializer.rb Line: 5 Confidence: Weak Category: Cross-Site Scripting Check: CrossSiteScripting Message: Unescaped model attribute Code: t(".paragraph", :name => Ordergroup.include_transaction_class_sum.find(params[:ordergroup_id]).name) File: app/views/finance/financial_transactions/new.html.haml Line: 4 Confidence: Weak Category: Cross-Site Scripting Check: CrossSiteScripting Message: Unescaped model attribute Code: t(".body", :group => Invite.new(params[:invite]).group.name) File: app/views/invites/new.html.haml Line: 1 Confidence: Weak Category: Cross-Site Scripting Check: CrossSiteScripting Message: Unescaped model attribute Code: t(".break", :start => format_date(Workgroup.new.break_start), :end => format_date(Workgroup.new.break_end)) File: app/views/shared/_group.html.haml Line: 11 Confidence: Weak Category: Cross-Site Scripting Check: LinkToHref Message: Potentially unsafe model attribute in `link_to` href Code: link_to(Supplier.find(params[:id]).url, Supplier.find(params[:id]).url) File: app/views/suppliers/show.html.haml Line: 27 Confidence: Weak Category: Cross-Site Scripting Check: CrossSiteScripting Message: Unescaped model attribute Code: Diffy::Diff.new(Page::Version.find_by_page_id_and_lock_version(params[:id], params[:old]).body, Page::Version.find_by_page_id_and_lock_version(params[:id], params[:new]).body).to_s(:html) File: plugins/wiki/app/views/pages/diff.html.haml Line: 4 Confidence: Weak Category: Cross-Site Scripting Check: CrossSiteScripting Message: Unescaped model attribute Code: ("| " + t(".last_updated", :user => show_user(Page.find_by_permalink("Home").user), :when => format_datetime(Page.find_by_permalink("Home").updated_at))) File: plugins/wiki/app/views/pages/show.html.haml Line: 55 Confidence: Weak Category: SQL Injection Check: SQL Message: Possible SQL injection Code: tasks.where("due_date < '#{task.due_date}'") File: app/models/periodic_task_group.rb Line: 39 ```

tk commented

2022-09-13 15:38:09 +02:00

Author

Owner

--- workspace/foodsoft ‹master› » rubocop                       
Inspecting 498 files
..................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.......................C......................

Offenses:

spec/api/v1/user/financial_transactions_spec.rb:24:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200.
      expect(response.status).to eq 200
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/api/v1/user/group_order_articles_spec.rb:26:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200.
      expect(response.status).to eq 200
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/lib/bank_account_information_importer_spec.rb:7:15: C: [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of heredoc.
    content = <<-JSON
              ^^^^^^^

498 files inspected, 3 offenses detected, 3 offenses autocorrectable

``` --- workspace/foodsoft ‹master› » rubocop Inspecting 498 files ..................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.......................C...................... Offenses: spec/api/v1/user/financial_transactions_spec.rb:24:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200. expect(response.status).to eq 200 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/api/v1/user/group_order_articles_spec.rb:26:7: C: [Correctable] RSpec/Rails/HaveHttpStatus: Prefer expect(response).to have_http_status(200) over expect(response.status).to eq 200. expect(response.status).to eq 200 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/bank_account_information_importer_spec.rb:7:15: C: [Correctable] Style/EmptyHeredoc: Use an empty string literal instead of heredoc. content = <<-JSON ^^^^^^^ 498 files inspected, 3 offenses detected, 3 offenses autocorrectable ```

tk referenced this issue

2022-09-13 15:39:33 +02:00

QS: Fixx rubocop for specs #25

philipp added this to the Kanban project 2023-01-17 12:05:32 +01:00