Optimize insert app role to user

2022-05-16 14:01:56 +02:00 · 2022-05-16 14:01:56 +02:00 · 09f1d2e00a
commit 09f1d2e00a
parent bc85575e9b
1 changed files with 3 additions and 4 deletions
--- a/areas/users/user_service.py
+++ b/areas/users/user_service.py
@ -81,13 +81,12 @@ class UserService:

    @staticmethod
    def __insertAppRoleToUser(userId, userRes):
-        app_role = AppRole.query.filter_by(user_id=userId)
        apps = App.query.all()
-
        app_roles = []
-
        for app in apps:
-            tmp_app_role = app_role.filter_by(app_id=app.id).first()
+            tmp_app_role = AppRole.query.filter_by(
+                user_id=userId, app_id=app.id
+            ).first()
            app_roles.append(
                {
                    "name": app.slug,