local-it/e2e_tests
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

remove flakey test

Browse source
This commit is contained in:
Daniel 2023-12-15 15:00:34 +01:00
parent d4b6ade31a
commit 4c6e6685da
2 changed files with 4 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pytest_abra/coordinator.py
View file

@ -112,11 +112,6 @@ class Coordinator:
load_json_to_environ(test_credentials_path) load_json_to_environ(test_credentials_path)
@staticmethod
def add_to_sys(path: Path):
# this is a function so that it can be monkeypatched
sys.path.append(path.as_posix())
@staticmethod @staticmethod
def create_runner_dict(recipes_dir: Path) -> dict[str, type[Runner]]: def create_runner_dict(recipes_dir: Path) -> dict[str, type[Runner]]:
"""Creates a dictionary holding all the RunnerClasses that can be discovered in recipes_dir """Creates a dictionary holding all the RunnerClasses that can be discovered in recipes_dir
@ -136,7 +131,7 @@ class Coordinator:
runner_discovery_pattern = re.compile("Runner.+") runner_discovery_pattern = re.compile("Runner.+")
# make it possible to import modules from recipes_dir # make it possible to import modules from recipes_dir
Coordinator.add_to_sys(recipes_dir) sys.path.append(recipes_dir.as_posix())
for module_path in recipes_dir.rglob("*/runner_*.py"): for module_path in recipes_dir.rglob("*/runner_*.py"):
rel_path = module_path.relative_to(recipes_dir).as_posix().replace("/", ".").replace(".py", "") rel_path = module_path.relative_to(recipes_dir).as_posix().replace("/", ".").replace(".py", "")

19
tests/test_coordinator.py
View file

@ -37,13 +37,6 @@ def tmp_recipes(tmp_path_factory: pytest.TempPathFactory) -> Path:
return tmp_recipes_target return tmp_recipes_target
def test_runner_runner_dict_import(tmp_recipes: Path):
"""import from recipes dict should work, because create_runner_dict has sys.path.append"""
RUNNER_DICT = Coordinator.create_runner_dict(tmp_recipes)
assert len(RUNNER_DICT.keys()) > 0
@pytest.fixture @pytest.fixture
def clear_sys_path(): def clear_sys_path():
"""clear sys.path before test, restore after""" """clear sys.path before test, restore after"""
@ -53,14 +46,8 @@ def clear_sys_path():
sys.path.extend(syspath_copy) sys.path.extend(syspath_copy)
def test_runner_runner_dict_import_failing(tmp_recipes: Path, clear_sys_path, monkeypatch): def test_runner_runner_dict_import(tmp_recipes: Path, clear_sys_path):
"""import from recipes dict should work, because create_runner_dict has sys.path.append""" """import from recipes dict should work, because create_runner_dict has sys.path.append"""
monkeypatch.setattr( RUNNER_DICT = Coordinator.create_runner_dict(tmp_recipes)
Coordinator, assert len(RUNNER_DICT.keys()) > 0
"add_to_sys",
lambda x: x,
)
with pytest.raises(ModuleNotFoundError):
Coordinator.create_runner_dict(tmp_recipes)