2020-02-07 17:27:45 +01:00
|
|
|
// Vikunja is a to-do list application to facilitate your life.
|
2020-01-09 18:33:22 +01:00
|
|
|
// Copyright 2018-2020 Vikunja and contributors. All rights reserved.
|
2018-11-26 21:17:33 +01:00
|
|
|
//
|
2019-12-04 20:39:56 +01:00
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
2018-11-26 21:17:33 +01:00
|
|
|
//
|
2019-12-04 20:39:56 +01:00
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU General Public License for more details.
|
2018-11-26 21:17:33 +01:00
|
|
|
//
|
2019-12-04 20:39:56 +01:00
|
|
|
// You should have received a copy of the GNU General Public License
|
|
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
2018-11-26 21:17:33 +01:00
|
|
|
|
2018-08-29 08:26:59 +02:00
|
|
|
package models
|
|
|
|
|
|
|
|
import (
|
2020-01-26 18:08:06 +01:00
|
|
|
"code.vikunja.io/api/pkg/db"
|
2020-02-08 13:48:49 +01:00
|
|
|
"code.vikunja.io/api/pkg/timeutil"
|
2020-01-26 18:08:06 +01:00
|
|
|
"code.vikunja.io/api/pkg/user"
|
2018-12-16 14:21:32 +01:00
|
|
|
"code.vikunja.io/web"
|
2018-08-29 08:26:59 +02:00
|
|
|
"github.com/stretchr/testify/assert"
|
2018-08-29 08:50:52 +02:00
|
|
|
"reflect"
|
2018-12-16 14:21:32 +01:00
|
|
|
"runtime"
|
2018-08-29 14:33:04 +02:00
|
|
|
"testing"
|
2018-08-29 08:26:59 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestTeamNamespace(t *testing.T) {
|
2020-01-26 18:08:06 +01:00
|
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
|
2018-08-29 08:26:59 +02:00
|
|
|
// Dummy team <-> namespace relation
|
|
|
|
tn := TeamNamespace{
|
2018-08-29 14:33:04 +02:00
|
|
|
TeamID: 1,
|
2018-08-29 08:26:59 +02:00
|
|
|
NamespaceID: 1,
|
2019-01-21 23:08:04 +01:00
|
|
|
Right: RightAdmin,
|
2018-08-29 08:26:59 +02:00
|
|
|
}
|
|
|
|
|
2020-01-26 18:08:06 +01:00
|
|
|
dummyuser, err := user.GetUserByID(1)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
// Test normal creation
|
2019-08-14 21:59:31 +02:00
|
|
|
allowed, _ := tn.CanCreate(dummyuser)
|
2019-03-24 13:35:50 +01:00
|
|
|
assert.True(t, allowed)
|
2019-08-14 21:59:31 +02:00
|
|
|
err = tn.Create(dummyuser)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
// Test again (should fail)
|
2019-08-14 21:59:31 +02:00
|
|
|
err = tn.Create(dummyuser)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrTeamAlreadyHasAccess(err))
|
|
|
|
|
|
|
|
// Test with invalid team right
|
|
|
|
tn2 := tn
|
2019-01-21 23:08:04 +01:00
|
|
|
tn2.Right = RightUnknown
|
2019-08-14 21:59:31 +02:00
|
|
|
err = tn2.Create(dummyuser)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
2019-01-21 23:08:04 +01:00
|
|
|
assert.True(t, IsErrInvalidRight(err))
|
2018-08-29 08:26:59 +02:00
|
|
|
|
|
|
|
// Check with inexistant team
|
|
|
|
tn3 := tn
|
|
|
|
tn3.TeamID = 324
|
2019-08-14 21:59:31 +02:00
|
|
|
err = tn3.Create(dummyuser)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrTeamDoesNotExist(err))
|
|
|
|
|
|
|
|
// Check with a namespace which does not exist
|
|
|
|
tn4 := tn
|
|
|
|
tn4.NamespaceID = 423
|
2019-08-14 21:59:31 +02:00
|
|
|
err = tn4.Create(dummyuser)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrNamespaceDoesNotExist(err))
|
|
|
|
|
|
|
|
// Check readall
|
2019-10-23 23:11:40 +02:00
|
|
|
teams, _, _, err := tn.ReadAll(dummyuser, "", 1, 50)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.NoError(t, err)
|
2018-08-29 08:50:52 +02:00
|
|
|
assert.Equal(t, reflect.TypeOf(teams).Kind(), reflect.Slice)
|
|
|
|
s := reflect.ValueOf(teams)
|
|
|
|
assert.Equal(t, s.Len(), 1)
|
2018-08-29 08:26:59 +02:00
|
|
|
|
|
|
|
// Check readall for a nonexistant namespace
|
2019-10-23 23:11:40 +02:00
|
|
|
_, _, _, err = tn4.ReadAll(dummyuser, "", 1, 50)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrNamespaceDoesNotExist(err))
|
|
|
|
|
|
|
|
// Check with no right to read the namespace
|
2020-01-26 18:08:06 +01:00
|
|
|
nouser := &user.User{ID: 393}
|
2019-10-23 23:11:40 +02:00
|
|
|
_, _, _, err = tn.ReadAll(nouser, "", 1, 50)
|
2018-08-29 08:26:59 +02:00
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrNeedToHaveNamespaceReadAccess(err))
|
|
|
|
|
|
|
|
// Delete it
|
2019-08-14 21:59:31 +02:00
|
|
|
allowed, _ = tn.CanDelete(dummyuser)
|
2019-03-24 13:35:50 +01:00
|
|
|
assert.True(t, allowed)
|
2018-08-29 08:26:59 +02:00
|
|
|
err = tn.Delete()
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
// Try deleting with a nonexisting team
|
|
|
|
err = tn3.Delete()
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrTeamDoesNotExist(err))
|
|
|
|
|
|
|
|
// Try deleting with a nonexistant namespace
|
|
|
|
err = tn4.Delete()
|
|
|
|
assert.Error(t, err)
|
2018-09-04 19:39:31 +02:00
|
|
|
assert.True(t, IsErrTeamDoesNotHaveAccessToNamespace(err))
|
2018-12-16 14:21:32 +01:00
|
|
|
}
|
2018-08-29 08:26:59 +02:00
|
|
|
|
2018-12-16 14:21:32 +01:00
|
|
|
func TestTeamNamespace_Update(t *testing.T) {
|
|
|
|
type fields struct {
|
|
|
|
ID int64
|
|
|
|
TeamID int64
|
|
|
|
NamespaceID int64
|
2019-01-21 23:08:04 +01:00
|
|
|
Right Right
|
2020-02-08 13:48:49 +01:00
|
|
|
Created timeutil.TimeStamp
|
|
|
|
Updated timeutil.TimeStamp
|
2018-12-16 14:21:32 +01:00
|
|
|
CRUDable web.CRUDable
|
|
|
|
Rights web.Rights
|
|
|
|
}
|
|
|
|
tests := []struct {
|
|
|
|
name string
|
|
|
|
fields fields
|
|
|
|
wantErr bool
|
|
|
|
errType func(err error) bool
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
name: "Test Update Normally",
|
|
|
|
fields: fields{
|
|
|
|
NamespaceID: 3,
|
|
|
|
TeamID: 1,
|
2019-01-21 23:08:04 +01:00
|
|
|
Right: RightAdmin,
|
2018-12-16 14:21:32 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "Test Update to write",
|
|
|
|
fields: fields{
|
|
|
|
NamespaceID: 3,
|
|
|
|
TeamID: 1,
|
2019-01-21 23:08:04 +01:00
|
|
|
Right: RightWrite,
|
2018-12-16 14:21:32 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "Test Update to Read",
|
|
|
|
fields: fields{
|
|
|
|
NamespaceID: 3,
|
|
|
|
TeamID: 1,
|
2019-01-21 23:08:04 +01:00
|
|
|
Right: RightRead,
|
2018-12-16 14:21:32 +01:00
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "Test Update with invalid right",
|
|
|
|
fields: fields{
|
|
|
|
NamespaceID: 3,
|
|
|
|
TeamID: 1,
|
|
|
|
Right: 500,
|
|
|
|
},
|
|
|
|
wantErr: true,
|
2019-01-21 23:08:04 +01:00
|
|
|
errType: IsErrInvalidRight,
|
2018-12-16 14:21:32 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
|
|
t.Run(tt.name, func(t *testing.T) {
|
2020-01-26 18:08:06 +01:00
|
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
|
2018-12-16 14:21:32 +01:00
|
|
|
tl := &TeamNamespace{
|
|
|
|
ID: tt.fields.ID,
|
|
|
|
TeamID: tt.fields.TeamID,
|
|
|
|
NamespaceID: tt.fields.NamespaceID,
|
|
|
|
Right: tt.fields.Right,
|
|
|
|
Created: tt.fields.Created,
|
|
|
|
Updated: tt.fields.Updated,
|
|
|
|
CRUDable: tt.fields.CRUDable,
|
|
|
|
Rights: tt.fields.Rights,
|
|
|
|
}
|
|
|
|
err := tl.Update()
|
|
|
|
if (err != nil) != tt.wantErr {
|
|
|
|
t.Errorf("TeamNamespace.Update() error = %v, wantErr %v", err, tt.wantErr)
|
|
|
|
}
|
|
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
|
|
t.Errorf("TeamNamespace.Update() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
2018-08-29 14:33:04 +02:00
|
|
|
}
|