vikunja-api/vendor/honnef.co/go/tools/internal/sharedcheck/lint.go

72 lines
1.9 KiB
Go
Raw Normal View History

2018-12-28 23:15:05 +01:00
package sharedcheck
import (
"go/ast"
"go/types"
"golang.org/x/tools/go/analysis"
2020-05-29 22:15:21 +02:00
"honnef.co/go/tools/code"
"honnef.co/go/tools/internal/passes/buildir"
"honnef.co/go/tools/ir"
2018-12-28 23:15:05 +01:00
. "honnef.co/go/tools/lint/lintdsl"
)
func CheckRangeStringRunes(pass *analysis.Pass) (interface{}, error) {
2020-05-29 22:15:21 +02:00
for _, fn := range pass.ResultOf[buildir.Analyzer].(*buildir.IR).SrcFuncs {
cb := func(node ast.Node) bool {
2018-12-28 23:15:05 +01:00
rng, ok := node.(*ast.RangeStmt)
2020-05-29 22:15:21 +02:00
if !ok || !code.IsBlank(rng.Key) {
2018-12-28 23:15:05 +01:00
return true
}
2020-05-29 22:15:21 +02:00
v, _ := fn.ValueForExpr(rng.X)
2018-12-28 23:15:05 +01:00
// Check that we're converting from string to []rune
2020-05-29 22:15:21 +02:00
val, _ := v.(*ir.Convert)
2018-12-28 23:15:05 +01:00
if val == nil {
return true
}
Tsrc, ok := val.X.Type().(*types.Basic)
if !ok || Tsrc.Kind() != types.String {
return true
}
Tdst, ok := val.Type().(*types.Slice)
if !ok {
return true
}
TdstElem, ok := Tdst.Elem().(*types.Basic)
if !ok || TdstElem.Kind() != types.Int32 {
return true
}
// Check that the result of the conversion is only used to
// range over
refs := val.Referrers()
if refs == nil {
return true
}
// Expect two refs: one for obtaining the length of the slice,
// one for accessing the elements
2020-05-29 22:15:21 +02:00
if len(code.FilterDebug(*refs)) != 2 {
2018-12-28 23:15:05 +01:00
// TODO(dh): right now, we check that only one place
// refers to our slice. This will miss cases such as
// ranging over the slice twice. Ideally, we'd ensure that
// the slice is only used for ranging over (without
// accessing the key), but that is harder to do because in
2020-05-29 22:15:21 +02:00
// IR form, ranging over a slice looks like an ordinary
2018-12-28 23:15:05 +01:00
// loop with index increments and slice accesses. We'd
// have to look at the associated AST node to check that
// it's a range statement.
return true
}
pass.Reportf(rng.Pos(), "should range over string, not []rune(string)")
2018-12-28 23:15:05 +01:00
return true
}
2020-05-29 22:15:21 +02:00
Inspect(fn.Source(), cb)
2018-12-28 23:15:05 +01:00
}
return nil, nil
2018-12-28 23:15:05 +01:00
}