local-it/vikunja-api
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix saving reminders of repeating tasks

Browse source
This commit is contained in:
kolaente 2021-08-13 21:36:16 +02:00
parent 7ffa08ee1a
commit 483496cc26
No known key found for this signature in database
GPG key ID: F40E70337AB24C9B
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
pkg/models/tasks.go
View file

@ -974,6 +974,13 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
ot.Reminders[i] = r.Reminder ot.Reminders[i] = r.Reminder
} }
// When a repeating task is marked as done, we update all deadlines and reminders and set it as undone
updateDone(&ot, t)
if err := setTaskBucket(s, t, &ot, t.BucketID != ot.BucketID); err != nil {
return err
}
// Update the assignees // Update the assignees
if err := ot.updateTaskAssignees(s, t.Assignees, a); err != nil { if err := ot.updateTaskAssignees(s, t.Assignees, a); err != nil {
return err return err
@ -1004,14 +1011,6 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
"kanban_position", "kanban_position",
} }
// When a repeating task is marked as done, we update all deadlines and reminders and set it as undone
updateDone(&ot, t)
err = setTaskBucket(s, t, &ot, t.BucketID != ot.BucketID)
if err != nil {
return err
}
// If the task is being moved between lists, make sure to move the bucket + index as well // If the task is being moved between lists, make sure to move the bucket + index as well
if t.ListID != 0 && ot.ListID != t.ListID { if t.ListID != 0 && ot.ListID != t.ListID {
latestTask := &Task{} latestTask := &Task{}