Only send reminders for undone tasks

2021-01-31 12:54:15 +01:00 · 2021-01-31 12:54:15 +01:00 · 6bdc1fdb0d
commit 6bdc1fdb0d
parent d69c799197
2 changed files with 6 additions and 0 deletions
--- a/pkg/db/fixtures/task_reminders.yml
+++ b/pkg/db/fixtures/task_reminders.yml
@ -6,3 +6,7 @@
  task_id: 27
  reminder: 2018-12-01 01:13:44
  created: 2018-12-01 01:12:04
+- id: 3
+  task_id: 2
+  reminder: 2018-12-01 01:13:44
+  created: 2018-12-01 01:12:04
--- a/pkg/models/task_reminder.go
+++ b/pkg/models/task_reminder.go
@ -106,7 +106,9 @@ func getTasksWithRemindersInTheNextMinute(s *xorm.Session, now time.Time) (taskI

 	reminders := []*TaskReminder{}
 	err = s.
+		Join("INNER", "tasks", "tasks.id = task_reminders.task_id").
 		Where("reminder >= ? and reminder < ?", now.Format(dbFormat), nextMinute.Format(dbFormat)).
+		And("tasks.done = false").
 		Find(&reminders)
 	if err != nil {
 		return