local-it/vikunja-api
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed a bug where updating a list would update it with the same values it had before

Browse source
This commit is contained in:
kolaente 2018-12-25 15:30:11 +01:00
parent 5a93475be9
commit ce0bff8d9c
No known key found for this signature in database
GPG key ID: F40E70337AB24C9B
2 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/models/list_create_update.go
View file

@ -69,10 +69,10 @@ func CreateOrUpdateList(list *List) (err error) {
// @Router /lists/{id} [post]
func (l *List) Update() (err error) {
// Check if it exists
if err = l.GetSimpleByID(); err != nil {
lorig := List{ID: l.ID}
if err = lorig.GetSimpleByID(); err != nil {
return
}
return CreateOrUpdateList(l)
}

10
pkg/models/list_rights.go
View file

@ -75,22 +75,12 @@ func (l *List) CanRead(a web.Auth) bool {
// CanDelete checks if the user can delete a list
func (l *List) CanDelete(a web.Auth) bool {
doer := getUserForRights(a)
if err := l.GetSimpleByID(); err != nil {
log.Log.Error("Error occurred during CanDelete for List: %s", err)
return false
}
return l.IsAdmin(doer)
}
// CanUpdate checks if the user can update a list
func (l *List) CanUpdate(a web.Auth) bool {
doer := getUserForRights(a)
if err := l.GetSimpleByID(); err != nil {
log.Log.Error("Error occurred during CanUpdate for List: %s", err)
return false
}
return l.CanWrite(doer)
}