local-it/vikunja-api
Archived
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed a bug where deleting an attachment would cause a nil panic

Browse source
This commit is contained in:
kolaente 2019-11-19 23:07:48 +01:00
parent c203d73b33
commit dcec9511dc
Signed by untrusted user who does not match committer: konrad
GPG key ID: F40E70337AB24C9B
3 changed files with 65 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

58
pkg/models/task_attachment_test.go
View file

@ -150,3 +150,61 @@ func TestTaskAttachment_Delete(t *testing.T) {
assert.NoError(t, err)
})
}
func TestTaskAttachment_Rights(t *testing.T) {
u := &User{ID: 1}
t.Run("Can Read", func(t *testing.T) {
t.Run("Allowed", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 1}
can, err := ta.CanRead(u)
assert.NoError(t, err)
assert.True(t, can)
})
t.Run("Forbidden", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 14}
can, err := ta.CanRead(u)
assert.NoError(t, err)
assert.False(t, can)
})
})
t.Run("Can Delete", func(t *testing.T) {
t.Run("Allowed", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 1}
can, err := ta.CanDelete(u)
assert.NoError(t, err)
assert.True(t, can)
})
t.Run("Forbidden, no access", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 14}
can, err := ta.CanDelete(u)
assert.NoError(t, err)
assert.False(t, can)
})
t.Run("Forbidden, shared read only", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 15}
can, err := ta.CanDelete(u)
assert.NoError(t, err)
assert.False(t, can)
})
})
t.Run("Can Create", func(t *testing.T) {
t.Run("Allowed", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 1}
can, err := ta.CanCreate(u)
assert.NoError(t, err)
assert.True(t, can)
})
t.Run("Forbidden, no access", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 14}
can, err := ta.CanCreate(u)
assert.NoError(t, err)
assert.False(t, can)
})
t.Run("Forbidden, shared read only", func(t *testing.T) {
ta := &TaskAttachment{TaskID: 15}
can, err := ta.CanCreate(u)
assert.NoError(t, err)
assert.False(t, can)
})
})
}