08205008e7
Fix query param name Add option to include null results when filtering Always set db time to gmt Fix null filter Fix timezone setting for todoist parsing Fix timezone setting for wunderlist parsing Fix import Fix caldav reminder parsing Use timezone from config Add error and test for invalid filter values Fix integration tests Remove task collection date hack Fix task filter Fix lint Fix tests and fixtures for date timezone stuff Properly set timezone Change fixtures time zone to gmt Set db timezone Set created and updated timestamps for all fixtures Fix lint Fix test fixtures Fix misspell Fix test fixtures Partially fix tests Remove timeutil package Remove adding _unix suffix hack Remove _unix suffix Move all timeutil.TimeStamp to time.Time Remove all Unix suffixes in field names Add better error messages when running migrations Make sure to not migrate 0 unix timestamps to 1970 iso dates Add migration script for sqlite Add converting sqlite values Convert 0 unix timestamps to null in postgres Convert 0 to null in timestamps Automatically rename _unix suffix Add all tables and columns for migration Fix sql migration query for mysql Fail with an error if trying to use an unsupported dbms Co-authored-by: kolaente <k@knt.li> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/594
372 lines
8.5 KiB
Go
372 lines
8.5 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-2020 Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/user"
|
|
"gopkg.in/d4l3k/messagediff.v1"
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.vikunja.io/web"
|
|
)
|
|
|
|
func TestListUser_Create(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
UserID int64
|
|
Username string
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
a web.Auth
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "ListUsers Create normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2,
|
|
},
|
|
},
|
|
{
|
|
name: "ListUsers Create for duplicate",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 3,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasAccess,
|
|
},
|
|
{
|
|
name: "ListUsers Create with invalid right",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2,
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
{
|
|
name: "ListUsers Create with inexisting list",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2000,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrListDoesNotExist,
|
|
},
|
|
{
|
|
name: "ListUsers Create with inexisting user",
|
|
fields: fields{
|
|
Username: "user500",
|
|
ListID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "ListUsers Create with the owner as shared user",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 1,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
ul := &ListUser{
|
|
ID: tt.fields.ID,
|
|
UserID: tt.fields.UserID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := ul.Create(tt.args.a)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Create() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Create() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_ReadAll(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
UserID int64
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
search string
|
|
a web.Auth
|
|
page int
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want interface{}
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test readall normal",
|
|
fields: fields{
|
|
ListID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 3},
|
|
},
|
|
want: []*UserWithRight{
|
|
{
|
|
User: user.User{
|
|
ID: 1,
|
|
Username: "user1",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
IsActive: true,
|
|
Created: testCreatedTime,
|
|
Updated: testUpdatedTime,
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
{
|
|
User: user.User{
|
|
ID: 2,
|
|
Username: "user2",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
Created: testCreatedTime,
|
|
Updated: testUpdatedTime,
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Test ReadAll by a user who does not have access to the list",
|
|
fields: fields{
|
|
ListID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 4},
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrNeedToHaveListReadAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
ul := &ListUser{
|
|
ID: tt.fields.ID,
|
|
UserID: tt.fields.UserID,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
got, _, _, err := ul.ReadAll(tt.args.a, tt.args.search, tt.args.page, 50)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.ReadAll() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.ReadAll() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
if diff, equal := messagediff.PrettyDiff(got, tt.want); !equal {
|
|
t.Errorf("ListUser.ReadAll() = %v, want %v, diff: %v", got, tt.want, diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_Update(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test Update Normally",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightAdmin,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to write",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightWrite,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to Read",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update with invalid right",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
lu := &ListUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := lu.Update()
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Update() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Update() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_Delete(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Try deleting some unexistant user",
|
|
fields: fields{
|
|
Username: "user1000",
|
|
ListID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "Try deleting a user which does not has access but exists",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 4,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserDoesNotHaveAccessToList,
|
|
},
|
|
{
|
|
name: "Try deleting normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 3,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
lu := &ListUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := lu.Delete()
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Delete() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Delete() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
})
|
|
}
|
|
}
|