61d49c3a56
Instead of naeveily checking for all reminders due in the next minute, we now check all reminders in all time zones in the next minutes. This essentially means checking for reminders due in the next 14 or past 12 hours. We then check for each user who would receive a reminder from that result if it is actually due in their time zone. This should prevent issues where users would get the reminder in the time zone of their server, not in their own. Co-authored-by: kolaente <k@knt.li> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/1092 Co-authored-by: konrad <k@knt.li> Co-committed-by: konrad <k@knt.li>
51 lines
1.7 KiB
Go
51 lines
1.7 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-2021 Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public Licensee as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public Licensee for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public Licensee
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestReminderGetTasksInTheNextMinute(t *testing.T) {
|
|
t.Run("Found Tasks", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
now, err := time.Parse(time.RFC3339Nano, "2018-12-01T01:13:00Z")
|
|
assert.NoError(t, err)
|
|
notifications, err := getTasksWithRemindersDueAndTheirUsers(s, now)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, notifications, 1)
|
|
assert.Equal(t, int64(27), notifications[0].Task.ID)
|
|
})
|
|
t.Run("Found No Tasks", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
now, err := time.Parse(time.RFC3339Nano, "2018-12-02T01:13:00Z")
|
|
assert.NoError(t, err)
|
|
taskIDs, err := getTasksWithRemindersDueAndTheirUsers(s, now)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, taskIDs, 0)
|
|
})
|
|
}
|