e433289832
Fix misspell Fix sorting tasks with null values Fix sorting by priority for postgres Merge branch 'master' into feature/position Add community link Update golang.org/x/crypto commit hash to 44a6062 (#429) Update golang.org/x/crypto commit hash to 44a6062 Reviewed-on: https://kolaente.dev/vikunja/api/pulls/429 Update module lib/pq to v1.4.0 (#428) Update module lib/pq to v1.4.0 Reviewed-on: https://kolaente.dev/vikunja/api/pulls/428 Fix updating position Add ordering tasks in buckets by position Make task sort by string Merge branch 'master' into feature/position Update golang.org/x/crypto commit hash to 3c4aac8 (#419) Update golang.org/x/crypto commit hash to 3c4aac8 Reviewed-on: https://kolaente.dev/vikunja/api/pulls/419 Merge branch 'master' into feature/position Fix moving tasks back into the empty (ID: 0) bucket Add adding a default position when creating new tasks Update golang.org/x/crypto commit hash to a76a400 (#411) Update golang.org/x/crypto commit hash to a76a400 Reviewed-on: https://kolaente.dev/vikunja/api/pulls/411 Remove unused code Fix tests Add migration for position attribute Add position attribute Co-authored-by: kolaente <k@knt.li> Co-authored-by: renovate <renovatebot@kolaente.de> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/412
92 lines
2.4 KiB
Go
92 lines
2.4 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-2020 Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"github.com/stretchr/testify/assert"
|
|
"testing"
|
|
)
|
|
|
|
func TestSortParamValidation(t *testing.T) {
|
|
t.Run("Test valid order by", func(t *testing.T) {
|
|
t.Run(orderAscending.String(), func(t *testing.T) {
|
|
s := &sortParam{
|
|
orderBy: orderAscending,
|
|
sortBy: "id",
|
|
}
|
|
err := s.validate()
|
|
assert.NoError(t, err)
|
|
})
|
|
t.Run(orderDescending.String(), func(t *testing.T) {
|
|
s := &sortParam{
|
|
orderBy: orderDescending,
|
|
sortBy: "id",
|
|
}
|
|
err := s.validate()
|
|
assert.NoError(t, err)
|
|
})
|
|
})
|
|
t.Run("Test valid sort by", func(t *testing.T) {
|
|
for _, test := range []string{
|
|
taskPropertyID,
|
|
taskPropertyText,
|
|
taskPropertyDescription,
|
|
taskPropertyDone,
|
|
taskPropertyDoneAtUnix,
|
|
taskPropertyDueDateUnix,
|
|
taskPropertyCreatedByID,
|
|
taskPropertyListID,
|
|
taskPropertyRepeatAfter,
|
|
taskPropertyPriority,
|
|
taskPropertyStartDateUnix,
|
|
taskPropertyEndDateUnix,
|
|
taskPropertyHexColor,
|
|
taskPropertyPercentDone,
|
|
taskPropertyUID,
|
|
taskPropertyCreated,
|
|
taskPropertyUpdated,
|
|
taskPropertyPosition,
|
|
} {
|
|
t.Run(test, func(t *testing.T) {
|
|
s := &sortParam{
|
|
orderBy: orderAscending,
|
|
sortBy: test,
|
|
}
|
|
err := s.validate()
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
})
|
|
t.Run("Test invalid order by", func(t *testing.T) {
|
|
s := &sortParam{
|
|
orderBy: "somethingInvalid",
|
|
sortBy: "id",
|
|
}
|
|
err := s.validate()
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrInvalidSortOrder(err))
|
|
})
|
|
t.Run("Test invalid sort by", func(t *testing.T) {
|
|
s := &sortParam{
|
|
orderBy: orderAscending,
|
|
sortBy: "somethingInvalid",
|
|
}
|
|
err := s.validate()
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrInvalidTaskField(err))
|
|
})
|
|
}
|