0ab9ce9ec4
Co-authored-by: kolaente <k@knt.li> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/777 Co-authored-by: konrad <konrad@kola-entertainments.de> Co-committed-by: konrad <konrad@kola-entertainments.de>
415 lines
9.6 KiB
Go
415 lines
9.6 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-2021 Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public Licensee as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public Licensee for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public Licensee
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/user"
|
|
"code.vikunja.io/web"
|
|
"github.com/stretchr/testify/assert"
|
|
"gopkg.in/d4l3k/messagediff.v1"
|
|
)
|
|
|
|
func TestListUser_Create(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
UserID int64
|
|
Username string
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
a web.Auth
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "ListUsers Create normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2,
|
|
},
|
|
},
|
|
{
|
|
name: "ListUsers Create for duplicate",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 3,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasAccess,
|
|
},
|
|
{
|
|
name: "ListUsers Create with invalid right",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2,
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
{
|
|
name: "ListUsers Create with inexisting list",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 2000,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrListDoesNotExist,
|
|
},
|
|
{
|
|
name: "ListUsers Create with inexisting user",
|
|
fields: fields{
|
|
Username: "user500",
|
|
ListID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "ListUsers Create with the owner as shared user",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 1,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserAlreadyHasAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
|
|
ul := &ListUser{
|
|
ID: tt.fields.ID,
|
|
UserID: tt.fields.UserID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := ul.Create(s, tt.args.a)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Create() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Create() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
|
|
err = s.Commit()
|
|
assert.NoError(t, err)
|
|
|
|
if !tt.wantErr {
|
|
db.AssertExists(t, "users_list", map[string]interface{}{
|
|
"user_id": ul.UserID,
|
|
"list_id": tt.fields.ListID,
|
|
}, false)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_ReadAll(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
UserID int64
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
type args struct {
|
|
search string
|
|
a web.Auth
|
|
page int
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
want interface{}
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test readall normal",
|
|
fields: fields{
|
|
ListID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 3},
|
|
},
|
|
want: []*UserWithRight{
|
|
{
|
|
User: user.User{
|
|
ID: 1,
|
|
Username: "user1",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
IsActive: true,
|
|
Issuer: "local",
|
|
EmailRemindersEnabled: true,
|
|
Created: testCreatedTime,
|
|
Updated: testUpdatedTime,
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
{
|
|
User: user.User{
|
|
ID: 2,
|
|
Username: "user2",
|
|
Password: "$2a$14$dcadBoMBL9jQoOcZK8Fju.cy0Ptx2oZECkKLnaa8ekRoTFe1w7To.",
|
|
Issuer: "local",
|
|
EmailRemindersEnabled: true,
|
|
Created: testCreatedTime,
|
|
Updated: testUpdatedTime,
|
|
},
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Test ReadAll by a user who does not have access to the list",
|
|
fields: fields{
|
|
ListID: 3,
|
|
},
|
|
args: args{
|
|
a: &user.User{ID: 4},
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrNeedToHaveListReadAccess,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
|
|
ul := &ListUser{
|
|
ID: tt.fields.ID,
|
|
UserID: tt.fields.UserID,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
got, _, _, err := ul.ReadAll(s, tt.args.a, tt.args.search, tt.args.page, 50)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.ReadAll() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.ReadAll() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
if diff, equal := messagediff.PrettyDiff(got, tt.want); !equal {
|
|
t.Errorf("ListUser.ReadAll() = %v, want %v, diff: %v", got, tt.want, diff)
|
|
}
|
|
_ = s.Close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_Update(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Test Update Normally",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightAdmin,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to write",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightWrite,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update to Read",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: RightRead,
|
|
},
|
|
},
|
|
{
|
|
name: "Test Update with invalid right",
|
|
fields: fields{
|
|
ListID: 3,
|
|
Username: "user1",
|
|
Right: 500,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrInvalidRight,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
|
|
lu := &ListUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := lu.Update(s, &user.User{ID: 1})
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Update() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Update() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
|
|
err = s.Commit()
|
|
assert.NoError(t, err)
|
|
|
|
if !tt.wantErr {
|
|
db.AssertExists(t, "users_list", map[string]interface{}{
|
|
"list_id": tt.fields.ListID,
|
|
"user_id": lu.UserID,
|
|
"right": tt.fields.Right,
|
|
}, false)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestListUser_Delete(t *testing.T) {
|
|
type fields struct {
|
|
ID int64
|
|
Username string
|
|
UserID int64
|
|
ListID int64
|
|
Right Right
|
|
Created time.Time
|
|
Updated time.Time
|
|
CRUDable web.CRUDable
|
|
Rights web.Rights
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
wantErr bool
|
|
errType func(err error) bool
|
|
}{
|
|
{
|
|
name: "Try deleting some unexistant user",
|
|
fields: fields{
|
|
Username: "user1000",
|
|
ListID: 2,
|
|
},
|
|
wantErr: true,
|
|
errType: user.IsErrUserDoesNotExist,
|
|
},
|
|
{
|
|
name: "Try deleting a user which does not has access but exists",
|
|
fields: fields{
|
|
Username: "user1",
|
|
ListID: 4,
|
|
},
|
|
wantErr: true,
|
|
errType: IsErrUserDoesNotHaveAccessToList,
|
|
},
|
|
{
|
|
name: "Try deleting normally",
|
|
fields: fields{
|
|
Username: "user1",
|
|
UserID: 1,
|
|
ListID: 3,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
|
|
lu := &ListUser{
|
|
ID: tt.fields.ID,
|
|
Username: tt.fields.Username,
|
|
ListID: tt.fields.ListID,
|
|
Right: tt.fields.Right,
|
|
Created: tt.fields.Created,
|
|
Updated: tt.fields.Updated,
|
|
CRUDable: tt.fields.CRUDable,
|
|
Rights: tt.fields.Rights,
|
|
}
|
|
err := lu.Delete(s, &user.User{ID: 1})
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ListUser.Delete() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
if (err != nil) && tt.wantErr && !tt.errType(err) {
|
|
t.Errorf("ListUser.Delete() Wrong error type! Error = %v, want = %v", err, runtime.FuncForPC(reflect.ValueOf(tt.errType).Pointer()).Name())
|
|
}
|
|
|
|
err = s.Commit()
|
|
assert.NoError(t, err)
|
|
|
|
if !tt.wantErr {
|
|
db.AssertMissing(t, "users_list", map[string]interface{}{
|
|
"user_id": tt.fields.UserID,
|
|
"list_id": tt.fields.ListID,
|
|
})
|
|
}
|
|
})
|
|
}
|
|
}
|