699d3d6060
Increase golangci timeout Fix installing golangci-lint in ci Remove mage targets replaced by golangci Run golint in ci Add goheader linter Enable & fix more linters Fix lint issues Add mage target to automagically fix issues found by golangci golangci-lint run --fix Add golangci config Add golangci mage target Co-authored-by: kolaente <k@knt.li> Reviewed-on: https://kolaente.dev/vikunja/api/pulls/676 Co-Authored-By: konrad <konrad@kola-entertainments.de> Co-Committed-By: konrad <konrad@kola-entertainments.de>
206 lines
5.2 KiB
Go
206 lines
5.2 KiB
Go
// Copyright 2018-2020 Vikunja and contriubtors. All rights reserved.
|
|
//
|
|
// This file is part of Vikunja.
|
|
//
|
|
// Vikunja is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Vikunja is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Vikunja. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/user"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestTaskRelation_Create(t *testing.T) {
|
|
t.Run("Normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 2,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
err := rel.Create(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
db.AssertExists(t, "task_relations", map[string]interface{}{
|
|
"task_id": 1,
|
|
"other_task_id": 2,
|
|
"relation_kind": RelationKindSubtask,
|
|
"created_by_id": 1,
|
|
}, false)
|
|
})
|
|
t.Run("Two Tasks In Different Lists", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 13,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
err := rel.Create(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
db.AssertExists(t, "task_relations", map[string]interface{}{
|
|
"task_id": 1,
|
|
"other_task_id": 13,
|
|
"relation_kind": RelationKindSubtask,
|
|
"created_by_id": 1,
|
|
}, false)
|
|
})
|
|
t.Run("Already Existing", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 29,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
err := rel.Create(&user.User{ID: 1})
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrRelationAlreadyExists(err))
|
|
})
|
|
t.Run("Same Task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 1,
|
|
}
|
|
err := rel.Create(&user.User{ID: 1})
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrRelationTasksCannotBeTheSame(err))
|
|
})
|
|
}
|
|
|
|
func TestTaskRelation_Delete(t *testing.T) {
|
|
t.Run("Normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 29,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
err := rel.Delete()
|
|
assert.NoError(t, err)
|
|
db.AssertMissing(t, "task_relations", map[string]interface{}{
|
|
"task_id": 1,
|
|
"other_task_id": 29,
|
|
"relation_kind": RelationKindSubtask,
|
|
})
|
|
})
|
|
t.Run("Not existing", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 9999,
|
|
OtherTaskID: 3,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
err := rel.Delete()
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrRelationDoesNotExist(err))
|
|
})
|
|
}
|
|
|
|
func TestTaskRelation_CanCreate(t *testing.T) {
|
|
t.Run("Normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 2,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
assert.True(t, can)
|
|
})
|
|
t.Run("Two tasks on different lists", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 13,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
assert.True(t, can)
|
|
})
|
|
t.Run("No update rights on base task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 14,
|
|
OtherTaskID: 1,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("No update rights on base task, but read rights", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 15,
|
|
OtherTaskID: 1,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("No read rights on other task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 14,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("Nonexisting base task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 999999,
|
|
OtherTaskID: 1,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrTaskDoesNotExist(err))
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("Nonexisting other task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
|
|
rel := TaskRelation{
|
|
TaskID: 1,
|
|
OtherTaskID: 999999,
|
|
RelationKind: RelationKindSubtask,
|
|
}
|
|
can, err := rel.CanCreate(&user.User{ID: 1})
|
|
assert.Error(t, err)
|
|
assert.True(t, IsErrTaskDoesNotExist(err))
|
|
assert.False(t, can)
|
|
})
|
|
}
|