feat: review changes
This commit is contained in:
parent
f3358269e5
commit
2db820d926
8 changed files with 10 additions and 14 deletions
|
@ -7,9 +7,5 @@
|
|||
"video": false,
|
||||
"retries": {
|
||||
"runMode": 2
|
||||
},
|
||||
"testFiles": [
|
||||
"list/list.spec.js",
|
||||
"**/*.spec.js"
|
||||
]
|
||||
}
|
||||
}
|
||||
|
|
|
@ -54,8 +54,8 @@ function useRouteWithModal() {
|
|||
const historyState = computed(() => route.fullPath && window.history.state)
|
||||
|
||||
const routeWithModal = computed(() => {
|
||||
if (historyState.value.backgroundView) {
|
||||
return router.resolve(historyState.value.backgroundView)
|
||||
if (historyState.value.backdropView) {
|
||||
return router.resolve(historyState.value.backdropView)
|
||||
} else {
|
||||
return route
|
||||
}
|
||||
|
@ -65,7 +65,7 @@ function useRouteWithModal() {
|
|||
|
||||
const currentModal = shallowRef(null)
|
||||
watchEffect(() => {
|
||||
currentModal.value = historyState.value.backgroundView
|
||||
currentModal.value = historyState.value.backdropView
|
||||
? route.matched[0]?.components.default
|
||||
: null
|
||||
})
|
||||
|
|
|
@ -107,7 +107,7 @@ export default {
|
|||
return {
|
||||
name: 'task.detail',
|
||||
params: { id: this.taskEditTask.id },
|
||||
state: { backgroundView: this.$router.currentRoute.value.fullPath },
|
||||
state: { backdropView: this.$router.currentRoute.value.fullPath },
|
||||
}
|
||||
},
|
||||
},
|
||||
|
|
|
@ -116,7 +116,7 @@ export default {
|
|||
this.$router.push({
|
||||
name: 'task.detail',
|
||||
params: { id: this.task.id },
|
||||
state: { backgroundView: this.$router.currentRoute.value.fullPath },
|
||||
state: { backdropView: this.$router.currentRoute.value.fullPath },
|
||||
})
|
||||
},
|
||||
},
|
||||
|
|
|
@ -167,7 +167,7 @@ export default {
|
|||
return {
|
||||
name: 'task.detail',
|
||||
params: { id: this.task.id },
|
||||
state: { backgroundView: this.$router.currentRoute.value.fullPath },
|
||||
state: { backdropView: this.$router.currentRoute.value.fullPath },
|
||||
}
|
||||
},
|
||||
},
|
||||
|
|
|
@ -21,7 +21,7 @@ export function useTaskList(initTasks) {
|
|||
const loading = computed(() => taskCollectionService.value.loading)
|
||||
const totalPages = computed(() => taskCollectionService.value.totalPages)
|
||||
|
||||
const tasks = ref([])
|
||||
const tasks = ref([])
|
||||
const currentPage = ref(0)
|
||||
const loadedList = ref(null)
|
||||
const searchTerm = ref('')
|
||||
|
|
|
@ -282,7 +282,7 @@ const taskDetailRoutes = computed(() => Object.fromEntries(
|
|||
{
|
||||
name: 'task.detail',
|
||||
params: { id },
|
||||
state: { backgroundView: router.currentRoute.value.fullPath },
|
||||
state: { backdropView: router.currentRoute.value.fullPath },
|
||||
},
|
||||
])),
|
||||
))
|
||||
|
|
|
@ -124,7 +124,7 @@ async function loadList(listIdToLoad) {
|
|||
const loadedList = await listService.value.get(list)
|
||||
await store.dispatch(CURRENT_LIST, loadedList)
|
||||
} finally {
|
||||
loadedListId.value = listId
|
||||
loadedListId.value = listId.value
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
|
Loading…
Reference in a new issue