local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: don't emit a possible null task

Browse source
This commit is contained in:
kolaente 2022-09-29 18:05:25 +02:00
parent 3970d0fd31
commit 5f5ed410df
No known key found for this signature in database
GPG key ID: F40E70337AB24C9B
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/components/tasks/add-task.vue
View file

@ -181,15 +181,19 @@ async function addTask() {
try { try {
newTaskTitle.value = '' newTaskTitle.value = ''
await Promise.all(newTasks) await Promise.all(newTasks)
const taskRelationService = new TaskRelationService() const taskRelationService = new TaskRelationService()
const relations = tasksToCreate.map(async t => { const relations = tasksToCreate.map(async t => {
const createdTask = createdTasks.find(ct => ct.title === t.title) const createdTask = createdTasks.find(ct => ct.title === t.title)
if (typeof createdTask === 'undefined') {
return
}
if (t.parent === null) { if (t.parent === null) {
emit('taskAdded', createdTask) emit('taskAdded', createdTask)
return return
} }
const createdParentTask = createdTasks.find(ct => ct.title === t.parent) const createdParentTask = createdTasks.find(ct => ct.title === t.parent)
if (typeof createdTask === 'undefined' || typeof createdParentTask === 'undefined') { if (typeof createdTask === 'undefined' || typeof createdParentTask === 'undefined') {
return return
@ -200,11 +204,11 @@ async function addTask() {
otherTaskId: createdParentTask.id, otherTaskId: createdParentTask.id,
relationKind: RELATION_KIND.PARENTTASK, relationKind: RELATION_KIND.PARENTTASK,
})) }))
createdTask.relatedTasks[RELATION_KIND.PARENTTASK] = [createdParentTask] createdTask.relatedTasks[RELATION_KIND.PARENTTASK] = [createdParentTask]
// we're only emitting here so that the relation shows up in the task list // we're only emitting here so that the relation shows up in the task list
emit('taskAdded', createdTask) emit('taskAdded', createdTask)
return rel return rel
}) })
await Promise.all(relations) await Promise.all(relations)