local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: list title not set as page title after closing a task popup

Browse source
This commit is contained in:
kolaente 2022-05-08 11:58:37 +02:00
parent 21a8298a96
commit a38bd7e971
No known key found for this signature in database
GPG key ID: F40E70337AB24C9B
3 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/router/index.ts
View file

@ -51,6 +51,7 @@ import NamespaceSettingDelete from '../views/namespaces/settings/delete.vue'
import FilterNew from '@/views/filters/FilterNew.vue' import FilterNew from '@/views/filters/FilterNew.vue'
import FilterEdit from '@/views/filters/FilterEdit.vue' import FilterEdit from '@/views/filters/FilterEdit.vue'
import FilterDelete from '@/views/filters/FilterDelete.vue' import FilterDelete from '@/views/filters/FilterDelete.vue'
import {setTitle} from '@/helpers/setTitle'
const PasswordResetComponent = () => import('../views/user/PasswordReset.vue') const PasswordResetComponent = () => import('../views/user/PasswordReset.vue')
const GetPasswordResetComponent = () => import('../views/user/RequestPasswordReset.vue') const GetPasswordResetComponent = () => import('../views/user/RequestPasswordReset.vue')
@ -372,7 +373,14 @@ const router = createRouter({
path: '/lists/:listId/kanban', path: '/lists/:listId/kanban',
name: 'list.kanban', name: 'list.kanban',
component: ListKanban, component: ListKanban,
beforeEnter: (to) => saveListView(to.params.listId, to.name), beforeEnter: (to) => {
saveListView(to.params.listId, to.name)
// Properly set the page title when a task popup is closed
const listFromStore = store.getters['lists/getListById'](parseInt(to.params.listId))
if(listFromStore) {
setTitle(listFromStore.title)
}
},
props: route => ({ listId: parseInt(route.params.listId as string) }), props: route => ({ listId: parseInt(route.params.listId as string) }),
}, },
{ {

4
src/views/list/ListKanban.vue
View file

@ -235,12 +235,12 @@ import BucketModel from '../../models/bucket'
import {mapState} from 'vuex' import {mapState} from 'vuex'
import Rights from '../../models/constants/rights.json' import Rights from '../../models/constants/rights.json'
import {LOADING, LOADING_MODULE} from '@/store/mutation-types' import {LOADING, LOADING_MODULE} from '@/store/mutation-types'
import ListWrapper from './ListWrapper' import ListWrapper from './ListWrapper.vue'
import FilterPopup from '@/components/list/partials/filter-popup.vue' import FilterPopup from '@/components/list/partials/filter-popup.vue'
import Dropdown from '@/components/misc/dropdown.vue' import Dropdown from '@/components/misc/dropdown.vue'
import {getCollapsedBucketState, saveCollapsedBucketState} from '@/helpers/saveCollapsedBucketState' import {getCollapsedBucketState, saveCollapsedBucketState} from '@/helpers/saveCollapsedBucketState'
import {calculateItemPosition} from '../../helpers/calculateItemPosition' import {calculateItemPosition} from '../../helpers/calculateItemPosition'
import KanbanCard from '@/components/tasks/partials/kanban-card' import KanbanCard from '@/components/tasks/partials/kanban-card.vue'
const DRAG_OPTIONS = { const DRAG_OPTIONS = {
// sortable options // sortable options

5
src/views/tasks/TaskDetailView.vue
View file

@ -443,7 +443,7 @@ import {CURRENT_LIST} from '@/store/mutation-types'
import {uploadFile} from '@/helpers/attachments' import {uploadFile} from '@/helpers/attachments'
import ChecklistSummary from '../../components/tasks/partials/checklist-summary' import ChecklistSummary from '../../components/tasks/partials/checklist-summary'
import CreatedUpdated from '@/components/tasks/partials/createdUpdated' import CreatedUpdated from '@/components/tasks/partials/createdUpdated'
import { setTitle } from '@/helpers/setTitle'
export default defineComponent({ export default defineComponent({
name: 'TaskDetailView', name: 'TaskDetailView',
@ -575,7 +575,8 @@ export default defineComponent({
this.$store.commit('attachments/set', this.task.attachments) this.$store.commit('attachments/set', this.task.attachments)
this.taskColor = this.task.hexColor this.taskColor = this.task.hexColor
this.setActiveFields() this.setActiveFields()
this.setTitle(this.task.title) await this.$nextTick()
setTitle(this.task.title)
} finally { } finally {
this.scrollToHeading() this.scrollToHeading()
await this.$nextTick() await this.$nextTick()