local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix Datetime Handling (#168)

Browse source 
Fix task filters

Fix null dates

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/168
This commit is contained in:
konrad 2020-06-27 17:04:30 +00:00
parent d586e15c56
commit cd588caa02
5 changed files with 32 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/migrator/migration.vue
View file

@ -78,8 +78,8 @@
this.wunderlistCode = this.$route.query.code this.wunderlistCode = this.$route.query.code
this.migrationService.getStatus() this.migrationService.getStatus()
.then(r => { .then(r => {
if(r.time_unix) { if(r.time) {
this.lastMigrationDate = new Date(r.time_unix) this.lastMigrationDate = new Date(r.time)
return return
} }
this.migrate() this.migrate()

10
src/models/task.js
View file

@ -14,9 +14,9 @@ export default class TaskModel extends AbstractModel {
this.listId = Number(this.listId) this.listId = Number(this.listId)
// Make date objects from timestamps // Make date objects from timestamps
this.dueDate = this.dueDate ? new Date(this.dueDate) : null this.dueDate = this.dueDate && !this.dueDate.startsWith('0001') ? new Date(this.dueDate) : null
this.startDate = this.startDate ? new Date(this.startDate) : null this.startDate = this.startDate && !this.startDate.startsWith('0001') ? new Date(this.startDate) : null
this.endDate = this.endDate ? new Date(this.endDate) : null this.endDate = this.endDate && !this.endDate.startsWith('0001') ? new Date(this.endDate) : null
// Cancel all scheduled notifications for this task to be sure to only have available notifications // Cancel all scheduled notifications for this task to be sure to only have available notifications
this.cancelScheduledNotifications() this.cancelScheduledNotifications()
@ -64,7 +64,7 @@ export default class TaskModel extends AbstractModel {
}) })
// Set the task identifier to empty if the list does not have one // Set the task identifier to empty if the list does not have one
if(this.identifier === `-${this.index}`) { if (this.identifier === `-${this.index}`) {
this.identifier = '' this.identifier = ''
} }
@ -157,7 +157,7 @@ export default class TaskModel extends AbstractModel {
async scheduleNotification(date) { async scheduleNotification(date) {
if(date < new Date()) { if (date < new Date()) {
console.debug('Date is in the past, not scheduling a notification. Date is ', date) console.debug('Date is in the past, not scheduling a notification. Date is ', date)
return return
} }

6
src/views/list/views/Table.vue
View file

@ -68,15 +68,15 @@
</th> </th>
<th v-if="activeColumns.dueDate"> <th v-if="activeColumns.dueDate">
Due&nbsp;Date Due&nbsp;Date
<sort :order="sortBy.due_date_unix" @click="sort('due_date_unix')"/> <sort :order="sortBy.due_date" @click="sort('due_date')"/>
</th> </th>
<th v-if="activeColumns.startDate"> <th v-if="activeColumns.startDate">
Start&nbsp;Date Start&nbsp;Date
<sort :order="sortBy.start_date_unix" @click="sort('start_date_unix')"/> <sort :order="sortBy.start_date" @click="sort('start_date')"/>
</th> </th>
<th v-if="activeColumns.endDate"> <th v-if="activeColumns.endDate">
End&nbsp;Date End&nbsp;Date
<sort :order="sortBy.end_date_unix" @click="sort('end_date_unix')"/> <sort :order="sortBy.end_date" @click="sort('end_date')"/>
</th> </th>
<th v-if="activeColumns.percentDone"> <th v-if="activeColumns.percentDone">
%&nbsp;Done %&nbsp;Done

9
src/views/tasks/ShowTasks.vue
View file

@ -57,24 +57,25 @@
} }
const params = { const params = {
sort_by: ['due_date_unix', 'id'], sort_by: ['due_date', 'id'],
order_by: ['desc', 'desc'], order_by: ['desc', 'desc'],
filter_by: ['done'], filter_by: ['done'],
filter_value: [false], filter_value: [false],
filter_comparator: ['equals'], filter_comparator: ['equals'],
filter_concat: 'and', filter_concat: 'and',
filter_include_nulls: true,
} }
if (!this.showAll) { if (!this.showAll) {
params.filter_by.push('start_date') params.filter_by.push('start_date')
params.filter_value.push(Math.round(+this.startDate / 1000)) params.filter_value.push(this.startDate)
params.filter_comparator.push('greater') params.filter_comparator.push('greater')
params.filter_by.push('end_date') params.filter_by.push('end_date')
params.filter_value.push(Math.round(+this.endDate / 1000)) params.filter_value.push(this.endDate)
params.filter_comparator.push('less') params.filter_comparator.push('less')
params.filter_by.push('due_date') params.filter_by.push('due_date')
params.filter_value.push(Math.round(+this.endDate / 1000)) params.filter_value.push(this.endDate)
params.filter_comparator.push('less') params.filter_comparator.push('less')
} }

6
src/views/tasks/TaskDetailView.vue
View file

@ -460,9 +460,9 @@
}, },
setActiveFields() { setActiveFields() {
this.dueDate = +new Date(this.task.dueDate) === 0 ? null : this.task.dueDate this.dueDate = this.task.dueDate ? this.task.dueDate : null
this.task.startDate = +new Date(this.task.startDate) === 0 ? null : this.task.startDate this.task.startDate = this.task.startDate ? this.task.startDate : null
this.task.endDate = +new Date(this.task.endDate) === 0 ? null : this.task.endDate this.task.endDate = this.task.endDate ? this.task.endDate : null
// Set all active fields based on values in the model // Set all active fields based on values in the model
this.activeFields.assignees = this.task.assignees.length > 0 this.activeFields.assignees = this.task.assignees.length > 0