local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: use BaseButton in MenuButton and fix computed (#1532)

Browse source 
Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1532
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
Co-committed-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
This commit is contained in:
Dominik Pschenitschni 2022-02-13 22:01:36 +00:00 committed by konrad
parent eac07d3169
commit d57c9af332
1 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/components/home/MenuButton.vue
View file

@ -1,8 +1,7 @@
<template> <template>
<button <BaseButton
type="button"
@click="$store.commit('toggleMenu')"
class="menu-show-button" class="menu-show-button"
@click="$store.commit('toggleMenu')"
@shortkey="() => $store.commit('toggleMenu')" @shortkey="() => $store.commit('toggleMenu')"
v-shortcut="'Control+e'" v-shortcut="'Control+e'"
:title="$t('keyboardShortcuts.toggleMenu')" :title="$t('keyboardShortcuts.toggleMenu')"
@ -10,11 +9,14 @@
/> />
</template> </template>
<script setup> <script setup lang="ts">
import {computed} from 'vue' import {computed} from 'vue'
import {store} from '@/store' import {useStore} from 'vuex'
const menuActive = computed(() => store.menuActive) import BaseButton from '@/components/base/BaseButton.vue'
const store = useStore()
const menuActive = computed(() => store.state.menuActive)
</script> </script>
<style lang="scss" scoped> <style lang="scss" scoped>
@ -22,11 +24,6 @@ $lineWidth: 2rem;
$size: $lineWidth + 1rem; $size: $lineWidth + 1rem;
.menu-show-button { .menu-show-button {
// FIXME: create general button component
appearance: none;
background-color: transparent;
border: 0;
min-height: $size; min-height: $size;
width: $size; width: $size;