local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Don't load already loaded task attachments again when saving an edited task description

Browse source
This commit is contained in:
kolaente 2021-07-09 18:04:49 +02:00
parent 2854d3a0c2
commit eac4f88a65
No known key found for this signature in database
GPG key ID: F40E70337AB24C9B
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/components/input/editor.vue
View file

@ -1,7 +1,7 @@
<template> <template>
<div :class="{'is-pulled-up': isEditEnabled}" class="editor"> <div :class="{'is-pulled-up': isEditEnabled}" class="editor">
<div class="is-pulled-right mb-4" v-if="hasPreview && isEditEnabled && !hasEditBottom"> <div class="is-pulled-right mb-4" v-if="hasPreview && isEditEnabled && !hasEditBottom">
<x-button <x-button
v-if="!isEditActive" v-if="!isEditActive"
@click="toggleEdit" @click="toggleEdit"
:shadow="false" :shadow="false"
@ -9,8 +9,8 @@
> >
<icon icon="pen"/> <icon icon="pen"/>
</x-button> </x-button>
<x-button <x-button
v-else v-else
@click="toggleEdit" @click="toggleEdit"
:shadow="false" :shadow="false"
type="secondary" type="secondary"
@ -117,6 +117,7 @@ export default {
preview: '', preview: '',
attachmentService: null, attachmentService: null,
loadedAttachments: {},
config: { config: {
autoDownloadFontAwesome: false, autoDownloadFontAwesome: false,
@ -284,7 +285,7 @@ export default {
// that in the end, only one change event is triggered to the outside per change. // that in the end, only one change event is triggered to the outside per change.
handleInput(val) { handleInput(val) {
// Don't bubble if the text is up to date // Don't bubble if the text is up to date
if(val === this.text) { if (val === this.text) {
return return
} }
@ -375,7 +376,7 @@ export default {
}, },
}) })
this.preview = DOMPurify.sanitize(marked(this.text), { ADD_ATTR: ['target'] }) this.preview = DOMPurify.sanitize(marked(this.text), {ADD_ATTR: ['target']})
// Since the render function is synchronous, we can't do async http requests in it. // Since the render function is synchronous, we can't do async http requests in it.
// Therefore, we can't resolve the blob url at (markdown) compile time. // Therefore, we can't resolve the blob url at (markdown) compile time.
@ -392,6 +393,13 @@ export default {
const parts = img.dataset.src.substr(window.API_URL.length + 1).split('/') const parts = img.dataset.src.substr(window.API_URL.length + 1).split('/')
const taskId = parseInt(parts[1]) const taskId = parseInt(parts[1])
const attachmentId = parseInt(parts[3]) const attachmentId = parseInt(parts[3])
const cacheKey = `${taskId}-${attachmentId}`
if (typeof this.loadedAttachments[cacheKey] !== 'undefined') {
img.src = this.loadedAttachments[cacheKey]
continue
}
const attachment = new AttachmentModel({taskId: taskId, id: attachmentId}) const attachment = new AttachmentModel({taskId: taskId, id: attachmentId})
if (this.attachmentService === null) { if (this.attachmentService === null) {
@ -401,6 +409,7 @@ export default {
this.attachmentService.getBlobUrl(attachment) this.attachmentService.getBlobUrl(attachment)
.then(url => { .then(url => {
img.src = url img.src = url
this.loadedAttachments[cacheKey] = url
}) })
} }
} }