local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 53 Pull requests 1 Projects 2 Releases 3 Packages 1 Activity Actions

refactor: address review comments for join view
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/promote/production Build is passing
Details

Browse source
This commit is contained in:
Simon 2026-03-10 22:54:41 +01:00
parent f1d0526209
commit 021b709e6a
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
12 changed files with 113 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

19
test/membership/join_request_test.exs
View file

@ -38,6 +38,21 @@ defmodule Mv.Membership.JoinRequestTest do
end
test "persists first_name, last_name and form_data when provided" do
# Allowlist must include custom fields so FilterFormDataByAllowlist persists them
{:ok, settings} = Membership.get_settings()
Mv.Membership.update_settings(settings, %{
join_form_enabled: true,
join_form_field_ids: ["email", "first_name", "last_name", "city", "notes"],
join_form_field_required: %{
"email" => true,
"first_name" => false,
"last_name" => false,
"city" => false,
"notes" => false
}
})
attrs =
@valid_submit_attrs
|> Map.put(:confirmation_token, "token-#{System.unique_integer([:positive])}")
@ -128,8 +143,8 @@ defmodule Mv.Membership.JoinRequestTest do
Mv.Membership.update_settings(settings, %{
join_form_enabled: true,
join_form_field_ids: ["email", "first_name"],
join_form_field_required: %{"email" => true, "first_name" => false}
join_form_field_ids: ["email", "first_name", "city"],
join_form_field_required: %{"email" => true, "first_name" => false, "city" => false}
})
attrs = %{