refactor(types): remove dead catch-all clauses unreachable per success typing

lib/mv_web/controllers/auth_controller.ex

@@ -335,8 +335,6 @@ defmodule MvWeb.AuthController do
     end
   end
 
-  defp redact_url(_), do: "[redacted]"
-
   def sign_out(conn, _params) do
     conn = clear_session(conn, :mv) |> put_flash(:success, gettext("You are now signed out"))
 

lib/mv_web/live/components/member_filter_component.ex

@@ -935,7 +935,6 @@ defmodule MvWeb.Components.MemberFilterComponent do
       {nil, true} -> "#{base_classes} btn-active"
       {:in, true} -> "#{base_classes} btn-success btn-active"
       {:not_in, true} -> "#{base_classes} btn-error btn-active"
-      _ -> "#{base_classes} btn-outline"
     end
   end
 

lib/mv_web/live/group_live/show.ex

@@ -836,12 +836,6 @@ defmodule MvWeb.GroupLive.Show do
     end
   end
 
-  defp perform_add_members(socket, _group, _member_ids, _actor) do
-    {:noreply,
-     socket
-     |> put_flash(:error, gettext("No members selected."))}
-  end
-
   defp handle_successful_add_members(socket, group, actor) do
     socket = reload_group(socket, group.slug, actor)
 

lib/mv_web/live/join_live.ex

@@ -287,8 +287,6 @@ defmodule MvWeb.JoinLive do
     end
   end
 
-  defp member_field_input_type(_), do: "text"
-
   defp member_field_atom(field_id) when is_binary(field_id) do
     Mv.Constants.member_fields()
     |> Enum.find(&(Atom.to_string(&1) == field_id))

lib/mv_web/live/member_live/index.ex

@@ -1218,8 +1218,6 @@ defmodule MvWeb.MemberLive.Index do
     end
   end
 
-  defp apply_one_fee_type_filter(query, _, _), do: query
-
   defp apply_cycle_status_filter(members, nil, _show_current), do: members
 
   defp apply_cycle_status_filter(members, status, show_current)
@@ -1297,8 +1295,6 @@ defmodule MvWeb.MemberLive.Index do
     end
   end
 
-  defp valid_sort_field?(_), do: false
-
   defp valid_sort_field_db_or_custom?(field) when is_atom(field) do
     non_sortable_fields = [:notes]
     valid_fields = Mv.Constants.member_fields() -- non_sortable_fields
@@ -1558,8 +1554,6 @@ defmodule MvWeb.MemberLive.Index do
     assign(socket, :group_filters, Map.take(filters, valid_group_ids))
   end
 
-  defp maybe_update_group_filters(socket, _), do: socket
-
   defp maybe_update_fee_type_filters(socket, params) when is_map(params) do
     prefix = @fee_type_filter_prefix
     prefix_len = String.length(prefix)
@@ -1586,8 +1580,6 @@ defmodule MvWeb.MemberLive.Index do
     assign(socket, :fee_type_filters, Map.take(filters, valid_fee_type_ids))
   end
 
-  defp maybe_update_fee_type_filters(socket, _), do: socket
-
   defp add_fee_type_filter_entry(acc, key, value_str, prefix_len) do
     key_str = to_string(key)
     raw_id = String.slice(key_str, prefix_len, String.length(key_str) - prefix_len)
@@ -1719,8 +1711,6 @@ defmodule MvWeb.MemberLive.Index do
     assign(socket, :date_filters, DateFilter.from_params(params, date_custom_fields))
   end
 
-  defp maybe_update_date_filters(socket, _params), do: socket
-
   # -------------------------------------------------------------
   # Custom Field Value Helpers
   # -------------------------------------------------------------

lib/mv_web/live/member_live/index/field_selection.ex

@@ -103,8 +103,6 @@ defmodule MvWeb.MemberLive.Index.FieldSelection do
     end)
   end
 
-  defp parse_cookie_header(_), do: %{}
-
   @doc """
   Saves field selection to cookie.
 
@@ -218,8 +216,6 @@ defmodule MvWeb.MemberLive.Index.FieldSelection do
     end
   end
 
-  defp parse_json(_), do: %{}
-
   # Parses a comma-separated string of field names
   defp parse_fields_string(fields_string) do
     fields_string