test: restore removed tests including optimizations

test/mv_web/user_live/form_test.exs

@@ -10,15 +10,29 @@ defmodule MvWeb.UserLive.FormTest do
   end
 
   describe "new user form - display" do
-    test "shows correct form elements", %{conn: conn} do
+    @tag :ui
+    test "shows correct form elements and password field toggling", %{conn: conn} do
       {:ok, view, html} = setup_live_view(conn, "/users/new")
 
+      # Basic form elements
       assert html =~ "New User"
       assert html =~ "Email"
       assert html =~ "Set Password"
       assert has_element?(view, "form#user-form[phx-submit='save']")
       assert has_element?(view, "input[name='user[email]']")
       assert has_element?(view, "input[type='checkbox'][name='set_password']")
+
+      # Password fields should be hidden initially
+      refute has_element?(view, "input[name='user[password]']")
+      refute has_element?(view, "input[name='user[password_confirmation]']")
+
+      # Toggle password fields
+      view |> element("input[name='set_password']") |> render_click()
+
+      # Password fields should now be visible
+      assert has_element?(view, "input[name='user[password]']")
+      assert has_element?(view, "input[name='user[password_confirmation]']")
+      assert render(view) =~ "Password requirements"
     end
   end
 
@@ -71,17 +85,89 @@ defmodule MvWeb.UserLive.FormTest do
       assert to_string(user.email) == "storetest@example.com"
       assert is_nil(user.hashed_password)
     end
+
+    test "stores password when provided", %{conn: conn} do
+      {:ok, view, _html} = setup_live_view(conn, "/users/new")
+
+      view |> element("input[name='set_password']") |> render_click()
+
+      view
+      |> form("#user-form",
+        user: %{
+          email: "passwordstoretest@example.com",
+          password: "securepassword123",
+          password_confirmation: "securepassword123"
+        }
+      )
+      |> render_submit()
+
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
+      user =
+        Ash.get!(
+          Mv.Accounts.User,
+          [email: Ash.CiString.new("passwordstoretest@example.com")],
+          domain: Mv.Accounts,
+          actor: system_actor
+        )
+
+      assert user.hashed_password != nil
+      refute is_nil(user.hashed_password)
+    end
+  end
+
+  describe "new user form - validation" do
+    test "shows error for duplicate email", %{conn: conn} do
+      _existing_user = create_test_user(%{email: "existing@example.com"})
+      {:ok, view, _html} = setup_live_view(conn, "/users/new")
+
+      html =
+        view
+        |> form("#user-form", user: %{email: "existing@example.com"})
+        |> render_submit()
+
+      assert html =~ "has already been taken"
+    end
+
+    test "shows error for short password", %{conn: conn} do
+      {:ok, view, _html} = setup_live_view(conn, "/users/new")
+
+      view |> element("input[name='set_password']") |> render_click()
+
+      html =
+        view
+        |> form("#user-form",
+          user: %{
+            email: "test@example.com",
+            password: "123",
+            password_confirmation: "123"
+          }
+        )
+        |> render_submit()
+
+      assert html =~ "length must be greater than or equal to 8"
+    end
   end
 
   describe "edit user form - display" do
-    test "shows correct form elements for existing user", %{conn: conn} do
+    @tag :ui
+    test "shows correct form elements and admin password fields", %{conn: conn} do
       user = create_test_user(%{email: "editme@example.com"})
       {:ok, view, html} = setup_live_view(conn, "/users/#{user.id}/edit")
 
+      # Basic form elements
       assert html =~ "Edit User"
       assert html =~ "Change Password"
       assert has_element?(view, "input[name='user[email]'][value='editme@example.com']")
       assert html =~ "Check 'Change Password' above to set a new password for this user"
+
+      # Toggle admin password fields
+      view |> element("input[name='set_password']") |> render_click()
+
+      # Admin password fields should be visible (no confirmation field for admin)
+      assert has_element?(view, "input[name='user[password]']")
+      refute has_element?(view, "input[name='user[password_confirmation]']")
+      assert render(view) =~ "Admin Note"
     end
   end
 
@@ -129,6 +215,46 @@ defmodule MvWeb.UserLive.FormTest do
     end
   end
 
+  describe "edit user form - validation" do
+    test "shows error for duplicate email", %{conn: conn} do
+      _existing_user = create_test_user(%{email: "taken@example.com"})
+      user_to_edit = create_test_user(%{email: "original@example.com"})
+      {:ok, view, _html} = setup_live_view(conn, "/users/#{user_to_edit.id}/edit")
+
+      html =
+        view
+        |> form("#user-form", user: %{email: "taken@example.com"})
+        |> render_submit()
+
+      assert html =~ "has already been taken"
+    end
+
+    test "shows error for invalid password", %{conn: conn} do
+      user = create_test_user(%{email: "user@example.com"})
+      {:ok, view, _html} = setup_live_view(conn, "/users/#{user.id}/edit")
+
+      view |> element("input[name='set_password']") |> render_click()
+
+      result =
+        view
+        |> form("#user-form",
+          user: %{
+            email: "user@example.com",
+            password: "123"
+          }
+        )
+        |> render_submit()
+
+      case result do
+        {:error, {:live_redirect, %{to: "/users"}}} ->
+          flunk("Expected validation error but form was submitted successfully")
+
+        html when is_binary(html) ->
+          assert html =~ "must have length of at least 8"
+      end
+    end
+  end
+
   describe "member linking - display" do
     test "shows linked member with unlink button when user has member", %{conn: conn} do
       system_actor = Mv.Helpers.SystemActor.get_system_actor()
@@ -259,6 +385,39 @@ defmodule MvWeb.UserLive.FormTest do
     end
   end
 
+  describe "internationalization" do
+    @tag :ui
+    test "shows translated labels in different locales", %{conn: conn} do
+      # Test German labels
+      conn = conn_with_oidc_user(conn, %{email: "admin_de@example.com"})
+      conn = Plug.Test.init_test_session(conn, locale: "de")
+      {:ok, _view, html_de} = live(conn, "/users/new")
+
+      assert html_de =~ "Neue*r Benutzer*in"
+      assert html_de =~ "E-Mail"
+      assert html_de =~ "Passwort setzen"
+
+      # Test English labels
+      conn = conn_with_oidc_user(conn, %{email: "admin_en@example.com"})
+      Gettext.put_locale(MvWeb.Gettext, "en")
+      {:ok, _view, html_en} = live(conn, "/users/new")
+
+      assert html_en =~ "New User"
+      assert html_en =~ "Email"
+      assert html_en =~ "Set Password"
+
+      # Test different labels for edit vs new
+      user = create_test_user(%{email: "test@example.com"})
+      conn = conn_with_oidc_user(conn, %{email: "admin@example.com"})
+
+      {:ok, _view, new_html} = live(conn, "/users/new")
+      {:ok, _view, edit_html} = live(conn, "/users/#{user.id}/edit")
+
+      assert new_html =~ "Set Password"
+      assert edit_html =~ "Change Password"
+    end
+  end
+
   describe "system actor user" do
     test "redirects to user list when editing system actor user", %{conn: conn} do
       system_actor = Mv.Helpers.SystemActor.get_system_actor()