test: restore removed tests including optimizations

test/mv_web/user_live/index_test.exs

@@ -3,17 +3,38 @@ defmodule MvWeb.UserLive.IndexTest do
   import Phoenix.LiveViewTest
 
   describe "basic functionality" do
-    @tag :slow
-    test "displays users in a table", %{conn: conn} do
+    @tag :ui
+    test "displays users in a table with basic UI elements", %{conn: conn} do
       # Create test users
-      _user1 = create_test_user(%{email: "alice@example.com", oidc_id: "alice123"})
+      user1 = create_test_user(%{email: "alice@example.com", oidc_id: "alice123"})
       _user2 = create_test_user(%{email: "bob@example.com", oidc_id: "bob456"})
 
       conn = conn_with_oidc_user(conn)
       {:ok, _view, html} = live(conn, "/users")
 
+      # Basic table rendering
       assert html =~ "alice@example.com"
       assert html =~ "bob@example.com"
+
+      # UI elements: New User button, action links
+      assert html =~ "New User"
+      assert html =~ "Edit"
+      assert html =~ "Delete"
+      assert html =~ ~r/href="[^"]*\/users\/#{user1.id}\/edit"/
+    end
+
+    @tag :ui
+    test "shows translated titles in different locales", %{conn: conn} do
+      # Test German translation
+      conn = conn_with_oidc_user(conn)
+      conn = Plug.Test.init_test_session(conn, locale: "de")
+      {:ok, _view, html_de} = live(conn, "/users")
+      assert html_de =~ "Benutzer*innen auflisten"
+
+      # Test English translation
+      Gettext.put_locale(MvWeb.Gettext, "en")
+      {:ok, _view, html_en} = live(conn, "/users")
+      assert html_en =~ "Listing Users"
     end
   end
 
@@ -68,6 +89,34 @@ defmodule MvWeb.UserLive.IndexTest do
       assert mike_pos < alpha_pos,
              "mike@example.com should appear before alpha@example.com when sorted desc"
     end
+
+    @tag :ui
+    test "toggles sort direction and shows correct icons", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/users")
+
+      # Initially ascending - should show up arrow
+      html = render(view)
+      assert html =~ "hero-chevron-up"
+
+      # After clicking, should show down arrow
+      view |> element("button[phx-value-field='email']") |> render_click()
+      html = render(view)
+      assert html =~ "hero-chevron-down"
+
+      # Click again to toggle back to ascending
+      html = view |> element("button[phx-value-field='email']") |> render_click()
+      assert html =~ "hero-chevron-up"
+      assert html =~ ~s(aria-sort="ascending")
+
+      # Should be back to original ascending order
+      alpha_pos = html |> :binary.match("alpha@example.com") |> elem(0)
+      mike_pos = html |> :binary.match("mike@example.com") |> elem(0)
+      zulu_pos = html |> :binary.match("zulu@example.com") |> elem(0)
+
+      assert alpha_pos < mike_pos, "Should be back to ascending: alpha before mike"
+      assert mike_pos < zulu_pos, "Should be back to ascending: mike before zulu"
+    end
   end
 
   describe "checkbox selection functionality" do
@@ -77,6 +126,102 @@ defmodule MvWeb.UserLive.IndexTest do
       %{users: [user1, user2]}
     end
 
+    @tag :ui
+    test "shows checkbox UI elements", %{conn: conn, users: [user1, user2]} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, _view, html} = live(conn, "/users")
+
+      # Check select all checkbox exists
+      assert html =~ ~s(name="select_all")
+      assert html =~ ~s(phx-click="select_all")
+
+      # Check individual user checkboxes exist
+      assert html =~ ~s(name="#{user1.id}")
+      assert html =~ ~s(name="#{user2.id}")
+      assert html =~ ~s(phx-click="select_user")
+    end
+
+    @tag :ui
+    test "can select and deselect individual users", %{conn: conn, users: [user1, user2]} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/users")
+
+      # Initially, individual checkboxes should exist but not be checked
+      assert view |> element("input[type='checkbox'][name='#{user1.id}']") |> has_element?()
+      assert view |> element("input[type='checkbox'][name='#{user2.id}']") |> has_element?()
+
+      refute view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+
+      # Select first user checkbox
+      html = view |> element("input[type='checkbox'][name='#{user1.id}']") |> render_click()
+      assert html =~ "Email"
+      assert html =~ to_string(user1.email)
+
+      # The select_all checkbox should still not be checked (not all users selected)
+      refute view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+
+      # Deselect user
+      html = view |> element("input[type='checkbox'][name='#{user1.id}']") |> render_click()
+      assert html =~ "Email"
+
+      refute view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+    end
+
+    @tag :ui
+    test "select all and deselect all functionality", %{conn: conn, users: [user1, user2]} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/users")
+
+      # Initially no checkboxes should be checked
+      refute view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+
+      refute view
+             |> element("input[type='checkbox'][name='#{user1.id}'][checked]")
+             |> has_element?()
+
+      refute view
+             |> element("input[type='checkbox'][name='#{user2.id}'][checked]")
+             |> has_element?()
+
+      # Click select all
+      html = view |> element("input[type='checkbox'][name='select_all']") |> render_click()
+
+      # After selecting all, the select_all checkbox should be checked
+      assert view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+
+      assert html =~ "Email"
+      assert html =~ to_string(user1.email)
+      assert html =~ to_string(user2.email)
+
+      # Then deselect all
+      html = view |> element("input[type='checkbox'][name='select_all']") |> render_click()
+
+      # After deselecting all, no checkboxes should be checked
+      refute view
+             |> element("input[type='checkbox'][name='select_all'][checked]")
+             |> has_element?()
+
+      refute view
+             |> element("input[type='checkbox'][name='#{user1.id}'][checked]")
+             |> has_element?()
+
+      refute view
+             |> element("input[type='checkbox'][name='#{user2.id}'][checked]")
+             |> has_element?()
+
+      assert html =~ "Email"
+    end
+
     @tag :slow
     test "select all automatically checks when all individual users are selected", %{
       conn: conn,
@@ -136,6 +281,43 @@ defmodule MvWeb.UserLive.IndexTest do
     end
   end
 
+  describe "navigation" do
+    @tag :ui
+    test "navigation links point to correct pages", %{conn: conn} do
+      user = create_test_user(%{email: "navigate@example.com"})
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, html} = live(conn, "/users")
+
+      # Check that user row contains link to show page
+      assert html =~ ~s(/users/#{user.id})
+
+      # Check edit link points to correct edit page
+      assert html =~ ~s(/users/#{user.id}/edit)
+
+      # Check new user button points to correct new page
+      assert html =~ ~s(/users/new)
+    end
+  end
+
+  describe "translations" do
+    @tag :ui
+    test "shows translations for selection in different locales", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+
+      # Test German translations
+      conn = Plug.Test.init_test_session(conn, locale: "de")
+      {:ok, _view, html_de} = live(conn, "/users")
+      assert html_de =~ "Alle Benutzer*innen auswählen"
+      assert html_de =~ "Benutzer*in auswählen"
+
+      # Test English translations
+      Gettext.put_locale(MvWeb.Gettext, "en")
+      {:ok, _view, html_en} = live(conn, "/users")
+      # Check that aria-label attributes exist (structure is there)
+      assert html_en =~ ~s(aria-label=)
+    end
+  end
+
   describe "edge cases" do
     test "handles empty user list gracefully", %{conn: conn} do
       # Don't create any users besides the authenticated one