Fix tests: Add missing actor parameters to Ash operations

This commit is contained in:
Moritz 2026-01-24 01:42:20 +01:00 committed by Simon
parent f993c64c42
commit 0e6b464e0a
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
5 changed files with 9 additions and 5 deletions

View file

@ -28,7 +28,7 @@ defmodule Mv.Authorization.ActorTest do
|> Ash.create(actor: actor)
# Load role
{:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts)
{:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts, actor: actor)
# Should return as-is (no additional load)
result = Actor.ensure_loaded(user_with_role)

View file

@ -16,6 +16,8 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
# Helper to create a membership fee type
defp create_fee_type(attrs) do
system_actor = Mv.Helpers.SystemActor.get_system_actor()
default_attrs = %{
name: "Test Fee Type #{System.unique_integer([:positive])}",
amount: Decimal.new("50.00"),
@ -26,7 +28,7 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
MembershipFeeType
|> Ash.Changeset.for_create(:create, attrs)
|> Ash.create!()
|> Ash.create!(actor: system_actor)
end
# Helper to create a member

View file

@ -79,7 +79,7 @@ defmodule MvWeb.RoleLive.ShowTest do
|> Ash.update(actor: actor)
# Load role for authorization checks (must be loaded for can?/3 to work)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts, actor: actor)
# Store user with role in session for LiveView
conn = conn_with_password_user(conn, user_with_role)

View file

@ -70,7 +70,7 @@ defmodule MvWeb.RoleLiveTest do
|> Ash.update(actor: actor)
# Load role for authorization checks (must be loaded for can?/3 to work)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts, actor: actor)
# Store user with role in session for LiveView
conn = conn_with_password_user(conn, user_with_role)

View file

@ -212,6 +212,8 @@ defmodule MvWeb.MemberLive.FormMembershipFeeTypeTest do
end
test "union/typed values roundtrip correctly", %{conn: conn, current_user: admin_user} do
system_actor = Mv.Helpers.SystemActor.get_system_actor()
# Create date custom field
custom_field =
Mv.Membership.CustomField
@ -220,7 +222,7 @@ defmodule MvWeb.MemberLive.FormMembershipFeeTypeTest do
value_type: :date,
required: false
})
|> Ash.create!()
|> Ash.create!(actor: system_actor)
fee_type = create_fee_type(%{interval: :yearly})