Add actor parameter to all tests requiring authorization
This commit adds actor: system_actor to all Ash operations in tests that require authorization.
This commit is contained in:
parent
686f69c9e9
commit
0f48a9b15a
GPG key ID:
1020A035E5DD0824
75 changed files with 4686 additions and 2859 deletions
|
|
@ -13,23 +13,28 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
|
||||
alias Mv.Membership.{CustomField, CustomFieldValue, Member}
|
||||
|
||||
setup do
|
||||
system_actor = Mv.Helpers.SystemActor.get_system_actor()
|
||||
%{actor: system_actor}
|
||||
end
|
||||
|
||||
describe "assigned_members_count calculation" do
|
||||
test "returns 0 for custom field without any values" do
|
||||
test "returns 0 for custom field without any values", %{actor: actor} do
|
||||
{:ok, custom_field} =
|
||||
CustomField
|
||||
|> Ash.Changeset.for_create(:create, %{
|
||||
name: "test_field",
|
||||
value_type: :string
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count)
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count, actor: actor)
|
||||
assert custom_field_with_count.assigned_members_count == 0
|
||||
end
|
||||
|
||||
test "returns correct count for custom field with one member" do
|
||||
{:ok, member} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "returns correct count for custom field with one member", %{actor: actor} do
|
||||
{:ok, member} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
{:ok, _custom_field_value} =
|
||||
CustomFieldValue
|
||||
|
|
@ -38,17 +43,17 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count)
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count, actor: actor)
|
||||
assert custom_field_with_count.assigned_members_count == 1
|
||||
end
|
||||
|
||||
test "returns correct count for custom field with multiple members" do
|
||||
{:ok, member1} = create_member()
|
||||
{:ok, member2} = create_member()
|
||||
{:ok, member3} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "returns correct count for custom field with multiple members", %{actor: actor} do
|
||||
{:ok, member1} = create_member(actor)
|
||||
{:ok, member2} = create_member(actor)
|
||||
{:ok, member3} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
# Create custom field value for each member
|
||||
for member <- [member1, member2, member3] do
|
||||
|
|
@ -59,16 +64,16 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
end
|
||||
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count)
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count, actor: actor)
|
||||
assert custom_field_with_count.assigned_members_count == 3
|
||||
end
|
||||
|
||||
test "counts distinct members (not multiple values per member)" do
|
||||
{:ok, member} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "counts distinct members (not multiple values per member)", %{actor: actor} do
|
||||
{:ok, member} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
# Create custom field value for member
|
||||
{:ok, _} =
|
||||
|
|
@ -78,9 +83,9 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count)
|
||||
custom_field_with_count = Ash.load!(custom_field, :assigned_members_count, actor: actor)
|
||||
|
||||
# Should still be 1, not 2, even if we tried to create multiple (which would fail due to uniqueness)
|
||||
assert custom_field_with_count.assigned_members_count == 1
|
||||
|
|
@ -88,9 +93,9 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
end
|
||||
|
||||
describe "prepare_deletion action" do
|
||||
test "loads assigned_members_count for deletion preparation" do
|
||||
{:ok, member} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "loads assigned_members_count for deletion preparation", %{actor: actor} do
|
||||
{:ok, member} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
{:ok, _} =
|
||||
CustomFieldValue
|
||||
|
|
@ -99,43 +104,43 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
# Use prepare_deletion action
|
||||
[prepared_custom_field] =
|
||||
CustomField
|
||||
|> Ash.Query.for_read(:prepare_deletion, %{id: custom_field.id})
|
||||
|> Ash.read!()
|
||||
|> Ash.read!(actor: actor)
|
||||
|
||||
assert prepared_custom_field.assigned_members_count == 1
|
||||
assert prepared_custom_field.id == custom_field.id
|
||||
end
|
||||
|
||||
test "returns empty list for non-existent custom field" do
|
||||
test "returns empty list for non-existent custom field", %{actor: actor} do
|
||||
non_existent_id = Ash.UUID.generate()
|
||||
|
||||
result =
|
||||
CustomField
|
||||
|> Ash.Query.for_read(:prepare_deletion, %{id: non_existent_id})
|
||||
|> Ash.read!()
|
||||
|> Ash.read!(actor: actor)
|
||||
|
||||
assert result == []
|
||||
end
|
||||
end
|
||||
|
||||
describe "destroy_with_values action" do
|
||||
test "deletes custom field without any values" do
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "deletes custom field without any values", %{actor: actor} do
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
assert :ok = Ash.destroy(custom_field)
|
||||
assert :ok = Ash.destroy(custom_field, actor: actor)
|
||||
|
||||
# Verify custom field is deleted
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field.id)
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field.id, actor: actor)
|
||||
end
|
||||
|
||||
test "deletes custom field and cascades to all its values" do
|
||||
{:ok, member} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "deletes custom field and cascades to all its values", %{actor: actor} do
|
||||
{:ok, member} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
{:ok, custom_field_value} =
|
||||
CustomFieldValue
|
||||
|
|
@ -144,25 +149,25 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
# Delete custom field
|
||||
assert :ok = Ash.destroy(custom_field)
|
||||
assert :ok = Ash.destroy(custom_field, actor: actor)
|
||||
|
||||
# Verify custom field is deleted
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field.id)
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field.id, actor: actor)
|
||||
|
||||
# Verify custom field value is also deleted (CASCADE)
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, custom_field_value.id)
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, custom_field_value.id, actor: actor)
|
||||
|
||||
# Verify member still exists
|
||||
assert {:ok, _} = Ash.get(Member, member.id)
|
||||
assert {:ok, _} = Ash.get(Member, member.id, actor: actor)
|
||||
end
|
||||
|
||||
test "deletes only values of the specific custom field" do
|
||||
{:ok, member} = create_member()
|
||||
{:ok, custom_field1} = create_custom_field("field1", :string)
|
||||
{:ok, custom_field2} = create_custom_field("field2", :string)
|
||||
test "deletes only values of the specific custom field", %{actor: actor} do
|
||||
{:ok, member} = create_member(actor)
|
||||
{:ok, custom_field1} = create_custom_field("field1", :string, actor)
|
||||
{:ok, custom_field2} = create_custom_field("field2", :string, actor)
|
||||
|
||||
# Create value for custom_field1
|
||||
{:ok, value1} =
|
||||
|
|
@ -172,7 +177,7 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field1.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "value1"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
# Create value for custom_field2
|
||||
{:ok, value2} =
|
||||
|
|
@ -182,25 +187,25 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field2.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "value2"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
# Delete custom_field1
|
||||
assert :ok = Ash.destroy(custom_field1)
|
||||
assert :ok = Ash.destroy(custom_field1, actor: actor)
|
||||
|
||||
# Verify custom_field1 and value1 are deleted
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field1.id)
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, value1.id)
|
||||
assert {:error, _} = Ash.get(CustomField, custom_field1.id, actor: actor)
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, value1.id, actor: actor)
|
||||
|
||||
# Verify custom_field2 and value2 still exist
|
||||
assert {:ok, _} = Ash.get(CustomField, custom_field2.id)
|
||||
assert {:ok, _} = Ash.get(CustomFieldValue, value2.id)
|
||||
assert {:ok, _} = Ash.get(CustomField, custom_field2.id, actor: actor)
|
||||
assert {:ok, _} = Ash.get(CustomFieldValue, value2.id, actor: actor)
|
||||
end
|
||||
|
||||
test "deletes custom field with values from multiple members" do
|
||||
{:ok, member1} = create_member()
|
||||
{:ok, member2} = create_member()
|
||||
{:ok, member3} = create_member()
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string)
|
||||
test "deletes custom field with values from multiple members", %{actor: actor} do
|
||||
{:ok, member1} = create_member(actor)
|
||||
{:ok, member2} = create_member(actor)
|
||||
{:ok, member3} = create_member(actor)
|
||||
{:ok, custom_field} = create_custom_field("test_field", :string, actor)
|
||||
|
||||
# Create value for each member
|
||||
values =
|
||||
|
|
@ -212,43 +217,43 @@ defmodule Mv.Membership.CustomFieldDeletionTest do
|
|||
custom_field_id: custom_field.id,
|
||||
value: %{"_union_type" => "string", "_union_value" => "test"}
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
|
||||
value
|
||||
end
|
||||
|
||||
# Delete custom field
|
||||
assert :ok = Ash.destroy(custom_field)
|
||||
assert :ok = Ash.destroy(custom_field, actor: actor)
|
||||
|
||||
# Verify all values are deleted
|
||||
for value <- values do
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, value.id)
|
||||
assert {:error, _} = Ash.get(CustomFieldValue, value.id, actor: actor)
|
||||
end
|
||||
|
||||
# Verify all members still exist
|
||||
for member <- [member1, member2, member3] do
|
||||
assert {:ok, _} = Ash.get(Member, member.id)
|
||||
assert {:ok, _} = Ash.get(Member, member.id, actor: actor)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
# Helper functions
|
||||
defp create_member do
|
||||
defp create_member(actor) do
|
||||
Member
|
||||
|> Ash.Changeset.for_create(:create_member, %{
|
||||
first_name: "Test",
|
||||
last_name: "User#{System.unique_integer([:positive])}",
|
||||
email: "test#{System.unique_integer([:positive])}@example.com"
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
end
|
||||
|
||||
defp create_custom_field(name, value_type) do
|
||||
defp create_custom_field(name, value_type, actor) do
|
||||
CustomField
|
||||
|> Ash.Changeset.for_create(:create, %{
|
||||
name: "#{name}_#{System.unique_integer([:positive])}",
|
||||
value_type: value_type
|
||||
})
|
||||
|> Ash.create()
|
||||
|> Ash.create(actor: actor)
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue