Add actor parameter to all tests requiring authorization

This commit adds actor: system_actor to all Ash operations in tests that
require authorization.

test/membership/custom_field_validation_test.exs

@@ -13,8 +13,13 @@ defmodule Mv.Membership.CustomFieldValidationTest do
 
   alias Mv.Membership.CustomField
 
+  setup do
+    system_actor = Mv.Helpers.SystemActor.get_system_actor()
+    %{actor: system_actor}
+  end
+
   describe "name validation" do
-    test "accepts name with exactly 100 characters" do
+    test "accepts name with exactly 100 characters", %{actor: actor} do
       name = String.duplicate("a", 100)
 
       assert {:ok, custom_field} =
@@ -23,13 +28,13 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  name: name,
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert custom_field.name == name
       assert String.length(custom_field.name) == 100
     end
 
-    test "rejects name with 101 characters" do
+    test "rejects name with 101 characters", %{actor: actor} do
       name = String.duplicate("a", 101)
 
       assert {:error, changeset} =
@@ -38,50 +43,50 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  name: name,
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert [%{field: :name, message: message}] = changeset.errors
       assert message =~ "max" or message =~ "length" or message =~ "100"
     end
 
-    test "trims whitespace from name" do
+    test "trims whitespace from name", %{actor: actor} do
       assert {:ok, custom_field} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  name: "  test_field  ",
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert custom_field.name == "test_field"
     end
 
-    test "rejects empty name" do
+    test "rejects empty name", %{actor: actor} do
       assert {:error, changeset} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  name: "",
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert Enum.any?(changeset.errors, fn error -> error.field == :name end)
     end
 
-    test "rejects nil name" do
+    test "rejects nil name", %{actor: actor} do
       assert {:error, changeset} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert Enum.any?(changeset.errors, fn error -> error.field == :name end)
     end
   end
 
   describe "description validation" do
-    test "accepts description with exactly 500 characters" do
+    test "accepts description with exactly 500 characters", %{actor: actor} do
       description = String.duplicate("a", 500)
 
       assert {:ok, custom_field} =
@@ -91,13 +96,13 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  value_type: :string,
                  description: description
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert custom_field.description == description
       assert String.length(custom_field.description) == 500
     end
 
-    test "rejects description with 501 characters" do
+    test "rejects description with 501 characters", %{actor: actor} do
       description = String.duplicate("a", 501)
 
       assert {:error, changeset} =
@@ -107,13 +112,13 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  value_type: :string,
                  description: description
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert [%{field: :description, message: message}] = changeset.errors
       assert message =~ "max" or message =~ "length" or message =~ "500"
     end
 
-    test "trims whitespace from description" do
+    test "trims whitespace from description", %{actor: actor} do
       assert {:ok, custom_field} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
@@ -121,24 +126,24 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  value_type: :string,
                  description: "  A nice description  "
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert custom_field.description == "A nice description"
     end
 
-    test "accepts nil description (optional field)" do
+    test "accepts nil description (optional field)", %{actor: actor} do
       assert {:ok, custom_field} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  name: "test_field",
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert custom_field.description == nil
     end
 
-    test "accepts empty description after trimming" do
+    test "accepts empty description after trimming", %{actor: actor} do
       assert {:ok, custom_field} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
@@ -146,7 +151,7 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  value_type: :string,
                  description: "   "
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       # After trimming whitespace, becomes nil (empty strings are converted to nil)
       assert custom_field.description == nil
@@ -154,14 +159,14 @@ defmodule Mv.Membership.CustomFieldValidationTest do
   end
 
   describe "name uniqueness" do
-    test "rejects duplicate names" do
+    test "rejects duplicate names", %{actor: actor} do
       assert {:ok, _} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  name: "unique_field",
                  value_type: :string
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert {:error, changeset} =
                CustomField
@@ -169,14 +174,14 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                  name: "unique_field",
                  value_type: :integer
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert Enum.any?(changeset.errors, fn error -> error.field == :name end)
     end
   end
 
   describe "value_type validation" do
-    test "accepts all valid value types" do
+    test "accepts all valid value types", %{actor: actor} do
       for value_type <- [:string, :integer, :boolean, :date, :email] do
         assert {:ok, custom_field} =
                  CustomField
@@ -184,20 +189,20 @@ defmodule Mv.Membership.CustomFieldValidationTest do
                    name: "field_#{value_type}",
                    value_type: value_type
                  })
-                 |> Ash.create()
+                 |> Ash.create(actor: actor)
 
         assert custom_field.value_type == value_type
       end
     end
 
-    test "rejects invalid value type" do
+    test "rejects invalid value type", %{actor: actor} do
       assert {:error, changeset} =
                CustomField
                |> Ash.Changeset.for_create(:create, %{
                  name: "invalid_field",
                  value_type: :invalid_type
                })
-               |> Ash.create()
+               |> Ash.create(actor: actor)
 
       assert [%{field: :value_type}] = changeset.errors
     end