local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 66 Pull requests 6 Projects 3 Releases Packages 1 Activity Actions

Add actor parameter to all tests requiring authorization

Browse source 
This commit adds actor: system_actor to all Ash operations in tests that
require authorization.
This commit is contained in:
Moritz 2026-01-23 20:00:24 +01:00
parent 686f69c9e9
commit 0f48a9b15a
Signed by: moritz
GPG key ID: 1020A035E5DD0824
75 changed files with 4686 additions and 2859 deletions
Download patch file Download diff file Expand all files Collapse all files

21
test/membership/membership_fee_settings_test.exs
View file

@ -7,6 +7,11 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
alias Mv.Membership.Setting
alias Mv.MembershipFees.MembershipFeeType
setup do
system_actor = Mv.Helpers.SystemActor.get_system_actor()
%{actor: system_actor}
end
describe "membership fee settings" do
test "default values are correct" do
{:ok, settings} = Mv.Membership.get_settings()
@ -18,7 +23,7 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
assert %Setting{} = settings
end
test "settings can be written via update_membership_fee_settings" do
test "settings can be written via update_membership_fee_settings", %{actor: actor} do
{:ok, settings} = Mv.Membership.get_settings()
{:ok, updated} =
@ -26,12 +31,12 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
|> Ash.Changeset.for_update(:update_membership_fee_settings, %{
include_joining_cycle: false
})
|> Ash.update()
|> Ash.update(actor: actor)
assert updated.include_joining_cycle == false
end
test "default_membership_fee_type_id can be nil (optional)" do
test "default_membership_fee_type_id can be nil (optional)", %{actor: actor} do
{:ok, settings} = Mv.Membership.get_settings()
{:ok, updated} =
@ -39,12 +44,12 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
|> Ash.Changeset.for_update(:update_membership_fee_settings, %{
default_membership_fee_type_id: nil
})
|> Ash.update()
|> Ash.update(actor: actor)
assert updated.default_membership_fee_type_id == nil
end
test "default_membership_fee_type_id validation: must exist if set" do
test "default_membership_fee_type_id validation: must exist if set", %{actor: actor} do
{:ok, settings} = Mv.Membership.get_settings()
# Create a valid fee type
@ -61,12 +66,12 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
|> Ash.Changeset.for_update(:update_membership_fee_settings, %{
default_membership_fee_type_id: fee_type.id
})
|> Ash.update()
|> Ash.update(actor: actor)
assert updated.default_membership_fee_type_id == fee_type.id
end
test "default_membership_fee_type_id validation: fails if not found" do
test "default_membership_fee_type_id validation: fails if not found", %{actor: actor} do
{:ok, settings} = Mv.Membership.get_settings()
# Use a non-existent UUID
@ -77,7 +82,7 @@ defmodule Mv.Membership.MembershipFeeSettingsTest do
|> Ash.Changeset.for_update(:update_membership_fee_settings, %{
default_membership_fee_type_id: fake_uuid
})
|> Ash.update()
|> Ash.update(actor: actor)
assert error_on_field?(error, :default_membership_fee_type_id)
end