local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 60 Pull requests 3 Projects 2 Releases Packages 1 Activity Actions

fix: treat URL with only custom fields as valid in ?fields= mode
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/promote/production Build is passing
Details

Browse source 
Consider visible custom fields in compute_final_field_selection so that
a link with only custom_field_X is not wrongly treated as invalid and
reverted to session/global. Add test for URL containing only custom field.
This commit is contained in:
Moritz 2026-02-24 09:42:10 +01:00
parent d5df2338a7
commit 10ad32eb6f
Signed by: moritz
GPG key ID: 1020A035E5DD0824
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/mv_web/live/member_live/index.ex
View file

@ -821,9 +821,10 @@ defmodule MvWeb.MemberLive.Index do
only_url =
FieldVisibility.selection_from_url_only(url_selection, socket.assigns.all_custom_fields)
visible = FieldVisibility.get_visible_member_fields(only_url)
visible_members = FieldVisibility.get_visible_member_fields(only_url)
visible_custom = FieldVisibility.get_visible_custom_fields(only_url)
if visible == [] do
if visible_members == [] and visible_custom == [] do
# URL had only invalid field names; fall back to session + global.
compute_final_field_selection(false, url_selection, socket)
else