Refactor column visibility logic

test/membership/member_field_visibility_test.exs

@@ -11,70 +11,4 @@ defmodule Mv.Membership.MemberFieldVisibilityTest do
   use Mv.DataCase, async: true
 
   alias Mv.Membership.Member
-
-  describe "show_in_overview?/1" do
-    test "returns true for all member fields by default" do
-      # When no settings exist or member_field_visibility is not configured
-      # Test with fields from constants
-      member_fields = Mv.Constants.member_fields()
-
-      Enum.each(member_fields, fn field ->
-        assert Member.show_in_overview?(field) == true,
-               "Field #{field} should be visible by default"
-      end)
-    end
-
-    test "returns false for fields with show_in_overview: false in settings" do
-      # Get or create settings
-      {:ok, settings} = Mv.Membership.get_settings()
-
-      # Use a field that exists in member fields
-      member_fields = Mv.Constants.member_fields()
-      field_to_hide = List.first(member_fields)
-      field_to_show = List.last(member_fields)
-
-      # Update settings to hide a field
-      {:ok, _updated_settings} =
-        Mv.Membership.update_settings(settings, %{
-          member_field_visibility: %{field_to_hide => false}
-        })
-
-      # JSONB may convert atom keys to string keys, so we check via show_in_overview? instead
-      assert Member.show_in_overview?(field_to_hide) == false
-      assert Member.show_in_overview?(field_to_show) == true
-    end
-
-    test "returns true for non-configured fields (default)" do
-      # Get or create settings
-      {:ok, settings} = Mv.Membership.get_settings()
-
-      # Use fields that exist in member fields
-      member_fields = Mv.Constants.member_fields()
-      fields_to_hide = Enum.take(member_fields, 2)
-      fields_to_show = Enum.take(member_fields, -2)
-
-      # Update settings to hide some fields
-      visibility_config =
-        Enum.reduce(fields_to_hide, %{}, fn field, acc ->
-          Map.put(acc, field, false)
-        end)
-
-      {:ok, _updated_settings} =
-        Mv.Membership.update_settings(settings, %{
-          member_field_visibility: visibility_config
-        })
-
-      # Hidden fields should be false
-      Enum.each(fields_to_hide, fn field ->
-        assert Member.show_in_overview?(field) == false,
-               "Field #{field} should be hidden"
-      end)
-
-      # Unconfigured fields should still be true (default)
-      Enum.each(fields_to_show, fn field ->
-        assert Member.show_in_overview?(field) == true,
-               "Field #{field} should be visible by default"
-      end)
-    end
-  end
 end

test/mv_web/member_live/index_member_fields_display_test.exs

@@ -51,7 +51,7 @@ defmodule MvWeb.MemberLive.IndexMemberFieldsDisplayTest do
 
     {:ok, _} =
       Mv.Membership.update_settings(settings, %{
-        member_field_visibility: Map.new(fields_to_hide, &{&1, false})
+        member_field_visibility: Map.new(fields_to_hide, &{Atom.to_string(&1), false})
       })
 
     conn = conn_with_oidc_user(conn)