test: add tests for user-member linking and fuzzy search (#168)

test/accounts/user_member_linking_email_test.exs

@@ -0,0 +1,169 @@
+defmodule Mv.Accounts.UserMemberLinkingEmailTest do
+  @moduledoc """
+  Tests email validation during user-member linking.
+  Implements rules from docs/email-sync.md.
+  Tests for Issue #168, specifically Problem #4: Email validation bug.
+  """
+
+  use Mv.DataCase, async: false
+
+  alias Mv.Accounts
+  alias Mv.Membership
+
+  describe "link with same email" do
+    test "succeeds when user.email == member.email" do
+      # Create member with specific email
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Alice",
+          last_name: "Johnson",
+          email: "alice@example.com"
+        })
+
+      # Create user with same email and link to member
+      result =
+        Accounts.create_user(%{
+          email: "alice@example.com",
+          member: %{id: member.id}
+        })
+
+      # Should succeed without errors
+      assert {:ok, user} = result
+      assert to_string(user.email) == "alice@example.com"
+
+      # Reload to verify link
+      user = Ash.load!(user, [:member], domain: Mv.Accounts)
+      assert user.member.id == member.id
+      assert user.member.email == "alice@example.com"
+    end
+
+    test "no validation error triggered when updating linked pair with same email" do
+      # Create member
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Bob",
+          last_name: "Smith",
+          email: "bob@example.com"
+        })
+
+      # Create user and link
+      {:ok, user} =
+        Accounts.create_user(%{
+          email: "bob@example.com",
+          member: %{id: member.id}
+        })
+
+      # Update user (should not trigger email validation error)
+      result = Accounts.update_user(user, %{email: "bob@example.com"})
+
+      assert {:ok, updated_user} = result
+      assert to_string(updated_user.email) == "bob@example.com"
+    end
+  end
+
+  describe "link with different emails" do
+    test "fails if member.email is used by a DIFFERENT linked user" do
+      # Create first user and link to a different member
+      {:ok, other_member} =
+        Membership.create_member(%{
+          first_name: "Other",
+          last_name: "Member",
+          email: "other@example.com"
+        })
+
+      {:ok, _user1} =
+        Accounts.create_user(%{
+          email: "user1@example.com",
+          member: %{id: other_member.id}
+        })
+
+      # Reload to ensure email sync happened
+      _other_member = Ash.reload!(other_member)
+
+      # Create a NEW member with different email
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Charlie",
+          last_name: "Brown",
+          email: "charlie@example.com"
+        })
+
+      # Try to create user2 with email that matches the linked other_member
+      result =
+        Accounts.create_user(%{
+          email: "user1@example.com",
+          member: %{id: member.id}
+        })
+
+      # Should fail because user1@example.com is already used by other_member (which is linked to user1)
+      assert {:error, _error} = result
+    end
+
+    test "succeeds for unique emails" do
+      # Create member
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "David",
+          last_name: "Wilson",
+          email: "david@example.com"
+        })
+
+      # Create user with different but unique email
+      result =
+        Accounts.create_user(%{
+          email: "user@example.com",
+          member: %{id: member.id}
+        })
+
+      # Should succeed
+      assert {:ok, user} = result
+
+      # Email sync should update member's email to match user's
+      user = Ash.load!(user, [:member], domain: Mv.Accounts)
+      assert user.member.email == "user@example.com"
+    end
+  end
+
+  describe "edge cases" do
+    test "unlinking and relinking with same email works (Problem #4)" do
+      # This is the exact scenario from Problem #4:
+      # 1. Link user and member (both have same email)
+      # 2. Unlink them (member keeps the email)
+      # 3. Try to relink (validation should NOT fail)
+
+      # Create member
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Emma",
+          last_name: "Davis",
+          email: "emma@example.com"
+        })
+
+      # Create user and link
+      {:ok, user} =
+        Accounts.create_user(%{
+          email: "emma@example.com",
+          member: %{id: member.id}
+        })
+
+      # Verify they are linked
+      user = Ash.load!(user, [:member], domain: Mv.Accounts)
+      assert user.member.id == member.id
+      assert user.member.email == "emma@example.com"
+
+      # Unlink
+      {:ok, unlinked_user} = Accounts.update_user(user, %{member: nil})
+      assert is_nil(unlinked_user.member_id)
+
+      # Member still has the email after unlink
+      member = Ash.reload!(member)
+      assert member.email == "emma@example.com"
+
+      # Relink (should work - this is Problem #4)
+      result = Accounts.update_user(unlinked_user, %{member: %{id: member.id}})
+
+      assert {:ok, relinked_user} = result
+      assert relinked_user.member_id == member.id
+    end
+  end
+end

test/accounts/user_member_linking_test.exs

@@ -0,0 +1,130 @@
+defmodule Mv.Accounts.UserMemberLinkingTest do
+  @moduledoc """
+  Integration tests for User-Member linking functionality.
+
+  Tests the complete workflow of linking and unlinking members to users,
+  including email synchronization and validation rules.
+  """
+  use Mv.DataCase, async: false
+  alias Mv.Accounts
+  alias Mv.Membership
+
+  describe "User-Member Linking with Email Sync" do
+    test "link user to member with different email syncs member email" do
+      # Create user with one email
+      {:ok, user} = Accounts.create_user(%{email: "user@example.com"})
+
+      # Create member with different email
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "John",
+          last_name: "Doe",
+          email: "member@example.com"
+        })
+
+      # Link user to member
+      {:ok, updated_user} = Accounts.update_user(user, %{member: %{id: member.id}})
+
+      # Verify link exists
+      user_with_member = Ash.get!(Mv.Accounts.User, updated_user.id, load: [:member])
+      assert user_with_member.member.id == member.id
+
+      # Verify member email was synced to match user email
+      synced_member = Ash.get!(Mv.Membership.Member, member.id)
+      assert synced_member.email == "user@example.com"
+    end
+
+    test "unlink member from user sets member to nil" do
+      # Create and link user and member
+      {:ok, user} = Accounts.create_user(%{email: "user@example.com"})
+
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Jane",
+          last_name: "Smith",
+          email: "jane@example.com"
+        })
+
+      {:ok, linked_user} = Accounts.update_user(user, %{member: %{id: member.id}})
+
+      # Verify link exists
+      user_with_member = Ash.get!(Mv.Accounts.User, linked_user.id, load: [:member])
+      assert user_with_member.member.id == member.id
+
+      # Unlink by setting member to nil
+      {:ok, unlinked_user} = Accounts.update_user(linked_user, %{member: nil})
+
+      # Verify link is removed
+      user_without_member = Ash.get!(Mv.Accounts.User, unlinked_user.id, load: [:member])
+      assert is_nil(user_without_member.member)
+
+      # Verify member still exists independently
+      member_still_exists = Ash.get!(Mv.Membership.Member, member.id)
+      assert member_still_exists.id == member.id
+    end
+
+    test "cannot link member already linked to another user" do
+      # Create first user and link to member
+      {:ok, user1} = Accounts.create_user(%{email: "user1@example.com"})
+
+      {:ok, member} =
+        Membership.create_member(%{
+          first_name: "Bob",
+          last_name: "Wilson",
+          email: "bob@example.com"
+        })
+
+      {:ok, _linked_user1} = Accounts.update_user(user1, %{member: %{id: member.id}})
+
+      # Create second user and try to link to same member
+      {:ok, user2} = Accounts.create_user(%{email: "user2@example.com"})
+
+      # Should fail because member is already linked
+      assert {:error, %Ash.Error.Invalid{}} =
+               Accounts.update_user(user2, %{member: %{id: member.id}})
+    end
+
+    test "cannot change member link directly, must unlink first" do
+      # Create user and link to first member
+      {:ok, user} = Accounts.create_user(%{email: "user@example.com"})
+
+      {:ok, member1} =
+        Membership.create_member(%{
+          first_name: "Alice",
+          last_name: "Johnson",
+          email: "alice@example.com"
+        })
+
+      {:ok, linked_user} = Accounts.update_user(user, %{member: %{id: member1.id}})
+
+      # Create second member
+      {:ok, member2} =
+        Membership.create_member(%{
+          first_name: "Charlie",
+          last_name: "Brown",
+          email: "charlie@example.com"
+        })
+
+      # Try to directly change member link (should fail)
+      assert {:error, %Ash.Error.Invalid{errors: errors}} =
+               Accounts.update_user(linked_user, %{member: %{id: member2.id}})
+
+      # Verify error message mentions "Remove existing member first"
+      error_messages = Enum.map(errors, & &1.message)
+      assert Enum.any?(error_messages, &String.contains?(&1, "Remove existing member first"))
+
+      # Two-step process: first unlink, then link new member
+      {:ok, unlinked_user} = Accounts.update_user(linked_user, %{member: nil})
+
+      # After unlinking, member1 still has the user's email
+      # Change member1's email to avoid conflict when relinking to member2
+      {:ok, _} = Membership.update_member(member1, %{email: "alice_changed@example.com"})
+
+      {:ok, relinked_user} = Accounts.update_user(unlinked_user, %{member: %{id: member2.id}})
+
+      # Verify new link is established
+      user_with_new_member = Ash.get!(Mv.Accounts.User, relinked_user.id, load: [:member])
+      assert user_with_new_member.member.id == member2.id
+    end
+  end
+end