test(membership-fees): share create_fee_type and create_cycle fixtures

Replace the create_fee_type/create_cycle helpers duplicated across 18/8
membership-fee test files with a single shared definition in Mv.Fixtures,
reconciling the divergent local signatures (including the reversed
argument order) into one superset so behavior is unchanged.

test/membership_fees/changes/validate_same_interval_test.exs

@@ -4,29 +4,15 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
   """
   use Mv.DataCase, async: true
 
+  import Mv.Fixtures, only: [create_fee_type: 2]
+
   alias Mv.MembershipFees.Changes.ValidateSameInterval
-  alias Mv.MembershipFees.MembershipFeeType
 
   setup do
     system_actor = Mv.Helpers.SystemActor.get_system_actor()
     %{actor: system_actor}
   end
 
-  # Helper to create a membership fee type
-  defp create_fee_type(attrs, actor) do
-    default_attrs = %{
-      name: "Test Fee Type #{System.unique_integer([:positive])}",
-      amount: Decimal.new("50.00"),
-      interval: :yearly
-    }
-
-    attrs = Map.merge(default_attrs, attrs)
-
-    MembershipFeeType
-    |> Ash.Changeset.for_create(:create, attrs)
-    |> Ash.create!(actor: actor)
-  end
-
   # Helper to create a member
   defp create_member(attrs, actor) do
     default_attrs = %{

test/membership_fees/member_cycle_integration_test.exs

@@ -4,8 +4,9 @@ defmodule Mv.MembershipFees.MemberCycleIntegrationTest do
   """
   use Mv.DataCase, async: false
 
+  import Mv.Fixtures, only: [create_fee_type: 2]
+
   alias Mv.MembershipFees.MembershipFeeCycle
-  alias Mv.MembershipFees.MembershipFeeType
 
   require Ash.Query
 
@@ -14,21 +15,6 @@ defmodule Mv.MembershipFees.MemberCycleIntegrationTest do
     %{actor: system_actor}
   end
 
-  # Helper to create a membership fee type
-  defp create_fee_type(attrs, actor) do
-    default_attrs = %{
-      name: "Test Fee Type #{System.unique_integer([:positive])}",
-      amount: Decimal.new("50.00"),
-      interval: :yearly
-    }
-
-    attrs = Map.merge(default_attrs, attrs)
-
-    MembershipFeeType
-    |> Ash.Changeset.for_create(:create, attrs)
-    |> Ash.create!(actor: actor)
-  end
-
   # Helper to set up settings
   defp setup_settings(include_joining_cycle, actor) do
     {:ok, settings} = Mv.Membership.get_settings()

test/membership_fees/membership_fee_cycle_test.exs

@@ -4,29 +4,15 @@ defmodule Mv.MembershipFees.MembershipFeeCycleTest do
   """
   use Mv.DataCase, async: true
 
+  import Mv.Fixtures, only: [create_fee_type: 2, create_cycle: 4]
+
   alias Mv.MembershipFees.MembershipFeeCycle
-  alias Mv.MembershipFees.MembershipFeeType
 
   setup do
     system_actor = Mv.Helpers.SystemActor.get_system_actor()
     %{actor: system_actor}
   end
 
-  # Helper to create a membership fee type
-  defp create_fee_type(attrs, actor) do
-    default_attrs = %{
-      name: "Test Fee Type #{System.unique_integer([:positive])}",
-      amount: Decimal.new("50.00"),
-      interval: :yearly
-    }
-
-    attrs = Map.merge(default_attrs, attrs)
-
-    MembershipFeeType
-    |> Ash.Changeset.for_create(:create, attrs)
-    |> Ash.create!(actor: actor)
-  end
-
   # Helper to create a member
   defp create_member(attrs, actor) do
     default_attrs = %{
@@ -40,22 +26,6 @@ defmodule Mv.MembershipFees.MembershipFeeCycleTest do
     member
   end
 
-  # Helper to create a cycle
-  defp create_cycle(member, fee_type, attrs, actor) do
-    default_attrs = %{
-      cycle_start: ~D[2024-01-01],
-      amount: Decimal.new("50.00"),
-      member_id: member.id,
-      membership_fee_type_id: fee_type.id
-    }
-
-    attrs = Map.merge(default_attrs, attrs)
-
-    MembershipFeeCycle
-    |> Ash.Changeset.for_create(:create, attrs)
-    |> Ash.create!(actor: actor)
-  end
-
   describe "status defaults" do
     test "status defaults to :unpaid when creating a cycle", %{actor: actor} do
       fee_type = create_fee_type(%{interval: :yearly}, actor)

test/membership_fees/membership_fee_type_integration_test.exs

@@ -4,6 +4,8 @@ defmodule Mv.MembershipFees.MembershipFeeTypeIntegrationTest do
   """
   use Mv.DataCase, async: false
 
+  import Mv.Fixtures, only: [create_fee_type: 2]
+
   alias Mv.Membership.Member
   alias Mv.MembershipFees.MembershipFeeCycle
   alias Mv.MembershipFees.MembershipFeeType
@@ -15,21 +17,6 @@ defmodule Mv.MembershipFees.MembershipFeeTypeIntegrationTest do
     %{actor: system_actor}
   end
 
-  # Helper to create a membership fee type
-  defp create_fee_type(attrs, actor) do
-    default_attrs = %{
-      name: "Test Fee Type #{System.unique_integer([:positive])}",
-      amount: Decimal.new("50.00"),
-      interval: :yearly
-    }
-
-    attrs = Map.merge(default_attrs, attrs)
-
-    MembershipFeeType
-    |> Ash.Changeset.for_create(:create, attrs)
-    |> Ash.create!(actor: actor)
-  end
-
   describe "admin can create membership fee type" do
     test "creates type with all fields", %{actor: actor} do
       attrs = %{