local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 57 Pull requests 6 Projects 1 Releases Packages 1 Activity Actions

fix: simplify JSONB extraction - remove redundant operators

Browse source 
- Replace 4 LIKE checks with 2 in build_custom_field_filter
- Simplify CASE blocks in migration trigger functions
- ->> operator always returns text, no need for -> + ::text fallback
- Performance improvement: 50% fewer LIKE operations
This commit is contained in:
Moritz 2025-12-11 13:33:52 +01:00
parent 014ef04853
commit 265e976d94
Signed by: moritz
GPG key ID: 1020A035E5DD0824
2 changed files with 11 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

53
priv/repo/migrations/20251204123714_add_custom_field_values_to_search_vector.exs
View file

@ -20,23 +20,11 @@ defmodule Mv.Repo.Migrations.AddCustomFieldValuesToSearchVector do
BEGIN
-- Aggregate all custom field values for this member
-- Support both formats: _union_type/_union_value (Ash format) and type/value (legacy)
-- Extract value as text: handle both string and numeric values correctly
-- ->> operator always returns TEXT directly (no need for -> + ::text fallback)
SELECT string_agg(
CASE
-- Try _union_value first (Ash format)
WHEN value ? '_union_value' THEN
-- For strings: value->>'_union_value' returns text directly
-- For numbers/booleans: value->'_union_value' returns JSONB, then ::text converts it
COALESCE(
NULLIF(value->>'_union_value', ''),
(value->'_union_value')::text
)
-- Fallback to value (legacy format)
WHEN value ? 'value' THEN
COALESCE(
NULLIF(value->>'value', ''),
(value->'value')::text
)
WHEN value ? '_union_value' THEN value->>'_union_value'
WHEN value ? 'value' THEN value->>'value'
ELSE ''
END,
' '
@ -94,20 +82,17 @@ defmodule Mv.Repo.Migrations.AddCustomFieldValuesToSearchVector do
-- If value hasn't changed, we can skip the expensive re-aggregation
IF TG_OP = 'UPDATE' THEN
-- Extract OLD value for comparison (handle both JSONB formats)
-- ->> operator always returns TEXT directly
old_value_text := COALESCE(
NULLIF(OLD.value->>'_union_value', ''),
(OLD.value->'_union_value')::text,
NULLIF(OLD.value->>'value', ''),
(OLD.value->'value')::text,
''
);
-- Extract NEW value for comparison (handle both JSONB formats)
new_value_text := COALESCE(
NULLIF(NEW.value->>'_union_value', ''),
(NEW.value->'_union_value')::text,
NULLIF(NEW.value->>'value', ''),
(NEW.value->'value')::text,
''
);
@ -150,21 +135,11 @@ defmodule Mv.Repo.Migrations.AddCustomFieldValuesToSearchVector do
-- Aggregate all custom field values for this member
-- Support both formats: _union_type/_union_value (Ash format) and type/value (legacy)
-- Extract value as text: handle both string and numeric values correctly
-- ->> operator always returns TEXT directly
SELECT string_agg(
CASE
-- Try _union_value first (Ash format)
WHEN value ? '_union_value' THEN
COALESCE(
NULLIF(value->>'_union_value', ''),
(value->'_union_value')::text
)
-- Fallback to value (legacy format)
WHEN value ? 'value' THEN
COALESCE(
NULLIF(value->>'value', ''),
(value->'value')::text
)
WHEN value ? '_union_value' THEN value->>'_union_value'
WHEN value ? 'value' THEN value->>'value'
ELSE ''
END,
' '
@ -221,18 +196,8 @@ defmodule Mv.Repo.Migrations.AddCustomFieldValuesToSearchVector do
setweight(to_tsvector('simple', coalesce(
(SELECT string_agg(
CASE
-- Try _union_value first (Ash format)
WHEN value ? '_union_value' THEN
COALESCE(
NULLIF(value->>'_union_value', ''),
(value->'_union_value')::text
)
-- Fallback to value (legacy format)
WHEN value ? 'value' THEN
COALESCE(
NULLIF(value->>'value', ''),
(value->'value')::text
)
WHEN value ? '_union_value' THEN value->>'_union_value'
WHEN value ? 'value' THEN value->>'value'
ELSE ''
END,
' '