Merge branch 'main' into feature/308-web-form

test/membership/custom_field_slug_test.exs

@@ -192,21 +192,5 @@ defmodule Mv.Membership.CustomFieldSlugTest do
     end
   end
 
-  describe "slug-based lookup (future feature)" do
-    @tag :skip
-    test "can find custom field by slug", %{actor: actor} do
-      {:ok, custom_field} =
-        CustomField
-        |> Ash.Changeset.for_create(:create, %{
-          name: "Test Field",
-          value_type: :string
-        })
-        |> Ash.create(actor: actor)
-
-      # This test is for future implementation
-      # We might add a custom action like :by_slug
-      found = Ash.get!(CustomField, custom_field.slug, load: [:slug], actor: actor)
-      assert found.id == custom_field.id
-    end
-  end
+  # Slug-based lookup (e.g. CustomField by slug) is not implemented; primary read uses ID.
 end

test/mv_web/live/group_live/show_authorization_test.exs

@@ -248,16 +248,6 @@ defmodule MvWeb.GroupLive.ShowAuthorizationTest do
                match?({:error, {:live_redirect, %{to: "/groups"}}}, result)
     end
 
-    @tag :skip
-    test "non-existent member IDs are handled", %{conn: conn} do
-      # Future: test add_selected_members with invalid ID (would require pushing event with forged selected_member_ids)
-      group = Fixtures.group_fixture()
-
-      {:ok, view, _html} = live(conn, "/groups/#{group.slug}")
-
-      assert has_element?(view, "button", "Add Member")
-    end
-
     test "non-existent group IDs are handled", %{conn: conn} do
       # Accessing non-existent group should redirect
       non_existent_slug = "non-existent-group-#{System.unique_integer([:positive])}"

test/mv_web/live/profile_navigation_test.exs

@@ -60,17 +60,22 @@ defmodule MvWeb.ProfileNavigationTest do
       assert html =~ "Profil"
     end
 
-    @tag :skip
-    # credo:disable-for-next-line Credo.Check.Design.TagTODO
-    # TODO: Implement user initials in navbar avatar - see issue #170
-    test "shows user initials in avatar", %{conn: conn} do
-      # Setup: Create and login a user
+    test "shows first letter of email in avatar", %{conn: conn, actor: actor} do
+      # Current behavior: sidebar shows first letter of email (see issue #170 for full initials)
       user = create_test_user(%{email: "test.user@example.com"})
+      admin_role = Mv.Fixtures.role_fixture("admin")
+
+      {:ok, user} =
+        user
+        |> Ash.Changeset.for_update(:update, %{})
+        |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
+        |> Ash.update(actor: actor)
+
       conn = conn_with_password_user(conn, user)
       {:ok, _view, html} = live(conn, "/")
 
-      # Initials from test.user@example.com
-      assert html =~ "<span>TU</span>"
+      assert html =~ "avatar"
+      assert html =~ ~r/text-sm font-semibold[^>]*>\s*T\s*</
     end
   end
 

test/mv_web/plugs/check_page_permission_test.exs

@@ -544,88 +544,9 @@ defmodule MvWeb.Plugs.CheckPagePermissionTest do
       assert conn.status == 200
     end
 
-    # Full-router test: session may not preserve member_id; plug logic covered by unit test
-    # "own_data user with linked member can access /members/:id/edit (plug direct call)".
-    @tag role: :member
-    @tag :skip
-    test "GET /members/:id/edit (linked member edit) returns 200 when user has linked member", %{
-      conn: conn,
-      current_user: user
-    } do
-      member = Mv.Fixtures.member_fixture()
-      system_actor = Mv.Helpers.SystemActor.get_system_actor()
-
-      {:ok, user_after_update} =
-        user
-        |> Ash.Changeset.for_update(:update, %{})
-        |> Ash.Changeset.force_set_argument(:member, %{id: member.id})
-        |> Ash.update(actor: system_actor)
-
-      user_with_member =
-        user_after_update
-        |> Ash.load!([:role], domain: Mv.Accounts)
-        |> Mv.Authorization.Actor.ensure_loaded()
-        |> Map.put(:member_id, member.id)
-
-      conn = conn_with_password_user(conn, user_with_member)
-
-      conn = get(conn, "/members/#{member.id}/edit")
-      assert conn.status == 200
-    end
-
-    @tag role: :member
-    @tag :skip
-    test "GET /members/:id/show/edit (linked member show edit) returns 200 when user has linked member",
-         %{
-           conn: conn,
-           current_user: user
-         } do
-      member = Mv.Fixtures.member_fixture()
-      system_actor = Mv.Helpers.SystemActor.get_system_actor()
-
-      {:ok, user_after_update} =
-        user
-        |> Ash.Changeset.for_update(:update, %{})
-        |> Ash.Changeset.force_set_argument(:member, %{id: member.id})
-        |> Ash.update(actor: system_actor)
-
-      user_with_member =
-        user_after_update
-        |> Ash.load!([:role], domain: Mv.Accounts)
-        |> Mv.Authorization.Actor.ensure_loaded()
-        |> Map.put(:member_id, member.id)
-
-      conn = conn_with_password_user(conn, user_with_member)
-
-      conn = get(conn, "/members/#{member.id}/show/edit")
-      assert conn.status == 200
-    end
-
-    # Skipped: MemberLive.Show requires membership fee cycle data; plug allows access
-    # (page loads then LiveView may error).
-    @tag role: :member
-    @tag :skip
-    test "GET /members/:id for linked member returns 200", %{conn: conn, current_user: user} do
-      system_actor = Mv.Helpers.SystemActor.get_system_actor()
-      member = Mv.Fixtures.member_fixture()
-
-      user =
-        user
-        |> Ash.Changeset.for_update(:update_user, %{})
-        |> Ash.Changeset.force_set_argument(:member, %{id: member.id})
-        |> Ash.update(actor: system_actor)
-        |> case do
-          {:ok, u} -> Ash.load!(u, :role, domain: Mv.Accounts, actor: system_actor)
-          {:error, _} -> user
-        end
-
-      conn =
-        conn
-        |> MvWeb.ConnCase.conn_with_password_user(user)
-        |> get("/members/#{member.id}")
-
-      assert conn.status == 200
-    end
+    # Linked-member access to /members/:id and edit routes: full-router tests are not feasible
+    # (session does not preserve member_id after auth). Plug behavior is covered by the unit
+    # tests "own_data user with linked member can access ... (plug direct call)" above.
   end
 
   # read_only (Vorstand/Buchhaltung): allowed /, /members, /members/:id, /groups, /groups/:slug