Improve UX of join requests and fix minor bugs (#492)
All checks were successful
continuous-integration/drone/push Build is passing
All checks were successful
continuous-integration/drone/push Build is passing
## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring This PR improves the join-request flow and presentation quality, fixes several data-display issues in join/join-request screens, and adds a usability improvement in global settings (directly opening the join link). It also includes dependency updates and changelog maintenance. ## What has been changed? - Join form (`JoinLive`) now renders inputs based on actual field types (including checkbox/date/number/email behavior instead of generic text-only handling). - Join form custom-field labels are resolved from configured custom fields (fallback remains safe if lookup fails). - Join-request details page (`JoinRequestLive.Show`) now: - resolves and shows custom field names instead of raw IDs, - formats boolean-like values (`on/true/1`, `off/false/0`) as localized `Yes/No`, - formats ISO date strings for better readability, - keeps legacy field handling while improving output consistency. - Join-request detail layout was improved semantically and visually (`dl/dt/dd` structure for label/value rows). - Global settings page now includes an **Open** button for the join URL (`target="_blank"`, `rel="noopener noreferrer"`, ARIA label). - Added/updated tests around: - join field type rendering, - custom field labels in join-request views, - related auth/global-settings behavior. - Updated translations (`default.pot`, `en`, `de`) for new UI strings. - Updated dependencies/tooling (`mix.lock`, `mix.exs`, CI/renovate-related updates). - Updated `CHANGELOG.md` entries for unreleased changes. ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Reviewer focus areas: - `lib/mv_web/live/join_live.ex`: input type derivation and custom field lookup strategy (`authorize?: false` read path used intentionally for field metadata). - `lib/mv_web/live/join_request_live/show.ex`: value-formatting logic (especially backward compatibility for legacy `form_data` payloads). - `lib/mv_web/live/global_settings_live.ex`: external-link behavior and accessibility attributes. - The branch also contains dependency update commits; please review lockfile and CI-related changes separately from functional join/join-request changes. Reviewed-on: #492 Co-authored-by: Simon <s.thiessen@local-it.org> Co-committed-by: Simon <s.thiessen@local-it.org>
This commit is contained in:
parent
bfa33dcae2
commit
2bb01bd201
14 changed files with 781 additions and 135 deletions
56
lib/mv/membership/custom_field_lookup.ex
Normal file
56
lib/mv/membership/custom_field_lookup.ex
Normal file
|
|
@ -0,0 +1,56 @@
|
|||
defmodule Mv.Membership.CustomFieldLookup do
|
||||
@moduledoc """
|
||||
Shared helper for loading custom fields by ID.
|
||||
"""
|
||||
|
||||
alias Mv.Constants
|
||||
alias Mv.Membership
|
||||
|
||||
@spec fetch_map_by_ids([String.t()], keyword()) :: map()
|
||||
def fetch_map_by_ids(field_ids, opts \\ []) when is_list(field_ids) do
|
||||
member_field_strings = Constants.member_fields() |> Enum.map(&Atom.to_string/1)
|
||||
|
||||
custom_field_ids =
|
||||
field_ids
|
||||
|> Enum.uniq()
|
||||
|> Enum.reject(&(&1 in member_field_strings))
|
||||
|
||||
if custom_field_ids == [] do
|
||||
%{}
|
||||
else
|
||||
select = Keyword.get(opts, :select, [:id, :name, :value_type])
|
||||
|
||||
query =
|
||||
Membership.CustomField
|
||||
|> Ash.Query.select(select)
|
||||
|
||||
read_opts =
|
||||
[domain: Membership]
|
||||
|> maybe_put_actor(opts)
|
||||
|> maybe_put_authorize(opts)
|
||||
|
||||
case Ash.read(query, read_opts) do
|
||||
{:ok, fields} ->
|
||||
allowed_ids = MapSet.new(custom_field_ids)
|
||||
fields |> Enum.filter(&MapSet.member?(allowed_ids, &1.id)) |> Map.new(&{&1.id, &1})
|
||||
|
||||
{:error, _} ->
|
||||
%{}
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
defp maybe_put_actor(opts, read_opts) do
|
||||
case Keyword.fetch(read_opts, :actor) do
|
||||
{:ok, actor} -> Keyword.put(opts, :actor, actor)
|
||||
:error -> opts
|
||||
end
|
||||
end
|
||||
|
||||
defp maybe_put_authorize(opts, read_opts) do
|
||||
case Keyword.fetch(read_opts, :authorize?) do
|
||||
{:ok, authorize?} -> Keyword.put(opts, :authorize?, authorize?)
|
||||
:error -> opts
|
||||
end
|
||||
end
|
||||
end
|
||||
Loading…
Add table
Add a link
Reference in a new issue