feat: add user view tests

test/support/conn_case.ex

@@ -33,16 +33,54 @@ defmodule MvWeb.ConnCase do
 
   @doc """
   Creates a test user and returns the user struct.
+  Accepts attrs to override default values.
+  
+  Password handling:
+  - If `hashed_password` is provided in attrs, it's used directly
+  - If `password` is provided in attrs, it gets hashed automatically
+  - If neither is provided, uses default password "password"
+  
+  ## Examples
+  
+      create_test_user()  # Default user with unique email
+      create_test_user(%{email: "custom@example.com"})  # Custom email
+      create_test_user(%{password: "secret123"})  # Custom password (gets hashed)
+      create_test_user(%{hashed_password: "$2b$..."})  # Pre-hashed password
   """
   def create_test_user(attrs \\ %{}) do
-    email = "user@example.com"
-    password = "password"
-    {:ok, hashed_password} = AshAuthentication.BcryptProvider.hash(password)
+    # Generate unique values to avoid conflicts
+    unique_id = System.unique_integer([:positive])
+    
+    default_attrs = %{
+      email: "user#{unique_id}@example.com",
+      oidc_id: "oidc#{unique_id}"
+    }
+    
+    # Merge provided attrs with defaults
+    user_attrs = Map.merge(default_attrs, attrs)
+    
+    # Handle password/hashed_password
+    final_attrs = cond do
+      # If hashed_password is already provided, use it as-is
+      Map.has_key?(user_attrs, :hashed_password) ->
+        user_attrs
+      
+      # If password is provided, hash it
+      Map.has_key?(user_attrs, :password) ->
+        password = Map.get(user_attrs, :password)
+        {:ok, hashed_password} = AshAuthentication.BcryptProvider.hash(password)
+        user_attrs
+        |> Map.delete(:password)  # Remove plain password
+        |> Map.put(:hashed_password, hashed_password)
+      
+      # Neither provided, use default password
+      true ->
+        password = "password"
+        {:ok, hashed_password} = AshAuthentication.BcryptProvider.hash(password)
+        Map.put(user_attrs, :hashed_password, hashed_password)
+    end
 
-    Ash.Seed.seed!(Mv.Accounts.User, %{
-      email: email,
-      hashed_password: hashed_password
-    })
+    Ash.Seed.seed!(Mv.Accounts.User, final_attrs)
   end
 
   @doc """
@@ -57,8 +95,9 @@ defmodule MvWeb.ConnCase do
 
   @doc """
   Signs in a user via OIDC and returns a connection with the user authenticated.
+  By default creates a user with "user@example.com" for consistency.
   """
-  def conn_with_oidc_user(conn, user_attrs \\ %{}) do
+  def conn_with_oidc_user(conn, user_attrs \\ %{email: "user@example.com"}) do
     user = create_test_user(user_attrs)
     sign_in_user_via_oidc(conn, user)
   end