local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 5 Projects 4 Releases Packages 1 Activity Actions

refactor: extract shared helpers for RoleLive modules

Browse source 
Extract format_error and permission_set_badge_class functions into
MvWeb.RoleLive.Helpers module to eliminate code duplication between
Index and Show LiveViews.
This commit is contained in:
Moritz 2026-01-08 14:25:28 +01:00
parent e3cd400899
commit 32296625fe
Signed by: moritz
GPG key ID: 1020A035E5DD0824
4 changed files with 44 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/mv_web/live/role_live/form.ex
View file

@ -15,6 +15,8 @@ defmodule MvWeb.RoleLive.Form do
alias Mv.Authorization.PermissionSets
import MvWeb.RoleLive.Helpers
on_mount {MvWeb.LiveHelpers, :ensure_user_role_loaded}
@impl true
@ -134,6 +136,7 @@ defmodule MvWeb.RoleLive.Form do
end
rescue
e in [Ash.Error.Invalid] ->
# Handle exceptions that Ash.get might throw (e.g., policy violations)
case e do
%Ash.Error.Invalid{errors: [%Ash.Error.Query.NotFound{} | _]} ->
{:ok,
@ -231,11 +234,4 @@ defmodule MvWeb.RoleLive.Form do
defp return_path("show", _role), do: ~p"/admin/roles"
defp return_path(_, role) when not is_nil(role), do: ~p"/admin/roles/#{role.id}"
defp return_path(_, _role), do: ~p"/admin/roles"
defp format_error(%Ash.Error.Invalid{} = error) do
Enum.map_join(error.errors, ", ", fn e -> e.message end)
end
defp format_error(error) when is_binary(error), do: error
defp format_error(_error), do: gettext("An error occurred")
end