refactor: replace cond with if in handle_delete_role functions

This commit is contained in:
Moritz 2026-01-08 13:54:43 +01:00
parent 75ab046be4
commit 37a2fc3e83
Signed by: moritz
GPG key ID: 1020A035E5DD0824
6 changed files with 31 additions and 33 deletions

View file

@ -63,20 +63,18 @@ defmodule MvWeb.RoleLive.Index do
end
defp handle_delete_role(role, id, socket) do
cond do
role.is_system_role ->
if role.is_system_role do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
else
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
true ->
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
@ -85,9 +83,9 @@ defmodule MvWeb.RoleLive.Index do
count: user_count
)
)}
else
perform_role_deletion(role, id, socket)
end
else
perform_role_deletion(role, id, socket)
end
end
end